mirror of
https://github.com/grafana/grafana.git
synced 2025-02-15 10:03:33 -06:00
* Introduce PluginRequestValidator abstraction with a NoOp implementation * Update PluginRequestValidator abstraction to use the dsURL instead * Inject PluginRequestValidator into the HTTPServer and validate requests going through data source proxy * Inject PluginRequestValidator into the BackendPluginManager and validate requests going through it * Validate requests going through QueryMetrics & QueryMetricsV2 * Validate BackendPluginManager health requests * Fix backend plugins manager tests * Validate requests going through alerting service * Fix tests * fix tests * goimports Co-authored-by: Leonard Gram <leo@xlson.com>
209 lines
7.0 KiB
Go
209 lines
7.0 KiB
Go
package alerting
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/grafana/grafana/pkg/services/validations"
|
|
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
)
|
|
|
|
type conditionStub struct {
|
|
firing bool
|
|
operator string
|
|
matches []*EvalMatch
|
|
noData bool
|
|
}
|
|
|
|
func (c *conditionStub) Eval(context *EvalContext) (*ConditionResult, error) {
|
|
return &ConditionResult{Firing: c.firing, EvalMatches: c.matches, Operator: c.operator, NoDataFound: c.noData}, nil
|
|
}
|
|
|
|
func TestAlertingEvaluationHandler(t *testing.T) {
|
|
Convey("Test alert evaluation handler", t, func() {
|
|
handler := NewEvalHandler()
|
|
|
|
Convey("Show return triggered with single passing condition", func() {
|
|
context := NewEvalContext(context.TODO(), &Rule{
|
|
Conditions: []Condition{&conditionStub{
|
|
firing: true,
|
|
}},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
|
|
handler.Eval(context)
|
|
So(context.Firing, ShouldEqual, true)
|
|
So(context.ConditionEvals, ShouldEqual, "true = true")
|
|
})
|
|
|
|
Convey("Show return triggered with single passing condition2", func() {
|
|
context := NewEvalContext(context.TODO(), &Rule{
|
|
Conditions: []Condition{&conditionStub{firing: true, operator: "and"}},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
|
|
handler.Eval(context)
|
|
So(context.Firing, ShouldEqual, true)
|
|
So(context.ConditionEvals, ShouldEqual, "true = true")
|
|
})
|
|
|
|
Convey("Show return false with not passing asdf", func() {
|
|
context := NewEvalContext(context.TODO(), &Rule{
|
|
Conditions: []Condition{
|
|
&conditionStub{firing: true, operator: "and", matches: []*EvalMatch{{}, {}}},
|
|
&conditionStub{firing: false, operator: "and"},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
|
|
handler.Eval(context)
|
|
So(context.Firing, ShouldEqual, false)
|
|
So(context.ConditionEvals, ShouldEqual, "[true AND false] = false")
|
|
})
|
|
|
|
Convey("Show return true if any of the condition is passing with OR operator", func() {
|
|
context := NewEvalContext(context.TODO(), &Rule{
|
|
Conditions: []Condition{
|
|
&conditionStub{firing: true, operator: "and"},
|
|
&conditionStub{firing: false, operator: "or"},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
|
|
handler.Eval(context)
|
|
So(context.Firing, ShouldEqual, true)
|
|
So(context.ConditionEvals, ShouldEqual, "[true OR false] = true")
|
|
})
|
|
|
|
Convey("Show return false if any of the condition is failing with AND operator", func() {
|
|
context := NewEvalContext(context.TODO(), &Rule{
|
|
Conditions: []Condition{
|
|
&conditionStub{firing: true, operator: "and"},
|
|
&conditionStub{firing: false, operator: "and"},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
|
|
handler.Eval(context)
|
|
So(context.Firing, ShouldEqual, false)
|
|
So(context.ConditionEvals, ShouldEqual, "[true AND false] = false")
|
|
})
|
|
|
|
Convey("Show return true if one condition is failing with nested OR operator", func() {
|
|
context := NewEvalContext(context.TODO(), &Rule{
|
|
Conditions: []Condition{
|
|
&conditionStub{firing: true, operator: "and"},
|
|
&conditionStub{firing: true, operator: "and"},
|
|
&conditionStub{firing: false, operator: "or"},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
|
|
handler.Eval(context)
|
|
So(context.Firing, ShouldEqual, true)
|
|
So(context.ConditionEvals, ShouldEqual, "[[true AND true] OR false] = true")
|
|
})
|
|
|
|
Convey("Show return false if one condition is passing with nested OR operator", func() {
|
|
context := NewEvalContext(context.TODO(), &Rule{
|
|
Conditions: []Condition{
|
|
&conditionStub{firing: true, operator: "and"},
|
|
&conditionStub{firing: false, operator: "and"},
|
|
&conditionStub{firing: false, operator: "or"},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
|
|
handler.Eval(context)
|
|
So(context.Firing, ShouldEqual, false)
|
|
So(context.ConditionEvals, ShouldEqual, "[[true AND false] OR false] = false")
|
|
})
|
|
|
|
Convey("Show return false if a condition is failing with nested AND operator", func() {
|
|
context := NewEvalContext(context.TODO(), &Rule{
|
|
Conditions: []Condition{
|
|
&conditionStub{firing: true, operator: "and"},
|
|
&conditionStub{firing: false, operator: "and"},
|
|
&conditionStub{firing: true, operator: "and"},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
|
|
handler.Eval(context)
|
|
So(context.Firing, ShouldEqual, false)
|
|
So(context.ConditionEvals, ShouldEqual, "[[true AND false] AND true] = false")
|
|
})
|
|
|
|
Convey("Show return true if a condition is passing with nested OR operator", func() {
|
|
context := NewEvalContext(context.TODO(), &Rule{
|
|
Conditions: []Condition{
|
|
&conditionStub{firing: true, operator: "and"},
|
|
&conditionStub{firing: false, operator: "or"},
|
|
&conditionStub{firing: true, operator: "or"},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
|
|
handler.Eval(context)
|
|
So(context.Firing, ShouldEqual, true)
|
|
So(context.ConditionEvals, ShouldEqual, "[[true OR false] OR true] = true")
|
|
})
|
|
|
|
Convey("Should return false if no condition is firing using OR operator", func() {
|
|
context := NewEvalContext(context.TODO(), &Rule{
|
|
Conditions: []Condition{
|
|
&conditionStub{firing: false, operator: "or"},
|
|
&conditionStub{firing: false, operator: "or"},
|
|
&conditionStub{firing: false, operator: "or"},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
|
|
handler.Eval(context)
|
|
So(context.Firing, ShouldEqual, false)
|
|
So(context.ConditionEvals, ShouldEqual, "[[false OR false] OR false] = false")
|
|
})
|
|
|
|
// FIXME: What should the actual test case name be here?
|
|
Convey("Should not return NoDataFound if all conditions have data and using OR", func() {
|
|
context := NewEvalContext(context.TODO(), &Rule{
|
|
Conditions: []Condition{
|
|
&conditionStub{operator: "or", noData: false},
|
|
&conditionStub{operator: "or", noData: false},
|
|
&conditionStub{operator: "or", noData: false},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
|
|
handler.Eval(context)
|
|
So(context.NoDataFound, ShouldBeFalse)
|
|
})
|
|
|
|
Convey("Should return NoDataFound if one condition has no data", func() {
|
|
context := NewEvalContext(context.TODO(), &Rule{
|
|
Conditions: []Condition{
|
|
&conditionStub{operator: "and", noData: true},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
|
|
handler.Eval(context)
|
|
So(context.Firing, ShouldEqual, false)
|
|
So(context.NoDataFound, ShouldBeTrue)
|
|
})
|
|
|
|
Convey("Should not return no data if at least one condition has no data and using AND", func() {
|
|
context := NewEvalContext(context.TODO(), &Rule{
|
|
Conditions: []Condition{
|
|
&conditionStub{operator: "and", noData: true},
|
|
&conditionStub{operator: "and", noData: false},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
|
|
handler.Eval(context)
|
|
So(context.NoDataFound, ShouldBeFalse)
|
|
})
|
|
|
|
Convey("Should return no data if at least one condition has no data and using OR", func() {
|
|
context := NewEvalContext(context.TODO(), &Rule{
|
|
Conditions: []Condition{
|
|
&conditionStub{operator: "or", noData: true},
|
|
&conditionStub{operator: "or", noData: false},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
|
|
handler.Eval(context)
|
|
So(context.NoDataFound, ShouldBeTrue)
|
|
})
|
|
})
|
|
}
|