mirror of
https://github.com/grafana/grafana.git
synced 2025-02-13 00:55:47 -06:00
Co-authored-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com> Co-authored-by: gotjosh <josue.abreu@gmail.com> Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
202 lines
6.7 KiB
TypeScript
202 lines
6.7 KiB
TypeScript
import { renderHook } from '@testing-library/react-hooks';
|
|
import React from 'react';
|
|
import { Provider } from 'react-redux';
|
|
|
|
import { contextSrv } from 'app/core/services/context_srv';
|
|
import { AccessControlAction, FolderDTO, StoreState } from 'app/types';
|
|
|
|
import {
|
|
disableRBAC,
|
|
enableRBAC,
|
|
mockFolder,
|
|
mockRulerAlertingRule,
|
|
mockRulerGrafanaRule,
|
|
mockUnifiedAlertingStore,
|
|
} from '../mocks';
|
|
|
|
import { useFolder } from './useFolder';
|
|
import { useIsRuleEditable } from './useIsRuleEditable';
|
|
import { useUnifiedAlertingSelector } from './useUnifiedAlertingSelector';
|
|
|
|
jest.mock('./useFolder');
|
|
|
|
const mocks = {
|
|
useFolder: jest.mocked(useFolder),
|
|
useUnifiedAlertingSelector: jest.mocked(useUnifiedAlertingSelector),
|
|
};
|
|
|
|
describe('useIsRuleEditable', () => {
|
|
describe('RBAC enabled', () => {
|
|
beforeEach(enableRBAC);
|
|
describe('Grafana rules', () => {
|
|
// When RBAC is enabled we require appropriate alerting permissions in the folder scope
|
|
it('Should allow editing when the user has the alert rule update permission in the folder', () => {
|
|
mockUseFolder({
|
|
accessControl: {
|
|
[AccessControlAction.AlertingRuleUpdate]: true,
|
|
},
|
|
});
|
|
|
|
const wrapper = getProviderWrapper();
|
|
|
|
const { result } = renderHook(() => useIsRuleEditable('grafana', mockRulerGrafanaRule()), { wrapper });
|
|
|
|
expect(result.current.loading).toBe(false);
|
|
expect(result.current.isEditable).toBe(true);
|
|
});
|
|
|
|
it('Should allow deleting when the user has the alert rule delete permission', () => {
|
|
mockUseFolder({
|
|
accessControl: {
|
|
[AccessControlAction.AlertingRuleDelete]: true,
|
|
},
|
|
});
|
|
|
|
const wrapper = getProviderWrapper();
|
|
|
|
const { result } = renderHook(() => useIsRuleEditable('grafana', mockRulerGrafanaRule()), { wrapper });
|
|
|
|
expect(result.current.loading).toBe(false);
|
|
expect(result.current.isRemovable).toBe(true);
|
|
});
|
|
|
|
it('Should forbid editing when the user has no alert rule update permission', () => {
|
|
mockUseFolder({ accessControl: {} });
|
|
|
|
const wrapper = getProviderWrapper();
|
|
|
|
const { result } = renderHook(() => useIsRuleEditable('grafana', mockRulerGrafanaRule()), { wrapper });
|
|
|
|
expect(result.current.loading).toBe(false);
|
|
expect(result.current.isEditable).toBe(false);
|
|
});
|
|
|
|
it('Should forbid deleting when the user has no alert rule delete permission', () => {
|
|
mockUseFolder({ accessControl: {} });
|
|
|
|
const wrapper = getProviderWrapper();
|
|
|
|
const { result } = renderHook(() => useIsRuleEditable('grafana', mockRulerGrafanaRule()), { wrapper });
|
|
|
|
expect(result.current.loading).toBe(false);
|
|
expect(result.current.isRemovable).toBe(false);
|
|
});
|
|
|
|
it('Should allow editing and deleting when the user has alert rule permissions but does not have folder canSave permission', () => {
|
|
mockUseFolder({
|
|
canSave: false,
|
|
accessControl: {
|
|
[AccessControlAction.AlertingRuleUpdate]: true,
|
|
[AccessControlAction.AlertingRuleDelete]: true,
|
|
},
|
|
});
|
|
|
|
const wrapper = getProviderWrapper();
|
|
|
|
const { result } = renderHook(() => useIsRuleEditable('grafana', mockRulerGrafanaRule()), { wrapper });
|
|
|
|
expect(result.current.loading).toBe(false);
|
|
expect(result.current.isEditable).toBe(true);
|
|
expect(result.current.isRemovable).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe('Cloud rules', () => {
|
|
beforeEach(() => {
|
|
contextSrv.isEditor = true;
|
|
});
|
|
|
|
it('Should allow editing and deleting when the user has alert rule external write permission', () => {
|
|
mockPermissions([AccessControlAction.AlertingRuleExternalWrite]);
|
|
const wrapper = getProviderWrapper();
|
|
|
|
const { result } = renderHook(() => useIsRuleEditable('cortex', mockRulerAlertingRule()), { wrapper });
|
|
|
|
expect(result.current.loading).toBe(false);
|
|
expect(result.current.isEditable).toBe(true);
|
|
expect(result.current.isRemovable).toBe(true);
|
|
});
|
|
|
|
it('Should forbid editing and deleting when the user has no alert rule external write permission', () => {
|
|
mockPermissions([]);
|
|
const wrapper = getProviderWrapper();
|
|
|
|
const { result } = renderHook(() => useIsRuleEditable('cortex', mockRulerAlertingRule()), { wrapper });
|
|
|
|
expect(result.current.loading).toBe(false);
|
|
expect(result.current.isEditable).toBe(false);
|
|
expect(result.current.isRemovable).toBe(false);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('RBAC disabled', () => {
|
|
beforeEach(disableRBAC);
|
|
describe('Grafana rules', () => {
|
|
it('Should allow editing and deleting when the user has folder canSave permission', () => {
|
|
mockUseFolder({ canSave: true });
|
|
|
|
const wrapper = getProviderWrapper();
|
|
|
|
const { result } = renderHook(() => useIsRuleEditable('grafana', mockRulerGrafanaRule()), { wrapper });
|
|
|
|
expect(result.current.loading).toBe(false);
|
|
expect(result.current.isEditable).toBe(true);
|
|
expect(result.current.isRemovable).toBe(true);
|
|
});
|
|
|
|
it('Should forbid editing and deleting when the user has no folder canSave permission', () => {
|
|
mockUseFolder({ canSave: false });
|
|
|
|
const wrapper = getProviderWrapper();
|
|
|
|
const { result } = renderHook(() => useIsRuleEditable('grafana', mockRulerGrafanaRule()), { wrapper });
|
|
|
|
expect(result.current.loading).toBe(false);
|
|
expect(result.current.isEditable).toBe(false);
|
|
expect(result.current.isRemovable).toBe(false);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
function mockUseFolder(partial?: Partial<FolderDTO>) {
|
|
mocks.useFolder.mockReturnValue({ loading: false, folder: mockFolder(partial) });
|
|
}
|
|
|
|
function mockPermissions(grantedPermissions: AccessControlAction[]) {
|
|
jest
|
|
.spyOn(contextSrv, 'hasPermission')
|
|
.mockImplementation((action) => grantedPermissions.includes(action as AccessControlAction));
|
|
}
|
|
|
|
function getProviderWrapper() {
|
|
const dataSources = getMockedDataSources();
|
|
const store = mockUnifiedAlertingStore({ dataSources });
|
|
const wrapper: React.FC = ({ children }) => <Provider store={store}>{children}</Provider>;
|
|
return wrapper;
|
|
}
|
|
|
|
function getMockedDataSources(): StoreState['unifiedAlerting']['dataSources'] {
|
|
return {
|
|
grafana: {
|
|
loading: false,
|
|
dispatched: false,
|
|
result: {
|
|
id: 'grafana',
|
|
name: 'grafana',
|
|
rulerConfig: { dataSourceName: 'grafana', apiVersion: 'legacy' },
|
|
},
|
|
},
|
|
cortex: {
|
|
loading: false,
|
|
dispatched: false,
|
|
result: {
|
|
id: 'cortex',
|
|
name: 'Cortex',
|
|
rulerConfig: { dataSourceName: 'cortex', apiVersion: 'legacy' },
|
|
},
|
|
},
|
|
};
|
|
}
|