Files
grafana/public/app/features/alerting/unified/components/expressions/util.test.ts
Sofia Papagiannaki d1dab5828d Alerting: Update rule API to address folders by UID (#74600)
* Change ruler API to expect the folder UID as namespace

* Update example requests

* Fix tests

* Update swagger

* Modify FIle field in /api/prometheus/grafana/api/v1/rules

* Fix ruler export

* Modify folder in responses to be formatted as <parent UID>/<title>

* Add alerting test with nested folders

* Apply suggestion from code review

* Alerting: use folder UID instead of title in rule API (#77166)

Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>

* Drop a few more latent uses of namespace_id

* move getNamespaceKey to models package

* switch GetAlertRulesForScheduling to use folder table

* update GetAlertRulesForScheduling to return folder titles in format `parent_uid/title`.

* fi tests

* add tests for GetAlertRulesForScheduling when parent uid

* fix integration tests after merge

* fix test after merge

* change format of the namespace to JSON array

this is needed for forward compatibility, when we migrate to full paths

* update EF code to decode nested folder

---------

Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>
Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com>
Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>
Co-authored-by: Alex Weaver <weaver.alex.d@gmail.com>
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2024-01-17 11:07:39 +02:00

218 lines
5.8 KiB
TypeScript

import { DataFrame, FieldType, toDataFrame } from '@grafana/data';
import { CombinedRuleNamespace } from 'app/types/unified-alerting';
import { mockDataSource } from '../../mocks';
import { GRAFANA_RULES_SOURCE_NAME } from '../../utils/datasource';
import {
decodeGrafanaNamespace,
formatLabels,
getSeriesLabels,
getSeriesName,
getSeriesValue,
isEmptySeries,
} from './util';
const EMPTY_FRAME: DataFrame = toDataFrame([]);
const NAMED_FRAME: DataFrame = {
name: 'MyFrame',
...toDataFrame([]),
};
const DATA_FRAME: DataFrame = toDataFrame({
fields: [{ name: 'value', type: FieldType.number, values: [1, 2, 3] }],
});
const DATA_FRAME_LARGE_DECIMAL: DataFrame = toDataFrame({
fields: [{ name: 'value', type: FieldType.number, values: [1.23456789] }],
});
const DATA_FRAME_WITH_LABELS: DataFrame = toDataFrame({
fields: [{ name: 'value', type: FieldType.number, values: [1, 2, 3], labels: { __name__: 'my-series', foo: 'bar' } }],
});
describe('formatLabels', () => {
it('should work with no labels', () => {
expect(formatLabels({})).toBe('');
});
it('should work with 1 label', () => {
expect(formatLabels({ foo: 'bar' })).toBe('foo=bar');
});
it('should work with multiple labels', () => {
expect(formatLabels({ foo: 'bar', baz: 'qux' })).toBe('foo=bar, baz=qux');
});
});
describe('decodeGrafanaNamespace', () => {
it('should work for regular Grafana namespaces', () => {
const grafanaNamespace: CombinedRuleNamespace = {
name: `my_rule_namespace`,
rulesSource: GRAFANA_RULES_SOURCE_NAME,
groups: [
{
name: 'group1',
rules: [],
totals: {},
},
],
};
expect(decodeGrafanaNamespace(grafanaNamespace)).toBe('my_rule_namespace');
});
it('should work for Grafana namespaces in nested folders format', () => {
const grafanaNamespace: CombinedRuleNamespace = {
name: `["parentUID","my_rule_namespace"]`,
rulesSource: GRAFANA_RULES_SOURCE_NAME,
groups: [
{
name: 'group1',
rules: [],
totals: {},
},
],
};
expect(decodeGrafanaNamespace(grafanaNamespace)).toBe('my_rule_namespace');
});
it('should default to name if format is invalid: invalid JSON', () => {
const grafanaNamespace: CombinedRuleNamespace = {
name: `["parentUID"`,
rulesSource: GRAFANA_RULES_SOURCE_NAME,
groups: [
{
name: 'group1',
rules: [],
totals: {},
},
],
};
expect(decodeGrafanaNamespace(grafanaNamespace)).toBe(`["parentUID"`);
});
it('should default to name if format is invalid: empty array', () => {
const grafanaNamespace: CombinedRuleNamespace = {
name: `[]`,
rulesSource: GRAFANA_RULES_SOURCE_NAME,
groups: [
{
name: 'group1',
rules: [],
totals: {},
},
],
};
expect(decodeGrafanaNamespace(grafanaNamespace)).toBe(`[]`);
});
it('grab folder name if format is long array', () => {
const grafanaNamespace: CombinedRuleNamespace = {
name: `["parentUID","my_rule_namespace","another_part"]`,
rulesSource: GRAFANA_RULES_SOURCE_NAME,
groups: [
{
name: 'group1',
rules: [],
totals: {},
},
],
};
expect(decodeGrafanaNamespace(grafanaNamespace)).toBe('another_part');
});
it('should not change output for cloud namespaces', () => {
const cloudNamespace: CombinedRuleNamespace = {
name: `["parentUID","my_rule_namespace"]`,
rulesSource: mockDataSource(),
groups: [
{
name: 'Prom group',
rules: [],
totals: {},
},
],
};
expect(decodeGrafanaNamespace(cloudNamespace)).toBe(`["parentUID","my_rule_namespace"]`);
});
});
describe('isEmptySeries', () => {
it('should be true for empty series', () => {
expect(isEmptySeries([EMPTY_FRAME])).toBe(true);
expect(isEmptySeries([EMPTY_FRAME, EMPTY_FRAME])).toBe(true);
expect(isEmptySeries([DATA_FRAME])).toBe(false);
expect(isEmptySeries([EMPTY_FRAME, DATA_FRAME])).toBe(false);
});
});
describe('getSeriesName', () => {
it('should work with named data frame', () => {
const name = getSeriesName(NAMED_FRAME);
expect(name).toBe('MyFrame');
});
it('should work with empty data frame', () => {
expect(getSeriesName(EMPTY_FRAME)).toBe(undefined);
});
it('should work with __name__ labeled frame', () => {
const name = getSeriesName(DATA_FRAME_WITH_LABELS);
expect(name).toBe('my-series');
});
it('should work with NoData frames', () => {
expect(getSeriesName(EMPTY_FRAME)).toBe(undefined);
});
it('should give preference to displayNameFromDS', () => {
const frame: DataFrame = {
name: 'MyFrame',
...toDataFrame({
fields: [
{
name: 'value',
type: FieldType.number,
values: [1, 2, 3],
labels: { foo: 'bar' },
config: { displayNameFromDS: 'series-name-override' },
},
],
}),
};
expect(getSeriesName(frame)).toBe('series-name-override');
});
});
describe('getSeriesValue', () => {
it('should work with empty data frame', () => {
expect(getSeriesValue(EMPTY_FRAME)).toBe(undefined);
});
it('should work with data frame', () => {
const name = getSeriesValue(DATA_FRAME);
expect(name).toBe(1);
});
it('should round values', () => {
expect(getSeriesValue(DATA_FRAME_LARGE_DECIMAL)).toBe(1.23457);
});
});
describe('getSeriesLabels', () => {
it('should work for dataframe with labels', () => {
expect(getSeriesLabels(DATA_FRAME_WITH_LABELS)).toStrictEqual({ __name__: 'my-series', foo: 'bar' });
});
it('should work for dataframe with no labels', () => {
expect(getSeriesLabels(EMPTY_FRAME)).toStrictEqual({});
});
});