mirror of
https://github.com/grafana/grafana.git
synced 2025-02-12 00:25:46 -06:00
Refactors GetPluginDashboards/LoadPluginDashboard by moving database interaction from plugin management to the plugindashboards service. Fixes #44553 Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>
93 lines
2.4 KiB
Go
93 lines
2.4 KiB
Go
package manager
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io/fs"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
"github.com/grafana/grafana/pkg/plugins"
|
|
"github.com/grafana/grafana/pkg/util"
|
|
)
|
|
|
|
var openDashboardFile = func(name string) (fs.File, error) {
|
|
// Wrapping in filepath.Clean to properly handle
|
|
// gosec G304 Potential file inclusion via variable rule.
|
|
return os.Open(filepath.Clean(name))
|
|
}
|
|
|
|
func (m *PluginManager) ListPluginDashboardFiles(ctx context.Context, args *plugins.ListPluginDashboardFilesArgs) (*plugins.ListPluginDashboardFilesResult, error) {
|
|
if args == nil {
|
|
return nil, fmt.Errorf("args cannot be nil")
|
|
}
|
|
|
|
if len(strings.TrimSpace(args.PluginID)) == 0 {
|
|
return nil, fmt.Errorf("args.PluginID cannot be empty")
|
|
}
|
|
|
|
plugin, exists := m.Plugin(ctx, args.PluginID)
|
|
if !exists {
|
|
return nil, plugins.NotFoundError{PluginID: args.PluginID}
|
|
}
|
|
|
|
references := []string{}
|
|
for _, include := range plugin.DashboardIncludes() {
|
|
references = append(references, include.Path)
|
|
}
|
|
|
|
return &plugins.ListPluginDashboardFilesResult{
|
|
FileReferences: references,
|
|
}, nil
|
|
}
|
|
|
|
func (m *PluginManager) GetPluginDashboardFileContents(ctx context.Context, args *plugins.GetPluginDashboardFileContentsArgs) (*plugins.GetPluginDashboardFileContentsResult, error) {
|
|
if args == nil {
|
|
return nil, fmt.Errorf("args cannot be nil")
|
|
}
|
|
|
|
if len(strings.TrimSpace(args.PluginID)) == 0 {
|
|
return nil, fmt.Errorf("args.PluginID cannot be empty")
|
|
}
|
|
|
|
if len(strings.TrimSpace(args.FileReference)) == 0 {
|
|
return nil, fmt.Errorf("args.FileReference cannot be empty")
|
|
}
|
|
|
|
plugin, exists := m.Plugin(ctx, args.PluginID)
|
|
if !exists {
|
|
return nil, plugins.NotFoundError{PluginID: args.PluginID}
|
|
}
|
|
|
|
var includedFile *plugins.Includes
|
|
for _, include := range plugin.DashboardIncludes() {
|
|
if args.FileReference == include.Path {
|
|
includedFile = include
|
|
break
|
|
}
|
|
}
|
|
|
|
if includedFile == nil {
|
|
return nil, fmt.Errorf("plugin dashboard file not found")
|
|
}
|
|
|
|
cleanPath, err := util.CleanRelativePath(includedFile.Path)
|
|
if err != nil {
|
|
// CleanRelativePath should clean and make the path relative so this is not expected to fail
|
|
return nil, err
|
|
}
|
|
|
|
dashboardFilePath := filepath.Join(plugin.PluginDir, cleanPath)
|
|
file, err := openDashboardFile(dashboardFilePath)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &plugins.GetPluginDashboardFileContentsResult{
|
|
Content: file,
|
|
}, nil
|
|
}
|
|
|
|
var _ plugins.DashboardFileStore = &PluginManager{}
|