mirror of
https://github.com/grafana/grafana.git
synced 2024-11-27 11:20:27 -06:00
6fa53a1ee4
* Alerting: Opsgenie send tags as extra properties Allow users to select where to send notification tags when alerting via OpsGenie. Supports sending tags as key/value details, concatenated strings in tags or both. Users will be able to see their tags as key/values under extra properties in an alert on the Opsgenie UI. These key/values can then be used in the platform for routing, templating etc. * Configurable delivery to either tags, extra properties or both * Default to current behaviour (tags only) * Support both so users can transition from tags to details Add docs and clean up references * Alerting: Add additional arg for Opsgenie tests The NewEvalContext function now requires a 'PluginRequestValidator' argument. As our test does not use the validator we can specify 'nil' to satisfy the function and allow our test to pass as expected. * Alerting: Opsgenie doc fixes Accept suggested changes for Opsgenie docs Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * Alerting: Opsgenie provisioning settings docs Add the new setting to the provisioning docs * Alerting: Opsgenie doc typo correction Move the comma (,) out of the preformatting tags for the setting value * Alerting: Opsgenie refactor send switches Refactor the send switches to be methods on the OpsgenieNotiefier itself. This also cleans up the method names so that the code reads a bit more logically as: if we should send details: send details if we should send tags: send tags This avoids the calling code needing to care about passing the state and allows an engineer working in the `createAlert` function to focus on the results of applying the logic instead. * Alerting: Opsgenie docs rename note Rename the note heading to match the number to more clearly link them. * Alerting: Opsgenie use standard reference to note Refer to the note below as per recommendation and standards. Fixes #30331 Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
227 lines
6.9 KiB
Go
227 lines
6.9 KiB
Go
package notifiers
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/grafana/grafana/pkg/services/validations"
|
|
|
|
"github.com/grafana/grafana/pkg/bus"
|
|
"github.com/grafana/grafana/pkg/components/simplejson"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
"github.com/grafana/grafana/pkg/services/alerting"
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
)
|
|
|
|
func TestOpsGenieNotifier(t *testing.T) {
|
|
Convey("OpsGenie notifier tests", t, func() {
|
|
Convey("Parsing alert notification from settings", func() {
|
|
Convey("empty settings should return error", func() {
|
|
json := `{ }`
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "opsgenie_testing",
|
|
Type: "opsgenie",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
_, err := NewOpsGenieNotifier(model)
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
|
|
Convey("settings should trigger incident", func() {
|
|
json := `
|
|
{
|
|
"apiKey": "abcdefgh0123456789"
|
|
}`
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "opsgenie_testing",
|
|
Type: "opsgenie",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
not, err := NewOpsGenieNotifier(model)
|
|
opsgenieNotifier := not.(*OpsGenieNotifier)
|
|
|
|
So(err, ShouldBeNil)
|
|
So(opsgenieNotifier.Name, ShouldEqual, "opsgenie_testing")
|
|
So(opsgenieNotifier.Type, ShouldEqual, "opsgenie")
|
|
So(opsgenieNotifier.APIKey, ShouldEqual, "abcdefgh0123456789")
|
|
})
|
|
})
|
|
|
|
Convey("Handling notification tags", func() {
|
|
Convey("invalid sendTagsAs value should return error", func() {
|
|
json := `{
|
|
"apiKey": "abcdefgh0123456789",
|
|
"sendTagsAs": "not_a_valid_value"
|
|
}`
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "opsgenie_testing",
|
|
Type: "opsgenie",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
_, err := NewOpsGenieNotifier(model)
|
|
So(err, ShouldNotBeNil)
|
|
So(err, ShouldHaveSameTypeAs, alerting.ValidationError{})
|
|
So(err.Error(), ShouldEndWith, "Invalid value for sendTagsAs: \"not_a_valid_value\"")
|
|
})
|
|
|
|
Convey("alert payload should include tag pairs only as an array in the tags key when sendAsTags is not set", func() {
|
|
json := `{
|
|
"apiKey": "abcdefgh0123456789"
|
|
}`
|
|
|
|
tagPairs := []*models.Tag{
|
|
{Key: "keyOnly"},
|
|
{Key: "aKey", Value: "aValue"},
|
|
}
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "opsgenie_testing",
|
|
Type: "opsgenie",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
notifier, notifierErr := NewOpsGenieNotifier(model) // unhandled error
|
|
|
|
opsgenieNotifier := notifier.(*OpsGenieNotifier)
|
|
|
|
evalContext := alerting.NewEvalContext(context.Background(), &alerting.Rule{
|
|
ID: 0,
|
|
Name: "someRule",
|
|
Message: "someMessage",
|
|
State: models.AlertStateAlerting,
|
|
AlertRuleTags: tagPairs,
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
evalContext.IsTestRun = true
|
|
|
|
tags := make([]string, 0)
|
|
details := make(map[string]interface{})
|
|
bus.AddHandlerCtx("alerting", func(ctx context.Context, cmd *models.SendWebhookSync) error {
|
|
bodyJSON, err := simplejson.NewJson([]byte(cmd.Body))
|
|
if err == nil {
|
|
tags = bodyJSON.Get("tags").MustStringArray([]string{})
|
|
details = bodyJSON.Get("details").MustMap(map[string]interface{}{})
|
|
}
|
|
return err
|
|
})
|
|
|
|
alertErr := opsgenieNotifier.createAlert(evalContext)
|
|
|
|
So(notifierErr, ShouldBeNil)
|
|
So(alertErr, ShouldBeNil)
|
|
So(tags, ShouldResemble, []string{"keyOnly", "aKey:aValue"})
|
|
So(details, ShouldResemble, map[string]interface{}{"url": ""})
|
|
})
|
|
|
|
Convey("alert payload should include tag pairs only as a map in the details key when sendAsTags=details", func() {
|
|
json := `{
|
|
"apiKey": "abcdefgh0123456789",
|
|
"sendTagsAs": "details"
|
|
}`
|
|
|
|
tagPairs := []*models.Tag{
|
|
{Key: "keyOnly"},
|
|
{Key: "aKey", Value: "aValue"},
|
|
}
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "opsgenie_testing",
|
|
Type: "opsgenie",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
notifier, notifierErr := NewOpsGenieNotifier(model) // unhandled error
|
|
|
|
opsgenieNotifier := notifier.(*OpsGenieNotifier)
|
|
|
|
evalContext := alerting.NewEvalContext(context.Background(), &alerting.Rule{
|
|
ID: 0,
|
|
Name: "someRule",
|
|
Message: "someMessage",
|
|
State: models.AlertStateAlerting,
|
|
AlertRuleTags: tagPairs,
|
|
}, nil)
|
|
evalContext.IsTestRun = true
|
|
|
|
tags := make([]string, 0)
|
|
details := make(map[string]interface{})
|
|
bus.AddHandlerCtx("alerting", func(ctx context.Context, cmd *models.SendWebhookSync) error {
|
|
bodyJSON, err := simplejson.NewJson([]byte(cmd.Body))
|
|
if err == nil {
|
|
tags = bodyJSON.Get("tags").MustStringArray([]string{})
|
|
details = bodyJSON.Get("details").MustMap(map[string]interface{}{})
|
|
}
|
|
return err
|
|
})
|
|
|
|
alertErr := opsgenieNotifier.createAlert(evalContext)
|
|
|
|
So(notifierErr, ShouldBeNil)
|
|
So(alertErr, ShouldBeNil)
|
|
So(tags, ShouldResemble, []string{})
|
|
So(details, ShouldResemble, map[string]interface{}{"keyOnly": "", "aKey": "aValue", "url": ""})
|
|
})
|
|
|
|
Convey("alert payload should include tag pairs as both a map in the details key and an array in the tags key when sendAsTags=both", func() {
|
|
json := `{
|
|
"apiKey": "abcdefgh0123456789",
|
|
"sendTagsAs": "both"
|
|
}`
|
|
|
|
tagPairs := []*models.Tag{
|
|
{Key: "keyOnly"},
|
|
{Key: "aKey", Value: "aValue"},
|
|
}
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "opsgenie_testing",
|
|
Type: "opsgenie",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
notifier, notifierErr := NewOpsGenieNotifier(model) // unhandled error
|
|
|
|
opsgenieNotifier := notifier.(*OpsGenieNotifier)
|
|
|
|
evalContext := alerting.NewEvalContext(context.Background(), &alerting.Rule{
|
|
ID: 0,
|
|
Name: "someRule",
|
|
Message: "someMessage",
|
|
State: models.AlertStateAlerting,
|
|
AlertRuleTags: tagPairs,
|
|
}, nil)
|
|
evalContext.IsTestRun = true
|
|
|
|
tags := make([]string, 0)
|
|
details := make(map[string]interface{})
|
|
bus.AddHandlerCtx("alerting", func(ctx context.Context, cmd *models.SendWebhookSync) error {
|
|
bodyJSON, err := simplejson.NewJson([]byte(cmd.Body))
|
|
if err == nil {
|
|
tags = bodyJSON.Get("tags").MustStringArray([]string{})
|
|
details = bodyJSON.Get("details").MustMap(map[string]interface{}{})
|
|
}
|
|
return err
|
|
})
|
|
|
|
alertErr := opsgenieNotifier.createAlert(evalContext)
|
|
|
|
So(notifierErr, ShouldBeNil)
|
|
So(alertErr, ShouldBeNil)
|
|
So(tags, ShouldResemble, []string{"keyOnly", "aKey:aValue"})
|
|
So(details, ShouldResemble, map[string]interface{}{"keyOnly": "", "aKey": "aValue", "url": ""})
|
|
})
|
|
})
|
|
})
|
|
}
|