mirror of
https://github.com/grafana/grafana.git
synced 2024-11-26 10:50:37 -06:00
22788d1d86
* Add an option to hide certain users in the UI * revert changes for admin users routes * fix sqlstore function name * Improve slice management Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> * Hidden users: convert slice to map * filter with user logins instead of IDs * put HiddenUsers in Cfg struct * hide hidden users from dashboards/folders permissions list * Update conf/defaults.ini Co-authored-by: Torkel Ödegaard <torkel@grafana.com> * fix params order * fix tests * fix dashboard/folder update with hidden user * add team tests * add dashboard and folder permissions tests * fixes after merge * fix tests * API: add test for org users endpoints * update hidden users management for dashboard / folder permissions * improve dashboard / folder permissions tests * fixes after merge * Guardian: add hidden acl tests * API: add team members tests * fix team sql syntax for postgres * api tests update * fix linter error * fix tests errors after merge Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> Co-authored-by: Torkel Ödegaard <torkel@grafana.com> Co-authored-by: Leonard Gram <leo@xlson.com>
137 lines
3.6 KiB
Go
137 lines
3.6 KiB
Go
package api
|
|
|
|
import (
|
|
"errors"
|
|
"time"
|
|
|
|
"github.com/grafana/grafana/pkg/api/dtos"
|
|
"github.com/grafana/grafana/pkg/bus"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
"github.com/grafana/grafana/pkg/services/dashboards"
|
|
"github.com/grafana/grafana/pkg/services/guardian"
|
|
"github.com/grafana/grafana/pkg/util"
|
|
)
|
|
|
|
func (hs *HTTPServer) GetFolderPermissionList(c *models.ReqContext) Response {
|
|
s := dashboards.NewFolderService(c.OrgId, c.SignedInUser)
|
|
folder, err := s.GetFolderByUID(c.Params(":uid"))
|
|
|
|
if err != nil {
|
|
return toFolderError(err)
|
|
}
|
|
|
|
g := guardian.New(folder.Id, c.OrgId, c.SignedInUser)
|
|
|
|
if canAdmin, err := g.CanAdmin(); err != nil || !canAdmin {
|
|
return toFolderError(models.ErrFolderAccessDenied)
|
|
}
|
|
|
|
acl, err := g.GetAcl()
|
|
if err != nil {
|
|
return Error(500, "Failed to get folder permissions", err)
|
|
}
|
|
|
|
filteredAcls := make([]*models.DashboardAclInfoDTO, 0, len(acl))
|
|
for _, perm := range acl {
|
|
if dtos.IsHiddenUser(perm.UserLogin, c.SignedInUser, hs.Cfg) {
|
|
continue
|
|
}
|
|
|
|
perm.FolderId = folder.Id
|
|
perm.DashboardId = 0
|
|
|
|
perm.UserAvatarUrl = dtos.GetGravatarUrl(perm.UserEmail)
|
|
|
|
if perm.TeamId > 0 {
|
|
perm.TeamAvatarUrl = dtos.GetGravatarUrlWithDefault(perm.TeamEmail, perm.Team)
|
|
}
|
|
|
|
if perm.Slug != "" {
|
|
perm.Url = models.GetDashboardFolderUrl(perm.IsFolder, perm.Uid, perm.Slug)
|
|
}
|
|
|
|
filteredAcls = append(filteredAcls, perm)
|
|
}
|
|
|
|
return JSON(200, filteredAcls)
|
|
}
|
|
|
|
func (hs *HTTPServer) UpdateFolderPermissions(c *models.ReqContext, apiCmd dtos.UpdateDashboardAclCommand) Response {
|
|
if err := validatePermissionsUpdate(apiCmd); err != nil {
|
|
return Error(400, err.Error(), err)
|
|
}
|
|
|
|
s := dashboards.NewFolderService(c.OrgId, c.SignedInUser)
|
|
folder, err := s.GetFolderByUID(c.Params(":uid"))
|
|
|
|
if err != nil {
|
|
return toFolderError(err)
|
|
}
|
|
|
|
g := guardian.New(folder.Id, c.OrgId, c.SignedInUser)
|
|
canAdmin, err := g.CanAdmin()
|
|
if err != nil {
|
|
return toFolderError(err)
|
|
}
|
|
|
|
if !canAdmin {
|
|
return toFolderError(models.ErrFolderAccessDenied)
|
|
}
|
|
|
|
cmd := models.UpdateDashboardAclCommand{}
|
|
cmd.DashboardID = folder.Id
|
|
|
|
for _, item := range apiCmd.Items {
|
|
cmd.Items = append(cmd.Items, &models.DashboardAcl{
|
|
OrgID: c.OrgId,
|
|
DashboardID: folder.Id,
|
|
UserID: item.UserID,
|
|
TeamID: item.TeamID,
|
|
Role: item.Role,
|
|
Permission: item.Permission,
|
|
Created: time.Now(),
|
|
Updated: time.Now(),
|
|
})
|
|
}
|
|
|
|
hiddenACL, err := g.GetHiddenACL(hs.Cfg)
|
|
if err != nil {
|
|
return Error(500, "Error while retrieving hidden permissions", err)
|
|
}
|
|
cmd.Items = append(cmd.Items, hiddenACL...)
|
|
|
|
if okToUpdate, err := g.CheckPermissionBeforeUpdate(models.PERMISSION_ADMIN, cmd.Items); err != nil || !okToUpdate {
|
|
if err != nil {
|
|
if errors.Is(err, guardian.ErrGuardianPermissionExists) ||
|
|
errors.Is(err, guardian.ErrGuardianOverride) {
|
|
return Error(400, err.Error(), err)
|
|
}
|
|
|
|
return Error(500, "Error while checking folder permissions", err)
|
|
}
|
|
|
|
return Error(403, "Cannot remove own admin permission for a folder", nil)
|
|
}
|
|
|
|
if err := bus.Dispatch(&cmd); err != nil {
|
|
if errors.Is(err, models.ErrDashboardAclInfoMissing) {
|
|
err = models.ErrFolderAclInfoMissing
|
|
}
|
|
if errors.Is(err, models.ErrDashboardPermissionDashboardEmpty) {
|
|
err = models.ErrFolderPermissionFolderEmpty
|
|
}
|
|
|
|
if errors.Is(err, models.ErrFolderAclInfoMissing) || errors.Is(err, models.ErrFolderPermissionFolderEmpty) {
|
|
return Error(409, err.Error(), err)
|
|
}
|
|
|
|
return Error(500, "Failed to create permission", err)
|
|
}
|
|
|
|
return JSON(200, util.DynMap{
|
|
"message": "Folder permissions updated",
|
|
"id": folder.Id,
|
|
"title": folder.Title,
|
|
})
|
|
}
|