mirror of
https://github.com/grafana/grafana.git
synced 2024-12-01 21:19:28 -06:00
8fd153edb7
Existing /api/alert-notifications now requires at least editor access. Existing /api/alert-notifiers now requires at least editor access. New /api/alert-notifications/lookup returns less information than /api/alert-notifications and can be access by any authenticated user. Existing /api/org/users now requires org admin role. New /api/org/users/lookup returns less information than /api/org/users and can be access by users that are org admins, admin in any folder or admin of any team. UserPicker component now uses /api/org/users/lookup instead of /api/org/users. Fixes #17318
170 lines
4.1 KiB
Go
170 lines
4.1 KiB
Go
package sqlstore
|
|
|
|
import (
|
|
"testing"
|
|
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
|
|
"github.com/grafana/grafana/pkg/models"
|
|
)
|
|
|
|
type Test struct {
|
|
Id int64
|
|
Name string
|
|
}
|
|
|
|
func TestDataAccess(t *testing.T) {
|
|
Convey("Testing DB", t, func() {
|
|
InitTestDB(t)
|
|
Convey("Can add datasource", func() {
|
|
err := AddDataSource(&models.AddDataSourceCommand{
|
|
OrgId: 10,
|
|
Name: "laban",
|
|
Type: models.DS_INFLUXDB,
|
|
Access: models.DS_ACCESS_DIRECT,
|
|
Url: "http://test",
|
|
Database: "site",
|
|
ReadOnly: true,
|
|
})
|
|
|
|
So(err, ShouldBeNil)
|
|
|
|
query := models.GetDataSourcesQuery{OrgId: 10}
|
|
err = GetDataSources(&query)
|
|
So(err, ShouldBeNil)
|
|
|
|
So(len(query.Result), ShouldEqual, 1)
|
|
|
|
ds := query.Result[0]
|
|
|
|
So(ds.OrgId, ShouldEqual, 10)
|
|
So(ds.Database, ShouldEqual, "site")
|
|
So(ds.ReadOnly, ShouldBeTrue)
|
|
})
|
|
|
|
Convey("Given a datasource", func() {
|
|
err := AddDataSource(&models.AddDataSourceCommand{
|
|
OrgId: 10,
|
|
Name: "nisse",
|
|
Type: models.DS_GRAPHITE,
|
|
Access: models.DS_ACCESS_DIRECT,
|
|
Url: "http://test",
|
|
})
|
|
So(err, ShouldBeNil)
|
|
|
|
query := models.GetDataSourcesQuery{OrgId: 10}
|
|
err = GetDataSources(&query)
|
|
So(err, ShouldBeNil)
|
|
|
|
ds := query.Result[0]
|
|
|
|
Convey(" updated ", func() {
|
|
cmd := &models.UpdateDataSourceCommand{
|
|
Id: ds.Id,
|
|
OrgId: 10,
|
|
Name: "nisse",
|
|
Type: models.DS_GRAPHITE,
|
|
Access: models.DS_ACCESS_PROXY,
|
|
Url: "http://test",
|
|
Version: ds.Version,
|
|
}
|
|
|
|
Convey("with same version as source", func() {
|
|
err := UpdateDataSource(cmd)
|
|
So(err, ShouldBeNil)
|
|
})
|
|
|
|
Convey("when someone else updated between read and update", func() {
|
|
query := models.GetDataSourcesQuery{OrgId: 10}
|
|
err = GetDataSources(&query)
|
|
So(err, ShouldBeNil)
|
|
|
|
ds := query.Result[0]
|
|
intendedUpdate := &models.UpdateDataSourceCommand{
|
|
Id: ds.Id,
|
|
OrgId: 10,
|
|
Name: "nisse",
|
|
Type: models.DS_GRAPHITE,
|
|
Access: models.DS_ACCESS_PROXY,
|
|
Url: "http://test",
|
|
Version: ds.Version,
|
|
}
|
|
|
|
updateFromOtherUser := &models.UpdateDataSourceCommand{
|
|
Id: ds.Id,
|
|
OrgId: 10,
|
|
Name: "nisse",
|
|
Type: models.DS_GRAPHITE,
|
|
Access: models.DS_ACCESS_PROXY,
|
|
Url: "http://test",
|
|
Version: ds.Version,
|
|
}
|
|
|
|
err := UpdateDataSource(updateFromOtherUser)
|
|
So(err, ShouldBeNil)
|
|
|
|
err = UpdateDataSource(intendedUpdate)
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
|
|
Convey("updating datasource without version", func() {
|
|
cmd := &models.UpdateDataSourceCommand{
|
|
Id: ds.Id,
|
|
OrgId: 10,
|
|
Name: "nisse",
|
|
Type: models.DS_GRAPHITE,
|
|
Access: models.DS_ACCESS_PROXY,
|
|
Url: "http://test",
|
|
}
|
|
|
|
Convey("should not raise errors", func() {
|
|
err := UpdateDataSource(cmd)
|
|
So(err, ShouldBeNil)
|
|
})
|
|
})
|
|
|
|
Convey("updating datasource without higher version", func() {
|
|
cmd := &models.UpdateDataSourceCommand{
|
|
Id: ds.Id,
|
|
OrgId: 10,
|
|
Name: "nisse",
|
|
Type: models.DS_GRAPHITE,
|
|
Access: models.DS_ACCESS_PROXY,
|
|
Url: "http://test",
|
|
Version: 90000,
|
|
}
|
|
|
|
Convey("should not raise errors", func() {
|
|
err := UpdateDataSource(cmd)
|
|
So(err, ShouldBeNil)
|
|
})
|
|
})
|
|
})
|
|
|
|
Convey("Can delete datasource by id", func() {
|
|
err := DeleteDataSourceById(&models.DeleteDataSourceByIdCommand{Id: ds.Id, OrgId: ds.OrgId})
|
|
So(err, ShouldBeNil)
|
|
|
|
GetDataSources(&query)
|
|
So(len(query.Result), ShouldEqual, 0)
|
|
})
|
|
|
|
Convey("Can delete datasource by name", func() {
|
|
err := DeleteDataSourceByName(&models.DeleteDataSourceByNameCommand{Name: ds.Name, OrgId: ds.OrgId})
|
|
So(err, ShouldBeNil)
|
|
|
|
GetDataSources(&query)
|
|
So(len(query.Result), ShouldEqual, 0)
|
|
})
|
|
|
|
Convey("Can not delete datasource with wrong orgId", func() {
|
|
err := DeleteDataSourceById(&models.DeleteDataSourceByIdCommand{Id: ds.Id, OrgId: 123123})
|
|
So(err, ShouldBeNil)
|
|
|
|
GetDataSources(&query)
|
|
So(len(query.Result), ShouldEqual, 1)
|
|
})
|
|
})
|
|
})
|
|
}
|