mirror of
https://github.com/grafana/grafana.git
synced 2024-11-30 12:44:10 -06:00
900348f3d9
* remove tests for legacy AC, update other tests to work with RBAC * update usage stat tests to use RBAC
181 lines
6.5 KiB
Go
181 lines
6.5 KiB
Go
package api
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/grafana/grafana/pkg/api/routing"
|
|
"github.com/grafana/grafana/pkg/components/simplejson"
|
|
"github.com/grafana/grafana/pkg/services/accesscontrol/actest"
|
|
contextmodel "github.com/grafana/grafana/pkg/services/contexthandler/model"
|
|
"github.com/grafana/grafana/pkg/services/dashboardimport"
|
|
"github.com/grafana/grafana/pkg/services/dashboards"
|
|
"github.com/grafana/grafana/pkg/services/quota"
|
|
"github.com/grafana/grafana/pkg/services/user"
|
|
"github.com/grafana/grafana/pkg/web/webtest"
|
|
)
|
|
|
|
func TestImportDashboardAPI(t *testing.T) {
|
|
t.Run("Quota not reached, schema loader service disabled", func(t *testing.T) {
|
|
importDashboardServiceCalled := false
|
|
service := &serviceMock{
|
|
importDashboardFunc: func(ctx context.Context, req *dashboardimport.ImportDashboardRequest) (*dashboardimport.ImportDashboardResponse, error) {
|
|
importDashboardServiceCalled = true
|
|
return nil, nil
|
|
},
|
|
}
|
|
|
|
importDashboardAPI := New(service, quotaServiceFunc(quotaNotReached), nil, actest.FakeAccessControl{ExpectedEvaluate: true})
|
|
routeRegister := routing.NewRouteRegister()
|
|
importDashboardAPI.RegisterAPIEndpoints(routeRegister)
|
|
s := webtest.NewServer(t, routeRegister)
|
|
|
|
t.Run("Not signed in should return 404", func(t *testing.T) {
|
|
cmd := &dashboardimport.ImportDashboardRequest{}
|
|
jsonBytes, err := json.Marshal(cmd)
|
|
require.NoError(t, err)
|
|
req := s.NewPostRequest("/api/dashboards/import", bytes.NewReader(jsonBytes))
|
|
resp, err := s.SendJSON(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusUnauthorized, resp.StatusCode)
|
|
})
|
|
|
|
t.Run("Signed in, empty plugin id and dashboard model empty should return error", func(t *testing.T) {
|
|
cmd := &dashboardimport.ImportDashboardRequest{
|
|
PluginId: "",
|
|
Dashboard: nil,
|
|
}
|
|
jsonBytes, err := json.Marshal(cmd)
|
|
require.NoError(t, err)
|
|
req := s.NewPostRequest("/api/dashboards/import", bytes.NewReader(jsonBytes))
|
|
webtest.RequestWithSignedInUser(req, &user.SignedInUser{
|
|
UserID: 1,
|
|
})
|
|
resp, err := s.SendJSON(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusUnprocessableEntity, resp.StatusCode)
|
|
})
|
|
|
|
t.Run("Signed in, dashboard model set should call import dashboard service", func(t *testing.T) {
|
|
cmd := &dashboardimport.ImportDashboardRequest{
|
|
Dashboard: simplejson.New(),
|
|
}
|
|
jsonBytes, err := json.Marshal(cmd)
|
|
require.NoError(t, err)
|
|
req := s.NewPostRequest("/api/dashboards/import", bytes.NewReader(jsonBytes))
|
|
webtest.RequestWithSignedInUser(req, &user.SignedInUser{
|
|
UserID: 1,
|
|
})
|
|
resp, err := s.SendJSON(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode)
|
|
require.True(t, importDashboardServiceCalled)
|
|
})
|
|
|
|
t.Run("Signed in, dashboard model set, trimdefaults enabled should not call schema loader service", func(t *testing.T) {
|
|
cmd := &dashboardimport.ImportDashboardRequest{
|
|
Dashboard: simplejson.New(),
|
|
}
|
|
jsonBytes, err := json.Marshal(cmd)
|
|
require.NoError(t, err)
|
|
req := s.NewPostRequest("/api/dashboards/import?trimdefaults=true", bytes.NewReader(jsonBytes))
|
|
webtest.RequestWithSignedInUser(req, &user.SignedInUser{
|
|
UserID: 1,
|
|
})
|
|
resp, err := s.SendJSON(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode)
|
|
require.True(t, importDashboardServiceCalled)
|
|
})
|
|
})
|
|
|
|
t.Run("Quota not reached, schema loader service enabled", func(t *testing.T) {
|
|
importDashboardServiceCalled := false
|
|
service := &serviceMock{
|
|
importDashboardFunc: func(ctx context.Context, req *dashboardimport.ImportDashboardRequest) (*dashboardimport.ImportDashboardResponse, error) {
|
|
importDashboardServiceCalled = true
|
|
return nil, nil
|
|
},
|
|
}
|
|
|
|
importDashboardAPI := New(service, quotaServiceFunc(quotaNotReached), nil, actest.FakeAccessControl{ExpectedEvaluate: true})
|
|
routeRegister := routing.NewRouteRegister()
|
|
importDashboardAPI.RegisterAPIEndpoints(routeRegister)
|
|
s := webtest.NewServer(t, routeRegister)
|
|
|
|
t.Run("Signed in, dashboard model set, trimdefaults enabled should call schema loader service", func(t *testing.T) {
|
|
cmd := &dashboardimport.ImportDashboardRequest{
|
|
Dashboard: simplejson.New(),
|
|
}
|
|
jsonBytes, err := json.Marshal(cmd)
|
|
require.NoError(t, err)
|
|
req := s.NewPostRequest("/api/dashboards/import?trimdefaults=true", bytes.NewReader(jsonBytes))
|
|
webtest.RequestWithSignedInUser(req, &user.SignedInUser{
|
|
UserID: 1,
|
|
Permissions: map[int64]map[string][]string{
|
|
1: {dashboards.ActionDashboardsCreate: {}},
|
|
},
|
|
})
|
|
resp, err := s.SendJSON(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode)
|
|
require.True(t, importDashboardServiceCalled)
|
|
})
|
|
})
|
|
|
|
t.Run("Quota reached", func(t *testing.T) {
|
|
service := &serviceMock{}
|
|
importDashboardAPI := New(service, quotaServiceFunc(quotaReached), nil, actest.FakeAccessControl{ExpectedEvaluate: true})
|
|
|
|
routeRegister := routing.NewRouteRegister()
|
|
importDashboardAPI.RegisterAPIEndpoints(routeRegister)
|
|
s := webtest.NewServer(t, routeRegister)
|
|
|
|
t.Run("Signed in, dashboard model set, should return 403 forbidden/quota reached", func(t *testing.T) {
|
|
cmd := &dashboardimport.ImportDashboardRequest{
|
|
Dashboard: simplejson.New(),
|
|
}
|
|
jsonBytes, err := json.Marshal(cmd)
|
|
require.NoError(t, err)
|
|
req := s.NewPostRequest("/api/dashboards/import", bytes.NewReader(jsonBytes))
|
|
webtest.RequestWithSignedInUser(req, &user.SignedInUser{
|
|
UserID: 1,
|
|
})
|
|
resp, err := s.SendJSON(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusForbidden, resp.StatusCode)
|
|
})
|
|
})
|
|
}
|
|
|
|
type serviceMock struct {
|
|
importDashboardFunc func(ctx context.Context, req *dashboardimport.ImportDashboardRequest) (*dashboardimport.ImportDashboardResponse, error)
|
|
}
|
|
|
|
func (s *serviceMock) ImportDashboard(ctx context.Context, req *dashboardimport.ImportDashboardRequest) (*dashboardimport.ImportDashboardResponse, error) {
|
|
if s.importDashboardFunc != nil {
|
|
return s.importDashboardFunc(ctx, req)
|
|
}
|
|
|
|
return nil, nil
|
|
}
|
|
|
|
func quotaReached(c *contextmodel.ReqContext, target quota.TargetSrv) (bool, error) {
|
|
return true, nil
|
|
}
|
|
|
|
func quotaNotReached(c *contextmodel.ReqContext, target quota.TargetSrv) (bool, error) {
|
|
return false, nil
|
|
}
|