mirror of
https://github.com/grafana/grafana.git
synced 2024-12-02 13:39:19 -06:00
518a0d0458
Require guardian.New to take context.Context as first argument. Migrates the GetDashboardAclInfoListQuery to be dispatched using context. Ref #36734 Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> Co-authored-by: sam boyer <sam.boyer@grafana.com>
323 lines
12 KiB
Go
323 lines
12 KiB
Go
//go:build integration
|
|
// +build integration
|
|
|
|
package sqlstore
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
|
|
"github.com/grafana/grafana/pkg/models"
|
|
)
|
|
|
|
func TestTeamCommandsAndQueries(t *testing.T) {
|
|
Convey("Testing Team commands & queries", t, func() {
|
|
sqlStore := InitTestDB(t)
|
|
|
|
Convey("Given saved users and two teams", func() {
|
|
var userIds []int64
|
|
for i := 0; i < 5; i++ {
|
|
userCmd := models.CreateUserCommand{
|
|
Email: fmt.Sprint("user", i, "@test.com"),
|
|
Name: fmt.Sprint("user", i),
|
|
Login: fmt.Sprint("loginuser", i),
|
|
}
|
|
user, err := sqlStore.CreateUser(context.Background(), userCmd)
|
|
So(err, ShouldBeNil)
|
|
userIds = append(userIds, user.Id)
|
|
}
|
|
|
|
const testOrgID int64 = 1
|
|
team1, err := sqlStore.CreateTeam("group1 name", "test1@test.com", testOrgID)
|
|
So(err, ShouldBeNil)
|
|
team2, err := sqlStore.CreateTeam("group2 name", "test2@test.com", testOrgID)
|
|
So(err, ShouldBeNil)
|
|
|
|
Convey("Should be able to create teams and add users", func() {
|
|
query := &models.SearchTeamsQuery{OrgId: testOrgID, Name: "group1 name", Page: 1, Limit: 10}
|
|
err = SearchTeams(query)
|
|
So(err, ShouldBeNil)
|
|
So(query.Page, ShouldEqual, 1)
|
|
|
|
team1 := query.Result.Teams[0]
|
|
So(team1.Name, ShouldEqual, "group1 name")
|
|
So(team1.Email, ShouldEqual, "test1@test.com")
|
|
So(team1.OrgId, ShouldEqual, testOrgID)
|
|
So(team1.MemberCount, ShouldEqual, 0)
|
|
|
|
err = sqlStore.AddTeamMember(userIds[0], testOrgID, team1.Id, false, 0)
|
|
So(err, ShouldBeNil)
|
|
err = sqlStore.AddTeamMember(userIds[1], testOrgID, team1.Id, true, 0)
|
|
So(err, ShouldBeNil)
|
|
|
|
q1 := &models.GetTeamMembersQuery{OrgId: testOrgID, TeamId: team1.Id}
|
|
err = GetTeamMembers(q1)
|
|
So(err, ShouldBeNil)
|
|
So(q1.Result, ShouldHaveLength, 2)
|
|
So(q1.Result[0].TeamId, ShouldEqual, team1.Id)
|
|
So(q1.Result[0].Login, ShouldEqual, "loginuser0")
|
|
So(q1.Result[0].OrgId, ShouldEqual, testOrgID)
|
|
So(q1.Result[1].TeamId, ShouldEqual, team1.Id)
|
|
So(q1.Result[1].Login, ShouldEqual, "loginuser1")
|
|
So(q1.Result[1].OrgId, ShouldEqual, testOrgID)
|
|
So(q1.Result[1].External, ShouldEqual, true)
|
|
|
|
q2 := &models.GetTeamMembersQuery{OrgId: testOrgID, TeamId: team1.Id, External: true}
|
|
err = GetTeamMembers(q2)
|
|
So(err, ShouldBeNil)
|
|
So(q2.Result, ShouldHaveLength, 1)
|
|
So(q2.Result[0].TeamId, ShouldEqual, team1.Id)
|
|
So(q2.Result[0].Login, ShouldEqual, "loginuser1")
|
|
So(q2.Result[0].OrgId, ShouldEqual, testOrgID)
|
|
So(q2.Result[0].External, ShouldEqual, true)
|
|
|
|
err = SearchTeams(query)
|
|
So(err, ShouldBeNil)
|
|
team1 = query.Result.Teams[0]
|
|
So(team1.MemberCount, ShouldEqual, 2)
|
|
|
|
getTeamQuery := &models.GetTeamByIdQuery{OrgId: testOrgID, Id: team1.Id}
|
|
err = GetTeamById(getTeamQuery)
|
|
So(err, ShouldBeNil)
|
|
team1 = getTeamQuery.Result
|
|
So(team1.Name, ShouldEqual, "group1 name")
|
|
So(team1.Email, ShouldEqual, "test1@test.com")
|
|
So(team1.OrgId, ShouldEqual, testOrgID)
|
|
So(team1.MemberCount, ShouldEqual, 2)
|
|
})
|
|
|
|
Convey("Should return latest auth module for users when getting team members", func() {
|
|
userId := userIds[1]
|
|
|
|
teamQuery := &models.SearchTeamsQuery{OrgId: testOrgID, Name: "group1 name", Page: 1, Limit: 10}
|
|
err = SearchTeams(teamQuery)
|
|
So(err, ShouldBeNil)
|
|
So(teamQuery.Page, ShouldEqual, 1)
|
|
|
|
team1 := teamQuery.Result.Teams[0]
|
|
|
|
err = sqlStore.AddTeamMember(userId, testOrgID, team1.Id, true, 0)
|
|
So(err, ShouldBeNil)
|
|
|
|
memberQuery := &models.GetTeamMembersQuery{OrgId: testOrgID, TeamId: team1.Id, External: true}
|
|
err = GetTeamMembers(memberQuery)
|
|
So(err, ShouldBeNil)
|
|
So(memberQuery.Result, ShouldHaveLength, 1)
|
|
So(memberQuery.Result[0].TeamId, ShouldEqual, team1.Id)
|
|
So(memberQuery.Result[0].Login, ShouldEqual, "loginuser1")
|
|
So(memberQuery.Result[0].OrgId, ShouldEqual, testOrgID)
|
|
So(memberQuery.Result[0].External, ShouldEqual, true)
|
|
})
|
|
|
|
Convey("Should be able to update users in a team", func() {
|
|
userId := userIds[0]
|
|
team := team1
|
|
err = sqlStore.AddTeamMember(userId, testOrgID, team.Id, false, 0)
|
|
So(err, ShouldBeNil)
|
|
|
|
qBeforeUpdate := &models.GetTeamMembersQuery{OrgId: testOrgID, TeamId: team.Id}
|
|
err = GetTeamMembers(qBeforeUpdate)
|
|
So(err, ShouldBeNil)
|
|
So(qBeforeUpdate.Result[0].Permission, ShouldEqual, 0)
|
|
|
|
err = UpdateTeamMember(&models.UpdateTeamMemberCommand{
|
|
UserId: userId,
|
|
OrgId: testOrgID,
|
|
TeamId: team.Id,
|
|
Permission: models.PERMISSION_ADMIN,
|
|
})
|
|
|
|
So(err, ShouldBeNil)
|
|
|
|
qAfterUpdate := &models.GetTeamMembersQuery{OrgId: testOrgID, TeamId: team.Id}
|
|
err = GetTeamMembers(qAfterUpdate)
|
|
So(err, ShouldBeNil)
|
|
So(qAfterUpdate.Result[0].Permission, ShouldEqual, models.PERMISSION_ADMIN)
|
|
})
|
|
|
|
Convey("Should default to member permission level when updating a user with invalid permission level", func() {
|
|
userID := userIds[0]
|
|
team := team1
|
|
err = sqlStore.AddTeamMember(userID, testOrgID, team.Id, false, 0)
|
|
So(err, ShouldBeNil)
|
|
|
|
qBeforeUpdate := &models.GetTeamMembersQuery{OrgId: testOrgID, TeamId: team.Id}
|
|
err = GetTeamMembers(qBeforeUpdate)
|
|
So(err, ShouldBeNil)
|
|
So(qBeforeUpdate.Result[0].Permission, ShouldEqual, 0)
|
|
|
|
invalidPermissionLevel := models.PERMISSION_EDIT
|
|
err = UpdateTeamMember(&models.UpdateTeamMemberCommand{
|
|
UserId: userID,
|
|
OrgId: testOrgID,
|
|
TeamId: team.Id,
|
|
Permission: invalidPermissionLevel,
|
|
})
|
|
|
|
So(err, ShouldBeNil)
|
|
|
|
qAfterUpdate := &models.GetTeamMembersQuery{OrgId: testOrgID, TeamId: team.Id}
|
|
err = GetTeamMembers(qAfterUpdate)
|
|
So(err, ShouldBeNil)
|
|
So(qAfterUpdate.Result[0].Permission, ShouldEqual, 0)
|
|
})
|
|
|
|
Convey("Shouldn't be able to update a user not in the team.", func() {
|
|
err = UpdateTeamMember(&models.UpdateTeamMemberCommand{
|
|
UserId: 1,
|
|
OrgId: testOrgID,
|
|
TeamId: team1.Id,
|
|
Permission: models.PERMISSION_ADMIN,
|
|
})
|
|
|
|
So(err, ShouldEqual, models.ErrTeamMemberNotFound)
|
|
})
|
|
|
|
Convey("Should be able to search for teams", func() {
|
|
query := &models.SearchTeamsQuery{OrgId: testOrgID, Query: "group", Page: 1}
|
|
err = SearchTeams(query)
|
|
So(err, ShouldBeNil)
|
|
So(len(query.Result.Teams), ShouldEqual, 2)
|
|
So(query.Result.TotalCount, ShouldEqual, 2)
|
|
|
|
query2 := &models.SearchTeamsQuery{OrgId: testOrgID, Query: ""}
|
|
err = SearchTeams(query2)
|
|
So(err, ShouldBeNil)
|
|
So(len(query2.Result.Teams), ShouldEqual, 2)
|
|
})
|
|
|
|
Convey("Should be able to return all teams a user is member of", func() {
|
|
groupId := team2.Id
|
|
err := sqlStore.AddTeamMember(userIds[0], testOrgID, groupId, false, 0)
|
|
So(err, ShouldBeNil)
|
|
|
|
query := &models.GetTeamsByUserQuery{OrgId: testOrgID, UserId: userIds[0]}
|
|
err = GetTeamsByUser(query)
|
|
So(err, ShouldBeNil)
|
|
So(len(query.Result), ShouldEqual, 1)
|
|
So(query.Result[0].Name, ShouldEqual, "group2 name")
|
|
So(query.Result[0].Email, ShouldEqual, "test2@test.com")
|
|
})
|
|
|
|
Convey("Should be able to remove users from a group", func() {
|
|
err = sqlStore.AddTeamMember(userIds[0], testOrgID, team1.Id, false, 0)
|
|
So(err, ShouldBeNil)
|
|
|
|
err = RemoveTeamMember(&models.RemoveTeamMemberCommand{OrgId: testOrgID, TeamId: team1.Id, UserId: userIds[0]})
|
|
So(err, ShouldBeNil)
|
|
|
|
q2 := &models.GetTeamMembersQuery{OrgId: testOrgID, TeamId: team1.Id}
|
|
err = GetTeamMembers(q2)
|
|
So(err, ShouldBeNil)
|
|
So(len(q2.Result), ShouldEqual, 0)
|
|
})
|
|
|
|
Convey("When ProtectLastAdmin is set to true", func() {
|
|
err = sqlStore.AddTeamMember(userIds[0], testOrgID, team1.Id, false, models.PERMISSION_ADMIN)
|
|
So(err, ShouldBeNil)
|
|
|
|
Convey("A user should not be able to remove the last admin", func() {
|
|
err = RemoveTeamMember(&models.RemoveTeamMemberCommand{OrgId: testOrgID, TeamId: team1.Id, UserId: userIds[0], ProtectLastAdmin: true})
|
|
So(err, ShouldEqual, models.ErrLastTeamAdmin)
|
|
})
|
|
|
|
Convey("A user should be able to remove an admin if there are other admins", func() {
|
|
err = sqlStore.AddTeamMember(userIds[1], testOrgID, team1.Id, false, models.PERMISSION_ADMIN)
|
|
So(err, ShouldBeNil)
|
|
err = RemoveTeamMember(&models.RemoveTeamMemberCommand{OrgId: testOrgID, TeamId: team1.Id, UserId: userIds[0], ProtectLastAdmin: true})
|
|
So(err, ShouldBeNil)
|
|
})
|
|
|
|
Convey("A user should not be able to remove the admin permission for the last admin", func() {
|
|
err = UpdateTeamMember(&models.UpdateTeamMemberCommand{OrgId: testOrgID, TeamId: team1.Id, UserId: userIds[0], Permission: 0, ProtectLastAdmin: true})
|
|
So(err, ShouldBeError, models.ErrLastTeamAdmin)
|
|
})
|
|
|
|
Convey("A user should be able to remove the admin permission if there are other admins", func() {
|
|
err = sqlStore.AddTeamMember(userIds[1], testOrgID, team1.Id, false, models.PERMISSION_ADMIN)
|
|
So(err, ShouldBeNil)
|
|
err = UpdateTeamMember(&models.UpdateTeamMemberCommand{OrgId: testOrgID, TeamId: team1.Id, UserId: userIds[0], Permission: 0, ProtectLastAdmin: true})
|
|
So(err, ShouldBeNil)
|
|
})
|
|
})
|
|
|
|
Convey("Should be able to remove a group with users and permissions", func() {
|
|
groupId := team2.Id
|
|
err := sqlStore.AddTeamMember(userIds[1], testOrgID, groupId, false, 0)
|
|
So(err, ShouldBeNil)
|
|
err = sqlStore.AddTeamMember(userIds[2], testOrgID, groupId, false, 0)
|
|
So(err, ShouldBeNil)
|
|
err = testHelperUpdateDashboardAcl(t, sqlStore, 1, models.DashboardAcl{
|
|
DashboardID: 1, OrgID: testOrgID, Permission: models.PERMISSION_EDIT, TeamID: groupId,
|
|
})
|
|
So(err, ShouldBeNil)
|
|
err = DeleteTeam(&models.DeleteTeamCommand{OrgId: testOrgID, Id: groupId})
|
|
So(err, ShouldBeNil)
|
|
|
|
query := &models.GetTeamByIdQuery{OrgId: testOrgID, Id: groupId}
|
|
err = GetTeamById(query)
|
|
So(err, ShouldEqual, models.ErrTeamNotFound)
|
|
|
|
permQuery := &models.GetDashboardAclInfoListQuery{DashboardID: 1, OrgID: testOrgID}
|
|
err = sqlStore.GetDashboardAclInfoList(context.Background(), permQuery)
|
|
So(err, ShouldBeNil)
|
|
|
|
So(len(permQuery.Result), ShouldEqual, 0)
|
|
})
|
|
|
|
Convey("Should be able to return if user is admin of teams or not", func() {
|
|
groupId := team2.Id
|
|
err := sqlStore.AddTeamMember(userIds[0], testOrgID, groupId, false, 0)
|
|
So(err, ShouldBeNil)
|
|
err = sqlStore.AddTeamMember(userIds[1], testOrgID, groupId, false, models.PERMISSION_ADMIN)
|
|
So(err, ShouldBeNil)
|
|
|
|
query := &models.IsAdminOfTeamsQuery{SignedInUser: &models.SignedInUser{OrgId: testOrgID, UserId: userIds[0]}}
|
|
err = IsAdminOfTeams(query)
|
|
So(err, ShouldBeNil)
|
|
So(query.Result, ShouldBeFalse)
|
|
|
|
query = &models.IsAdminOfTeamsQuery{SignedInUser: &models.SignedInUser{OrgId: testOrgID, UserId: userIds[1]}}
|
|
err = IsAdminOfTeams(query)
|
|
So(err, ShouldBeNil)
|
|
So(query.Result, ShouldBeTrue)
|
|
})
|
|
|
|
Convey("Should not return hidden users in team member count", func() {
|
|
signedInUser := &models.SignedInUser{Login: "loginuser0"}
|
|
hiddenUsers := map[string]struct{}{"loginuser0": {}, "loginuser1": {}}
|
|
|
|
teamId := team1.Id
|
|
err = sqlStore.AddTeamMember(userIds[0], testOrgID, teamId, false, 0)
|
|
So(err, ShouldBeNil)
|
|
err = sqlStore.AddTeamMember(userIds[1], testOrgID, teamId, false, 0)
|
|
So(err, ShouldBeNil)
|
|
err = sqlStore.AddTeamMember(userIds[2], testOrgID, teamId, false, 0)
|
|
So(err, ShouldBeNil)
|
|
|
|
searchQuery := &models.SearchTeamsQuery{OrgId: testOrgID, Page: 1, Limit: 10, SignedInUser: signedInUser, HiddenUsers: hiddenUsers}
|
|
err = SearchTeams(searchQuery)
|
|
So(err, ShouldBeNil)
|
|
So(searchQuery.Result.Teams, ShouldHaveLength, 2)
|
|
team1 := searchQuery.Result.Teams[0]
|
|
So(team1.MemberCount, ShouldEqual, 2)
|
|
|
|
searchQueryFilteredByUser := &models.SearchTeamsQuery{OrgId: testOrgID, Page: 1, Limit: 10, UserIdFilter: userIds[0], SignedInUser: signedInUser, HiddenUsers: hiddenUsers}
|
|
err = SearchTeams(searchQueryFilteredByUser)
|
|
So(err, ShouldBeNil)
|
|
So(searchQueryFilteredByUser.Result.Teams, ShouldHaveLength, 1)
|
|
team1 = searchQuery.Result.Teams[0]
|
|
So(team1.MemberCount, ShouldEqual, 2)
|
|
|
|
getTeamQuery := &models.GetTeamByIdQuery{OrgId: testOrgID, Id: teamId, SignedInUser: signedInUser, HiddenUsers: hiddenUsers}
|
|
err = GetTeamById(getTeamQuery)
|
|
So(err, ShouldBeNil)
|
|
So(getTeamQuery.Result.MemberCount, ShouldEqual, 2)
|
|
})
|
|
})
|
|
})
|
|
}
|