mirror of
https://github.com/grafana/grafana.git
synced 2025-02-20 11:48:34 -06:00
* Moving POC files from #64283 to a new branch
Co-authored-by: Mihály Gyöngyösi <mgyongyosi@users.noreply.github.com>
* Adding missing permission definition
Co-authored-by: Mihály Gyöngyösi <mgyongyosi@users.noreply.github.com>
* Force the service instantiation while client isn't merged
Co-authored-by: Mihály Gyöngyösi <mgyongyosi@users.noreply.github.com>
* Merge conf with main
Co-authored-by: Mihály Gyöngyösi <mgyongyosi@users.noreply.github.com>
* Leave go-sqlite3 version unchanged
Co-authored-by: Mihály Gyöngyösi <mgyongyosi@users.noreply.github.com>
* tidy
Co-authored-by: Mihály Gyöngyösi <mgyongyosi@users.noreply.github.com>
* User SearchUserPermissions instead of SearchUsersPermissions
* Replace DummyKeyService with signingkeys.Service
* Use user🆔<id> as subject
* Fix introspection endpoint issue
* Add X-Grafana-Org-Id to get_resources.bash script
* Regenerate toggles_gen.go
* Fix basic.go
* Add GetExternalService tests
* Add GetPublicKeyScopes tests
* Add GetScopesOnUser tests
* Add GetScopes tests
* Add ParsePublicKeyPem tests
* Add database test for GetByName
* re-add comments
* client tests added
* Add GetExternalServicePublicKey tests
* Add other test case to GetExternalServicePublicKey
* client_credentials grant test
* Add test to jwtbearer grant
* Test Comments
* Add handleKeyOptions tests
* Add RSA key generation test
* Add ECDSA by default to EmbeddedSigningKeysService
* Clean up org id scope and audiences
* Add audiences to the DB
* Fix check on Audience
* Fix double import
* Add AC Store mock and align oauthserver tests
* Fix test after rebase
* Adding missing store function to mock
* Fix double import
* Add CODEOWNER
* Fix some linting errors
* errors don't need type assertion
* Typo codeowners
* use mockery for oauthserver store
* Add feature toggle check
* Fix db tests to handle the feature flag
* Adding call to DeleteExternalServiceRole
* Fix flaky test
* Re-organize routes comments and plan futur work
* Add client_id check to Extended JWT client
* Clean up
* Fix
* Remove background service registry instantiation of the OAuth server
* Comment cleanup
* Remove unused client function
* Update go.mod to use the latest ory/fosite commit
* Remove oauth2_server related configs from defaults.ini
* Add audiences to DTO
* Fix flaky test
* Remove registration endpoint and demo scripts. Document code
* Rename packages
* Remove the OAuthService vs OAuthServer confusion
* fix incorrect import ext_jwt_test
* Comments and order
* Comment basic auth
* Remove unecessary todo
* Clean api
* Moving ParsePublicKeyPem to utils
* re ordering functions in service.go
* Fix comment
* comment on the redirect uri
* Add RBAC actions, not only scopes
* Fix tests
* re-import featuremgmt in migrations
* Fix wire
* Fix scopes in test
* Fix flaky test
* Remove todo, the intersection should always return the minimal set
* Remove unecessary check from intersection code
* Allow env overrides on settings
* remove the term app name
* Remove app keyword for client instead and use Name instead of ExternalServiceName
* LogID remove ExternalService ref
* Use Name instead of ExternalServiceName
* Imports order
* Inline
* Using ExternalService and ExternalServiceDTO
* Remove xorm tags
* comment
* Rename client files
* client -> external service
* comments
* Move test to correct package
* slimmer test
* cachedUser -> cachedExternalService
* Fix aggregate store test
* PluginAuthSession -> AuthSession
* Revert the nil cehcks
* Remove unecessary extra
* Removing custom session
* fix typo in test
* Use constants for tests
* Simplify HandleToken tests
* Refactor the HandleTokenRequest test
* test message
* Review test
* Prevent flacky test on client as well
* go imports
* Revert changes from 526e48ad45
* AuthN: Change the External Service registration form (#68649)
* AuthN: change the External Service registration form
* Gen default permissions
* Change demo script registration form
* Remove unecessary comment
* Nit.
* Reduce cyclomatic complexity
* Remove demo_scripts
* Handle case with no service account
* Comments
* Group key gen
* Nit.
* Check the SaveExternalService test
* Rename cachedUser to cachedClient in test
* One more test case to database test
* Comments
* Remove last org scope
Co-authored-by: Mihály Gyöngyösi <mgyongyosi@users.noreply.github.com>
* Update pkg/services/oauthserver/utils/utils_test.go
* Update pkg/services/sqlstore/migrations/oauthserver/migrations.go
Remove comment
* Update pkg/setting/setting.go
Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
---------
Co-authored-by: Mihály Gyöngyösi <mgyongyosi@users.noreply.github.com>
448 lines
14 KiB
Go
448 lines
14 KiB
Go
package acimpl
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
|
|
"github.com/grafana/grafana/pkg/api/routing"
|
|
"github.com/grafana/grafana/pkg/infra/db"
|
|
"github.com/grafana/grafana/pkg/infra/localcache"
|
|
"github.com/grafana/grafana/pkg/infra/log"
|
|
"github.com/grafana/grafana/pkg/infra/metrics"
|
|
"github.com/grafana/grafana/pkg/infra/slugify"
|
|
"github.com/grafana/grafana/pkg/plugins"
|
|
"github.com/grafana/grafana/pkg/services/accesscontrol"
|
|
"github.com/grafana/grafana/pkg/services/accesscontrol/api"
|
|
"github.com/grafana/grafana/pkg/services/accesscontrol/database"
|
|
"github.com/grafana/grafana/pkg/services/accesscontrol/pluginutils"
|
|
"github.com/grafana/grafana/pkg/services/featuremgmt"
|
|
"github.com/grafana/grafana/pkg/services/user"
|
|
"github.com/grafana/grafana/pkg/setting"
|
|
)
|
|
|
|
var _ plugins.RoleRegistry = &Service{}
|
|
|
|
const (
|
|
cacheTTL = 10 * time.Second
|
|
)
|
|
|
|
func ProvideService(cfg *setting.Cfg, store db.DB, routeRegister routing.RouteRegister, cache *localcache.CacheService,
|
|
accessControl accesscontrol.AccessControl, features *featuremgmt.FeatureManager) (*Service, error) {
|
|
service := ProvideOSSService(cfg, database.ProvideService(store), cache, features)
|
|
|
|
if !accesscontrol.IsDisabled(cfg) {
|
|
api.NewAccessControlAPI(routeRegister, accessControl, service, features).RegisterAPIEndpoints()
|
|
if err := accesscontrol.DeclareFixedRoles(service, cfg); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
return service, nil
|
|
}
|
|
|
|
func ProvideOSSService(cfg *setting.Cfg, store store, cache *localcache.CacheService, features *featuremgmt.FeatureManager) *Service {
|
|
s := &Service{
|
|
cfg: cfg,
|
|
store: store,
|
|
log: log.New("accesscontrol.service"),
|
|
cache: cache,
|
|
roles: accesscontrol.BuildBasicRoleDefinitions(),
|
|
features: features,
|
|
}
|
|
|
|
return s
|
|
}
|
|
|
|
//go:generate mockery --name store --structname MockStore --outpkg actest --filename store_mock.go --output ../actest/
|
|
type store interface {
|
|
GetUserPermissions(ctx context.Context, query accesscontrol.GetUserPermissionsQuery) ([]accesscontrol.Permission, error)
|
|
SearchUsersPermissions(ctx context.Context, orgID int64, options accesscontrol.SearchOptions) (map[int64][]accesscontrol.Permission, error)
|
|
GetUsersBasicRoles(ctx context.Context, userFilter []int64, orgID int64) (map[int64][]string, error)
|
|
DeleteUserPermissions(ctx context.Context, orgID, userID int64) error
|
|
SaveExternalServiceRole(ctx context.Context, cmd accesscontrol.SaveExternalServiceRoleCommand) error
|
|
DeleteExternalServiceRole(ctx context.Context, externalServiceID string) error
|
|
}
|
|
|
|
// Service is the service implementing role based access control.
|
|
type Service struct {
|
|
log log.Logger
|
|
cfg *setting.Cfg
|
|
store store
|
|
cache *localcache.CacheService
|
|
registrations accesscontrol.RegistrationList
|
|
roles map[string]*accesscontrol.RoleDTO
|
|
features *featuremgmt.FeatureManager
|
|
}
|
|
|
|
func (s *Service) GetUsageStats(_ context.Context) map[string]interface{} {
|
|
enabled := 0
|
|
if !accesscontrol.IsDisabled(s.cfg) {
|
|
enabled = 1
|
|
}
|
|
|
|
return map[string]interface{}{
|
|
"stats.oss.accesscontrol.enabled.count": enabled,
|
|
}
|
|
}
|
|
|
|
// GetUserPermissions returns user permissions based on built-in roles
|
|
func (s *Service) GetUserPermissions(ctx context.Context, user *user.SignedInUser, options accesscontrol.Options) ([]accesscontrol.Permission, error) {
|
|
timer := prometheus.NewTimer(metrics.MAccessPermissionsSummary)
|
|
defer timer.ObserveDuration()
|
|
|
|
if !s.cfg.RBACPermissionCache || !user.HasUniqueId() {
|
|
return s.getUserPermissions(ctx, user, options)
|
|
}
|
|
|
|
return s.getCachedUserPermissions(ctx, user, options)
|
|
}
|
|
|
|
func (s *Service) getUserPermissions(ctx context.Context, user *user.SignedInUser, options accesscontrol.Options) ([]accesscontrol.Permission, error) {
|
|
permissions := make([]accesscontrol.Permission, 0)
|
|
for _, builtin := range accesscontrol.GetOrgRoles(user) {
|
|
if basicRole, ok := s.roles[builtin]; ok {
|
|
permissions = append(permissions, basicRole.Permissions...)
|
|
}
|
|
}
|
|
|
|
dbPermissions, err := s.store.GetUserPermissions(ctx, accesscontrol.GetUserPermissionsQuery{
|
|
OrgID: user.OrgID,
|
|
UserID: user.UserID,
|
|
Roles: accesscontrol.GetOrgRoles(user),
|
|
TeamIDs: user.Teams,
|
|
RolePrefixes: []string{accesscontrol.ManagedRolePrefix, accesscontrol.ExternalServiceRolePrefix},
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return append(permissions, dbPermissions...), nil
|
|
}
|
|
|
|
func (s *Service) getCachedUserPermissions(ctx context.Context, user *user.SignedInUser, options accesscontrol.Options) ([]accesscontrol.Permission, error) {
|
|
key, err := permissionCacheKey(user)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if !options.ReloadCache {
|
|
permissions, ok := s.cache.Get(key)
|
|
if ok {
|
|
s.log.Debug("using cached permissions", "key", key)
|
|
return permissions.([]accesscontrol.Permission), nil
|
|
}
|
|
}
|
|
|
|
s.log.Debug("fetch permissions from store", "key", key)
|
|
permissions, err := s.getUserPermissions(ctx, user, options)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
s.log.Debug("cache permissions", "key", key)
|
|
s.cache.Set(key, permissions, cacheTTL)
|
|
|
|
return permissions, nil
|
|
}
|
|
|
|
func (s *Service) ClearUserPermissionCache(user *user.SignedInUser) {
|
|
key, err := permissionCacheKey(user)
|
|
if err != nil {
|
|
return
|
|
}
|
|
s.cache.Delete(key)
|
|
}
|
|
|
|
func (s *Service) DeleteUserPermissions(ctx context.Context, orgID int64, userID int64) error {
|
|
return s.store.DeleteUserPermissions(ctx, orgID, userID)
|
|
}
|
|
|
|
// DeclareFixedRoles allow the caller to declare, to the service, fixed roles and their assignments
|
|
// to organization roles ("Viewer", "Editor", "Admin") or "Grafana Admin"
|
|
func (s *Service) DeclareFixedRoles(registrations ...accesscontrol.RoleRegistration) error {
|
|
// If accesscontrol is disabled no need to register roles
|
|
if accesscontrol.IsDisabled(s.cfg) {
|
|
return nil
|
|
}
|
|
|
|
for _, r := range registrations {
|
|
err := accesscontrol.ValidateFixedRole(r.Role)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
err = accesscontrol.ValidateBuiltInRoles(r.Grants)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
s.registrations.Append(r)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// RegisterFixedRoles registers all declared roles in RAM
|
|
func (s *Service) RegisterFixedRoles(ctx context.Context) error {
|
|
// If accesscontrol is disabled no need to register roles
|
|
if accesscontrol.IsDisabled(s.cfg) {
|
|
return nil
|
|
}
|
|
s.registrations.Range(func(registration accesscontrol.RoleRegistration) bool {
|
|
for br := range accesscontrol.BuiltInRolesWithParents(registration.Grants) {
|
|
if basicRole, ok := s.roles[br]; ok {
|
|
basicRole.Permissions = append(basicRole.Permissions, registration.Role.Permissions...)
|
|
} else {
|
|
s.log.Error("Unknown builtin role", "builtInRole", br)
|
|
}
|
|
}
|
|
return true
|
|
})
|
|
return nil
|
|
}
|
|
|
|
func (s *Service) IsDisabled() bool {
|
|
return accesscontrol.IsDisabled(s.cfg)
|
|
}
|
|
|
|
func permissionCacheKey(user *user.SignedInUser) (string, error) {
|
|
key, err := user.GetCacheKey()
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
return fmt.Sprintf("rbac-permissions-%s", key), nil
|
|
}
|
|
|
|
// DeclarePluginRoles allow the caller to declare, to the service, plugin roles and their assignments
|
|
// to organization roles ("Viewer", "Editor", "Admin") or "Grafana Admin"
|
|
func (s *Service) DeclarePluginRoles(_ context.Context, ID, name string, regs []plugins.RoleRegistration) error {
|
|
// If accesscontrol is disabled no need to register roles
|
|
if accesscontrol.IsDisabled(s.cfg) {
|
|
return nil
|
|
}
|
|
|
|
// Protect behind feature toggle
|
|
if !s.features.IsEnabled(featuremgmt.FlagAccessControlOnCall) {
|
|
return nil
|
|
}
|
|
|
|
acRegs := pluginutils.ToRegistrations(ID, name, regs)
|
|
for _, r := range acRegs {
|
|
if err := pluginutils.ValidatePluginRole(ID, r.Role); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := accesscontrol.ValidateBuiltInRoles(r.Grants); err != nil {
|
|
return err
|
|
}
|
|
|
|
s.log.Debug("Registering plugin role", "role", r.Role.Name)
|
|
s.registrations.Append(r)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// SearchUsersPermissions returns all users' permissions filtered by action prefixes
|
|
func (s *Service) SearchUsersPermissions(ctx context.Context, user *user.SignedInUser, orgID int64,
|
|
options accesscontrol.SearchOptions) (map[int64][]accesscontrol.Permission, error) {
|
|
// Filter ram permissions
|
|
basicPermissions := map[string][]accesscontrol.Permission{}
|
|
for role, basicRole := range s.roles {
|
|
for i := range basicRole.Permissions {
|
|
if PermissionMatchesSearchOptions(basicRole.Permissions[i], options) {
|
|
basicPermissions[role] = append(basicPermissions[role], basicRole.Permissions[i])
|
|
}
|
|
}
|
|
}
|
|
|
|
usersRoles, err := s.store.GetUsersBasicRoles(ctx, nil, orgID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Get managed permissions (DB)
|
|
usersPermissions, err := s.store.SearchUsersPermissions(ctx, orgID, options)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// helper to filter out permissions the signed in users cannot see
|
|
canView := func() func(userID int64) bool {
|
|
siuPermissions, ok := user.Permissions[orgID]
|
|
if !ok {
|
|
return func(_ int64) bool { return false }
|
|
}
|
|
scopes, ok := siuPermissions[accesscontrol.ActionUsersPermissionsRead]
|
|
if !ok {
|
|
return func(_ int64) bool { return false }
|
|
}
|
|
|
|
ids := map[int64]bool{}
|
|
for i := range scopes {
|
|
if strings.HasSuffix(scopes[i], "*") {
|
|
return func(_ int64) bool { return true }
|
|
}
|
|
parts := strings.Split(scopes[i], ":")
|
|
if len(parts) != 3 {
|
|
continue
|
|
}
|
|
id, err := strconv.ParseInt(parts[2], 10, 64)
|
|
if err != nil {
|
|
continue
|
|
}
|
|
ids[id] = true
|
|
}
|
|
|
|
return func(userID int64) bool { return ids[userID] }
|
|
}()
|
|
|
|
// Merge stored (DB) and basic role permissions (RAM)
|
|
// Assumes that all users with stored permissions have org roles
|
|
res := map[int64][]accesscontrol.Permission{}
|
|
for userID, roles := range usersRoles {
|
|
if !canView(userID) {
|
|
continue
|
|
}
|
|
perms := []accesscontrol.Permission{}
|
|
for i := range roles {
|
|
basicPermission, ok := basicPermissions[roles[i]]
|
|
if !ok {
|
|
continue
|
|
}
|
|
perms = append(perms, basicPermission...)
|
|
}
|
|
if dbPerms, ok := usersPermissions[userID]; ok {
|
|
perms = append(perms, dbPerms...)
|
|
}
|
|
if len(perms) > 0 {
|
|
res[userID] = perms
|
|
}
|
|
}
|
|
|
|
return res, nil
|
|
}
|
|
|
|
func (s *Service) SearchUserPermissions(ctx context.Context, orgID int64, searchOptions accesscontrol.SearchOptions) ([]accesscontrol.Permission, error) {
|
|
timer := prometheus.NewTimer(metrics.MAccessPermissionsSummary)
|
|
defer timer.ObserveDuration()
|
|
|
|
if searchOptions.UserID == 0 {
|
|
return nil, fmt.Errorf("expected user ID to be specified")
|
|
}
|
|
|
|
if permissions, success := s.searchUserPermissionsFromCache(orgID, searchOptions); success {
|
|
return permissions, nil
|
|
}
|
|
return s.searchUserPermissions(ctx, orgID, searchOptions)
|
|
}
|
|
|
|
func (s *Service) searchUserPermissions(ctx context.Context, orgID int64, searchOptions accesscontrol.SearchOptions) ([]accesscontrol.Permission, error) {
|
|
// Get permissions for user's basic roles from RAM
|
|
roleList, err := s.store.GetUsersBasicRoles(ctx, []int64{searchOptions.UserID}, orgID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("could not fetch basic roles for the user: %w", err)
|
|
}
|
|
var roles []string
|
|
var ok bool
|
|
if roles, ok = roleList[searchOptions.UserID]; !ok {
|
|
return nil, fmt.Errorf("found no basic roles for user %d in organisation %d", searchOptions.UserID, orgID)
|
|
}
|
|
permissions := make([]accesscontrol.Permission, 0)
|
|
for _, builtin := range roles {
|
|
if basicRole, ok := s.roles[builtin]; ok {
|
|
for _, permission := range basicRole.Permissions {
|
|
if PermissionMatchesSearchOptions(permission, searchOptions) {
|
|
permissions = append(permissions, permission)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// Get permissions from the DB
|
|
dbPermissions, err := s.store.SearchUsersPermissions(ctx, orgID, searchOptions)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
permissions = append(permissions, dbPermissions[searchOptions.UserID]...)
|
|
|
|
return permissions, nil
|
|
}
|
|
|
|
func (s *Service) searchUserPermissionsFromCache(orgID int64, searchOptions accesscontrol.SearchOptions) ([]accesscontrol.Permission, bool) {
|
|
// Create a temp signed in user object to retrieve cache key
|
|
tempUser := &user.SignedInUser{
|
|
UserID: searchOptions.UserID,
|
|
OrgID: orgID,
|
|
}
|
|
key, err := permissionCacheKey(tempUser)
|
|
if err != nil {
|
|
s.log.Debug("could not obtain cache key to search user permissions", "error", err.Error())
|
|
return nil, false
|
|
}
|
|
|
|
permissions, ok := s.cache.Get(key)
|
|
if !ok {
|
|
return nil, false
|
|
}
|
|
|
|
s.log.Debug("using cached permissions", "key", key)
|
|
filteredPermissions := make([]accesscontrol.Permission, 0)
|
|
for _, permission := range permissions.([]accesscontrol.Permission) {
|
|
if PermissionMatchesSearchOptions(permission, searchOptions) {
|
|
filteredPermissions = append(filteredPermissions, permission)
|
|
}
|
|
}
|
|
|
|
return filteredPermissions, true
|
|
}
|
|
|
|
func PermissionMatchesSearchOptions(permission accesscontrol.Permission, searchOptions accesscontrol.SearchOptions) bool {
|
|
if searchOptions.Scope != "" && permission.Scope != searchOptions.Scope {
|
|
return false
|
|
}
|
|
if searchOptions.Action != "" {
|
|
return permission.Action == searchOptions.Action
|
|
}
|
|
return strings.HasPrefix(permission.Action, searchOptions.ActionPrefix)
|
|
}
|
|
|
|
func (s *Service) SaveExternalServiceRole(ctx context.Context, cmd accesscontrol.SaveExternalServiceRoleCommand) error {
|
|
// If accesscontrol is disabled no need to save the external service role
|
|
if accesscontrol.IsDisabled(s.cfg) {
|
|
return nil
|
|
}
|
|
|
|
if !s.features.IsEnabled(featuremgmt.FlagExternalServiceAuth) {
|
|
s.log.Debug("registering an external service role is behind a feature flag, enable it to use this feature.")
|
|
return nil
|
|
}
|
|
|
|
if err := cmd.Validate(); err != nil {
|
|
return err
|
|
}
|
|
|
|
return s.store.SaveExternalServiceRole(ctx, cmd)
|
|
}
|
|
|
|
func (s *Service) DeleteExternalServiceRole(ctx context.Context, externalServiceID string) error {
|
|
// If accesscontrol is disabled no need to delete the external service role
|
|
if accesscontrol.IsDisabled(s.cfg) {
|
|
return nil
|
|
}
|
|
|
|
if !s.features.IsEnabled(featuremgmt.FlagExternalServiceAuth) {
|
|
s.log.Debug("deleting an external service role is behind a feature flag, enable it to use this feature.")
|
|
return nil
|
|
}
|
|
|
|
slug := slugify.Slugify(externalServiceID)
|
|
|
|
return s.store.DeleteExternalServiceRole(ctx, slug)
|
|
}
|