mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
69d9f427e1
* WIP: intial structure * Refactor: adds create library element endpoint * Feature: adds delete library element * wip * Refactor: adds get api * Refactor: adds get all api * Refactor: adds patch api * Refactor: changes to library_element_connection * Refactor: add get connections api * wip: in the middle of refactor * wip * Refactor: consolidating both api:s * Refactor: points front end to library elements api * Tests: Fixes broken test * LibraryPanels: removes feature toggle * Fix: fixes delete library elements in folder and adds tests * Tests: fixes snapshot * Refactor: adds service interfaces so they can be easily mocked * Refactor: changes order of tabs in manage folder * Refactor: fixes so link does not cover whole card * Refactor: fixes index string name * Update pkg/services/libraryelements/libraryelements.go Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Update pkg/services/libraryelements/libraryelements_permissions_test.go Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Update pkg/services/libraryelements/database.go Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Chore: changes after PR comments * Update libraryelements.go * Update libraryelements.go * Chore: updates after PR comments * Chore: trying to fix build error * Refactor: fixed stupid mistake * Update libraryelements.go * Chore: tries to fix build errors * Refactor: trying to fix MySQL key length * Update libraryelements.go * Update pkg/services/libraryelements/libraryelements.go Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Update pkg/services/librarypanels/librarypanels.go Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Refactor: changes after PR comments * Refactor: changes after PR comments * Tests: fixes tests * Refactor: renames connections to connectedDashboards Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
305 lines
13 KiB
Go
305 lines
13 KiB
Go
package libraryelements
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestPatchLibraryElement(t *testing.T) {
|
|
scenarioWithPanel(t, "When an admin tries to patch a library panel that does not exist, it should fail",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
cmd := patchLibraryElementCommand{Kind: int64(Panel)}
|
|
sc.reqContext.ReplaceAllParams(map[string]string{":uid": "unknown"})
|
|
resp := sc.service.patchHandler(sc.reqContext, cmd)
|
|
require.Equal(t, 404, resp.Status())
|
|
})
|
|
|
|
scenarioWithPanel(t, "When an admin tries to patch a library panel that exists, it should succeed",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
newFolder := createFolderWithACL(t, sc.sqlStore, "NewFolder", sc.user, []folderACLItem{})
|
|
cmd := patchLibraryElementCommand{
|
|
FolderID: newFolder.Id,
|
|
Name: "Panel - New name",
|
|
Model: []byte(`
|
|
{
|
|
"datasource": "${DS_GDEV-TESTDATA}",
|
|
"description": "An updated description",
|
|
"id": 1,
|
|
"title": "Model - New name",
|
|
"type": "graph"
|
|
}
|
|
`),
|
|
Kind: int64(Panel),
|
|
Version: 1,
|
|
}
|
|
sc.reqContext.ReplaceAllParams(map[string]string{":uid": sc.initialResult.Result.UID})
|
|
resp := sc.service.patchHandler(sc.reqContext, cmd)
|
|
require.Equal(t, 200, resp.Status())
|
|
var result = validateAndUnMarshalResponse(t, resp)
|
|
var expected = libraryElementResult{
|
|
Result: libraryElement{
|
|
ID: 1,
|
|
OrgID: 1,
|
|
FolderID: newFolder.Id,
|
|
UID: sc.initialResult.Result.UID,
|
|
Name: "Panel - New name",
|
|
Kind: int64(Panel),
|
|
Type: "graph",
|
|
Description: "An updated description",
|
|
Model: map[string]interface{}{
|
|
"datasource": "${DS_GDEV-TESTDATA}",
|
|
"description": "An updated description",
|
|
"id": float64(1),
|
|
"title": "Panel - New name",
|
|
"type": "graph",
|
|
},
|
|
Version: 2,
|
|
Meta: LibraryElementDTOMeta{
|
|
ConnectedDashboards: 0,
|
|
Created: sc.initialResult.Result.Meta.Created,
|
|
Updated: result.Result.Meta.Updated,
|
|
CreatedBy: LibraryElementDTOMetaUser{
|
|
ID: 1,
|
|
Name: userInDbName,
|
|
AvatarURL: userInDbAvatar,
|
|
},
|
|
UpdatedBy: LibraryElementDTOMetaUser{
|
|
ID: 1,
|
|
Name: "signed_in_user",
|
|
AvatarURL: "/avatar/37524e1eb8b3e32850b57db0a19af93b",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
if diff := cmp.Diff(expected, result, getCompareOptions()...); diff != "" {
|
|
t.Fatalf("Result mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
|
|
scenarioWithPanel(t, "When an admin tries to patch a library panel with folder only, it should change folder successfully and return correct result",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
newFolder := createFolderWithACL(t, sc.sqlStore, "NewFolder", sc.user, []folderACLItem{})
|
|
cmd := patchLibraryElementCommand{
|
|
FolderID: newFolder.Id,
|
|
Kind: int64(Panel),
|
|
Version: 1,
|
|
}
|
|
sc.reqContext.ReplaceAllParams(map[string]string{":uid": sc.initialResult.Result.UID})
|
|
resp := sc.service.patchHandler(sc.reqContext, cmd)
|
|
require.Equal(t, 200, resp.Status())
|
|
var result = validateAndUnMarshalResponse(t, resp)
|
|
sc.initialResult.Result.FolderID = newFolder.Id
|
|
sc.initialResult.Result.Meta.CreatedBy.Name = userInDbName
|
|
sc.initialResult.Result.Meta.CreatedBy.AvatarURL = userInDbAvatar
|
|
sc.initialResult.Result.Version = 2
|
|
if diff := cmp.Diff(sc.initialResult.Result, result.Result, getCompareOptions()...); diff != "" {
|
|
t.Fatalf("Result mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
|
|
scenarioWithPanel(t, "When an admin tries to patch a library panel with name only, it should change name successfully, sync title and return correct result",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
cmd := patchLibraryElementCommand{
|
|
FolderID: -1,
|
|
Name: "New Name",
|
|
Kind: int64(Panel),
|
|
Version: 1,
|
|
}
|
|
sc.reqContext.ReplaceAllParams(map[string]string{":uid": sc.initialResult.Result.UID})
|
|
resp := sc.service.patchHandler(sc.reqContext, cmd)
|
|
var result = validateAndUnMarshalResponse(t, resp)
|
|
sc.initialResult.Result.Name = "New Name"
|
|
sc.initialResult.Result.Meta.CreatedBy.Name = userInDbName
|
|
sc.initialResult.Result.Meta.CreatedBy.AvatarURL = userInDbAvatar
|
|
sc.initialResult.Result.Model["title"] = "New Name"
|
|
sc.initialResult.Result.Version = 2
|
|
if diff := cmp.Diff(sc.initialResult.Result, result.Result, getCompareOptions()...); diff != "" {
|
|
t.Fatalf("Result mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
|
|
scenarioWithPanel(t, "When an admin tries to patch a library panel with model only, it should change model successfully, sync name, type and description fields and return correct result",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
cmd := patchLibraryElementCommand{
|
|
FolderID: -1,
|
|
Model: []byte(`{ "title": "New Model Title", "name": "New Model Name", "type":"graph", "description": "New description" }`),
|
|
Kind: int64(Panel),
|
|
Version: 1,
|
|
}
|
|
sc.reqContext.ReplaceAllParams(map[string]string{":uid": sc.initialResult.Result.UID})
|
|
resp := sc.service.patchHandler(sc.reqContext, cmd)
|
|
var result = validateAndUnMarshalResponse(t, resp)
|
|
sc.initialResult.Result.Type = "graph"
|
|
sc.initialResult.Result.Description = "New description"
|
|
sc.initialResult.Result.Model = map[string]interface{}{
|
|
"title": "Text - Library Panel",
|
|
"name": "New Model Name",
|
|
"type": "graph",
|
|
"description": "New description",
|
|
}
|
|
sc.initialResult.Result.Meta.CreatedBy.Name = userInDbName
|
|
sc.initialResult.Result.Meta.CreatedBy.AvatarURL = userInDbAvatar
|
|
sc.initialResult.Result.Version = 2
|
|
if diff := cmp.Diff(sc.initialResult.Result, result.Result, getCompareOptions()...); diff != "" {
|
|
t.Fatalf("Result mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
|
|
scenarioWithPanel(t, "When an admin tries to patch a library panel with model.description only, it should change model successfully, sync name, type and description fields and return correct result",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
cmd := patchLibraryElementCommand{
|
|
FolderID: -1,
|
|
Model: []byte(`{ "description": "New description" }`),
|
|
Kind: int64(Panel),
|
|
Version: 1,
|
|
}
|
|
sc.reqContext.ReplaceAllParams(map[string]string{":uid": sc.initialResult.Result.UID})
|
|
resp := sc.service.patchHandler(sc.reqContext, cmd)
|
|
var result = validateAndUnMarshalResponse(t, resp)
|
|
sc.initialResult.Result.Type = "text"
|
|
sc.initialResult.Result.Description = "New description"
|
|
sc.initialResult.Result.Model = map[string]interface{}{
|
|
"title": "Text - Library Panel",
|
|
"type": "text",
|
|
"description": "New description",
|
|
}
|
|
sc.initialResult.Result.Meta.CreatedBy.Name = userInDbName
|
|
sc.initialResult.Result.Meta.CreatedBy.AvatarURL = userInDbAvatar
|
|
sc.initialResult.Result.Version = 2
|
|
if diff := cmp.Diff(sc.initialResult.Result, result.Result, getCompareOptions()...); diff != "" {
|
|
t.Fatalf("Result mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
|
|
scenarioWithPanel(t, "When an admin tries to patch a library panel with model.type only, it should change model successfully, sync name, type and description fields and return correct result",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
cmd := patchLibraryElementCommand{
|
|
FolderID: -1,
|
|
Model: []byte(`{ "type": "graph" }`),
|
|
Kind: int64(Panel),
|
|
Version: 1,
|
|
}
|
|
sc.reqContext.ReplaceAllParams(map[string]string{":uid": sc.initialResult.Result.UID})
|
|
resp := sc.service.patchHandler(sc.reqContext, cmd)
|
|
var result = validateAndUnMarshalResponse(t, resp)
|
|
sc.initialResult.Result.Type = "graph"
|
|
sc.initialResult.Result.Description = "A description"
|
|
sc.initialResult.Result.Model = map[string]interface{}{
|
|
"title": "Text - Library Panel",
|
|
"type": "graph",
|
|
"description": "A description",
|
|
}
|
|
sc.initialResult.Result.Meta.CreatedBy.Name = userInDbName
|
|
sc.initialResult.Result.Meta.CreatedBy.AvatarURL = userInDbAvatar
|
|
sc.initialResult.Result.Version = 2
|
|
if diff := cmp.Diff(sc.initialResult.Result, result.Result, getCompareOptions()...); diff != "" {
|
|
t.Fatalf("Result mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
|
|
scenarioWithPanel(t, "When another admin tries to patch a library panel, it should change UpdatedBy successfully and return correct result",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
cmd := patchLibraryElementCommand{FolderID: -1, Version: 1, Kind: int64(Panel)}
|
|
sc.reqContext.UserId = 2
|
|
sc.reqContext.ReplaceAllParams(map[string]string{":uid": sc.initialResult.Result.UID})
|
|
resp := sc.service.patchHandler(sc.reqContext, cmd)
|
|
var result = validateAndUnMarshalResponse(t, resp)
|
|
sc.initialResult.Result.Meta.UpdatedBy.ID = int64(2)
|
|
sc.initialResult.Result.Meta.CreatedBy.Name = userInDbName
|
|
sc.initialResult.Result.Meta.CreatedBy.AvatarURL = userInDbAvatar
|
|
sc.initialResult.Result.Version = 2
|
|
if diff := cmp.Diff(sc.initialResult.Result, result.Result, getCompareOptions()...); diff != "" {
|
|
t.Fatalf("Result mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
|
|
scenarioWithPanel(t, "When an admin tries to patch a library panel with a name that already exists, it should fail",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
command := getCreatePanelCommand(sc.folder.Id, "Another Panel")
|
|
resp := sc.service.createHandler(sc.reqContext, command)
|
|
var result = validateAndUnMarshalResponse(t, resp)
|
|
cmd := patchLibraryElementCommand{
|
|
Name: "Text - Library Panel",
|
|
Version: 1,
|
|
Kind: int64(Panel),
|
|
}
|
|
sc.reqContext.ReplaceAllParams(map[string]string{":uid": result.Result.UID})
|
|
resp = sc.service.patchHandler(sc.reqContext, cmd)
|
|
require.Equal(t, 400, resp.Status())
|
|
})
|
|
|
|
scenarioWithPanel(t, "When an admin tries to patch a library panel with a folder where a library panel with the same name already exists, it should fail",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
newFolder := createFolderWithACL(t, sc.sqlStore, "NewFolder", sc.user, []folderACLItem{})
|
|
command := getCreatePanelCommand(newFolder.Id, "Text - Library Panel")
|
|
resp := sc.service.createHandler(sc.reqContext, command)
|
|
var result = validateAndUnMarshalResponse(t, resp)
|
|
cmd := patchLibraryElementCommand{
|
|
FolderID: 1,
|
|
Version: 1,
|
|
Kind: int64(Panel),
|
|
}
|
|
sc.reqContext.ReplaceAllParams(map[string]string{":uid": result.Result.UID})
|
|
resp = sc.service.patchHandler(sc.reqContext, cmd)
|
|
require.Equal(t, 400, resp.Status())
|
|
})
|
|
|
|
scenarioWithPanel(t, "When an admin tries to patch a library panel in another org, it should fail",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
cmd := patchLibraryElementCommand{
|
|
FolderID: sc.folder.Id,
|
|
Version: 1,
|
|
Kind: int64(Panel),
|
|
}
|
|
sc.reqContext.OrgId = 2
|
|
sc.reqContext.ReplaceAllParams(map[string]string{":uid": sc.initialResult.Result.UID})
|
|
resp := sc.service.patchHandler(sc.reqContext, cmd)
|
|
require.Equal(t, 404, resp.Status())
|
|
})
|
|
|
|
scenarioWithPanel(t, "When an admin tries to patch a library panel with an old version number, it should fail",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
cmd := patchLibraryElementCommand{
|
|
FolderID: sc.folder.Id,
|
|
Version: 1,
|
|
Kind: int64(Panel),
|
|
}
|
|
sc.reqContext.ReplaceAllParams(map[string]string{":uid": sc.initialResult.Result.UID})
|
|
resp := sc.service.patchHandler(sc.reqContext, cmd)
|
|
require.Equal(t, 200, resp.Status())
|
|
resp = sc.service.patchHandler(sc.reqContext, cmd)
|
|
require.Equal(t, 412, resp.Status())
|
|
})
|
|
|
|
scenarioWithPanel(t, "When an admin tries to patch a library panel with an other kind, it should succeed but panel should not change",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
cmd := patchLibraryElementCommand{
|
|
FolderID: sc.folder.Id,
|
|
Version: 1,
|
|
Kind: int64(Variable),
|
|
}
|
|
sc.reqContext.ReplaceAllParams(map[string]string{":uid": sc.initialResult.Result.UID})
|
|
resp := sc.service.patchHandler(sc.reqContext, cmd)
|
|
require.Equal(t, 200, resp.Status())
|
|
var result = validateAndUnMarshalResponse(t, resp)
|
|
sc.initialResult.Result.Type = "text"
|
|
sc.initialResult.Result.Kind = int64(Panel)
|
|
sc.initialResult.Result.Description = "A description"
|
|
sc.initialResult.Result.Model = map[string]interface{}{
|
|
"datasource": "${DS_GDEV-TESTDATA}",
|
|
"id": float64(1),
|
|
"title": "Text - Library Panel",
|
|
"type": "text",
|
|
"description": "A description",
|
|
}
|
|
sc.initialResult.Result.Meta.CreatedBy.Name = userInDbName
|
|
sc.initialResult.Result.Meta.CreatedBy.AvatarURL = userInDbAvatar
|
|
sc.initialResult.Result.Version = 2
|
|
if diff := cmp.Diff(sc.initialResult.Result, result.Result, getCompareOptions()...); diff != "" {
|
|
t.Fatalf("Result mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
}
|