mirror of
https://github.com/grafana/grafana.git
synced 2024-12-02 05:29:42 -06:00
7a9a52c317
* add severity to victorops * Update docs, add test * Fix spelling and lint * fix resolving not working * Update docs/sources/alerting/notifications.md * Update docs/sources/alerting/notifications.md * Update docs/sources/alerting/notifications.md Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * Update docs/sources/alerting/notifications.md Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * remove table, update supported alert notifiers * add docs * 7.4->7.5 * fix * Update docs/sources/alerting/notifications.md Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
163 lines
4.4 KiB
Go
163 lines
4.4 KiB
Go
package notifiers
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/grafana/grafana/pkg/services/validations"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/grafana/grafana/pkg/components/simplejson"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
"github.com/grafana/grafana/pkg/services/alerting"
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
)
|
|
|
|
func presenceComparerInt(a, b int64) bool {
|
|
if a == -1 {
|
|
return b != 0
|
|
}
|
|
if b == -1 {
|
|
return a != 0
|
|
}
|
|
return a == b
|
|
}
|
|
func TestVictoropsNotifier(t *testing.T) {
|
|
Convey("Victorops notifier tests", t, func() {
|
|
Convey("Parsing alert notification from settings", func() {
|
|
Convey("empty settings should return error", func() {
|
|
json := `{ }`
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "victorops_testing",
|
|
Type: "victorops",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
_, err := NewVictoropsNotifier(model)
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
|
|
Convey("from settings", func() {
|
|
json := `
|
|
{
|
|
"url": "http://google.com"
|
|
}`
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "victorops_testing",
|
|
Type: "victorops",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
not, err := NewVictoropsNotifier(model)
|
|
victoropsNotifier := not.(*VictoropsNotifier)
|
|
|
|
So(err, ShouldBeNil)
|
|
So(victoropsNotifier.Name, ShouldEqual, "victorops_testing")
|
|
So(victoropsNotifier.Type, ShouldEqual, "victorops")
|
|
So(victoropsNotifier.URL, ShouldEqual, "http://google.com")
|
|
})
|
|
|
|
Convey("should return properly formatted event payload when using severity override tag", func() {
|
|
json := `
|
|
{
|
|
"url": "http://google.com"
|
|
}`
|
|
|
|
settingsJSON, err := simplejson.NewJson([]byte(json))
|
|
So(err, ShouldBeNil)
|
|
|
|
model := &models.AlertNotification{
|
|
Name: "victorops_testing",
|
|
Type: "victorops",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
not, err := NewVictoropsNotifier(model)
|
|
So(err, ShouldBeNil)
|
|
|
|
victoropsNotifier := not.(*VictoropsNotifier)
|
|
|
|
evalContext := alerting.NewEvalContext(context.Background(), &alerting.Rule{
|
|
ID: 0,
|
|
Name: "someRule",
|
|
Message: "someMessage",
|
|
State: models.AlertStateAlerting,
|
|
AlertRuleTags: []*models.Tag{
|
|
{Key: "keyOnly"},
|
|
{Key: "severity", Value: "warning"},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
evalContext.IsTestRun = true
|
|
|
|
payload, err := victoropsNotifier.buildEventPayload(evalContext)
|
|
So(err, ShouldBeNil)
|
|
|
|
diff := cmp.Diff(map[string]interface{}{
|
|
"alert_url": "",
|
|
"entity_display_name": "[Alerting] someRule",
|
|
"entity_id": "someRule",
|
|
"message_type": "WARNING",
|
|
"metrics": map[string]interface{}{},
|
|
"monitoring_tool": "Grafana v",
|
|
"state_message": "someMessage",
|
|
"state_start_time": int64(-1),
|
|
"timestamp": int64(-1),
|
|
}, payload.Interface(), cmp.Comparer(presenceComparerInt))
|
|
So(diff, ShouldBeEmpty)
|
|
})
|
|
Convey("resolving with severity works properly", func() {
|
|
json := `
|
|
{
|
|
"url": "http://google.com"
|
|
}`
|
|
|
|
settingsJSON, err := simplejson.NewJson([]byte(json))
|
|
So(err, ShouldBeNil)
|
|
|
|
model := &models.AlertNotification{
|
|
Name: "victorops_testing",
|
|
Type: "victorops",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
not, err := NewVictoropsNotifier(model)
|
|
So(err, ShouldBeNil)
|
|
|
|
victoropsNotifier := not.(*VictoropsNotifier)
|
|
|
|
evalContext := alerting.NewEvalContext(context.Background(), &alerting.Rule{
|
|
ID: 0,
|
|
Name: "someRule",
|
|
Message: "someMessage",
|
|
State: models.AlertStateOK,
|
|
AlertRuleTags: []*models.Tag{
|
|
{Key: "keyOnly"},
|
|
{Key: "severity", Value: "warning"},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
evalContext.IsTestRun = true
|
|
|
|
payload, err := victoropsNotifier.buildEventPayload(evalContext)
|
|
So(err, ShouldBeNil)
|
|
|
|
diff := cmp.Diff(map[string]interface{}{
|
|
"alert_url": "",
|
|
"entity_display_name": "[OK] someRule",
|
|
"entity_id": "someRule",
|
|
"message_type": "RECOVERY",
|
|
"metrics": map[string]interface{}{},
|
|
"monitoring_tool": "Grafana v",
|
|
"state_message": "someMessage",
|
|
"state_start_time": int64(-1),
|
|
"timestamp": int64(-1),
|
|
}, payload.Interface(), cmp.Comparer(presenceComparerInt))
|
|
So(diff, ShouldBeEmpty)
|
|
})
|
|
})
|
|
})
|
|
}
|