mirror of
https://github.com/grafana/grafana.git
synced 2024-12-02 05:29:42 -06:00
1261345b81
* update react 18 related deps * fix some types * make sure we're on react-router-dom >= 5.3.3 * Use new root API * Remove StrictMode for now - react 18 double rendering causes issues * fix + ignore some @grafana/ui types * fix some more types * use renderHook from @testing-library/react in almost all cases * fix storybook types * rewrite useDashboardSave to not use useEffect * make props optional * only render if props are provided * add correct type for useCallback * make resourcepicker tests more robust * fix ModalManager rendering * fix some more unit tests * store the click coordinates in a ref as setState is NOT synchronous * fix remaining e2e tests * rewrite dashboardpage tests to avoid act warnings * undo lint ignores * fix ExpanderCell types * set SymbolCell type correctly * fix QueryAndExpressionsStep * looks like the types were actually wrong instead :D * undo this for now... * remove spinner waits * more robust tests * rewrite errorboundary test to not explicitly count the number of renders * make urlParam expect async * increase timeout in waitFor * revert ExplorePage test changes * Update public/app/features/dashboard/containers/DashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * skip fakeTimer test, ignore table types for now + other review comments * update package peerDeps * small tweak to resourcepicker test * update lockfile... * increase timeout in sharepublicdashboard tests * ensure ExplorePaneContainer passes correct queries to initializeExplore * fix LokiContextUI test * fix unit tests * make importDashboard flow more consistent * wait for dashboard name before continuing * more test fixes * readd dashboard name to variable e2e tests * wait for switches to be enabled before clicking * fix modal rendering * don't use @testing-library/dom directly * quick fix for rendering of panels in firefox * make PromQueryField test more robust * don't wait for chartData - in react 18 this can happen before the wait code even gets executed --------- Co-authored-by: kay delaney <kay@grafana.com> Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
164 lines
5.5 KiB
TypeScript
164 lines
5.5 KiB
TypeScript
import { render, screen, within } from '@testing-library/react';
|
|
import userEvent from '@testing-library/user-event';
|
|
import React from 'react';
|
|
|
|
import { PlaylistForm } from './PlaylistForm';
|
|
import { Playlist } from './types';
|
|
|
|
jest.mock('app/core/components/TagFilter/TagFilter', () => ({
|
|
TagFilter: () => {
|
|
return <>mocked-tag-filter</>;
|
|
},
|
|
}));
|
|
|
|
function getTestContext({ name, interval, items, uid }: Partial<Playlist> = {}) {
|
|
const onSubmitMock = jest.fn();
|
|
const playlist = { name, items, interval, uid } as unknown as Playlist;
|
|
const { rerender } = render(<PlaylistForm onSubmit={onSubmitMock} playlist={playlist} />);
|
|
|
|
return { onSubmitMock, playlist, rerender };
|
|
}
|
|
|
|
const playlist: Playlist = {
|
|
name: 'A test playlist',
|
|
interval: '10m',
|
|
items: [
|
|
{ type: 'dashboard_by_uid', value: 'uid_1' },
|
|
{ type: 'dashboard_by_uid', value: 'uid_2' },
|
|
{ type: 'dashboard_by_tag', value: 'tag_A' },
|
|
],
|
|
uid: 'foo',
|
|
};
|
|
|
|
function rows() {
|
|
return screen.getAllByRole('row');
|
|
}
|
|
|
|
describe('PlaylistForm', () => {
|
|
beforeEach(() => {
|
|
jest.spyOn(console, 'error').mockImplementation(() => {});
|
|
});
|
|
|
|
describe('when mounted without playlist', () => {
|
|
it('then it should contain name and interval fields', () => {
|
|
getTestContext();
|
|
|
|
expect(screen.getByRole('textbox', { name: /playlist name/i })).toBeInTheDocument();
|
|
expect(screen.getByRole('textbox', { name: /playlist interval/i })).toBeInTheDocument();
|
|
expect(screen.queryByRole('row')).not.toBeInTheDocument();
|
|
});
|
|
|
|
it('then name field should have empty string as default value', () => {
|
|
getTestContext();
|
|
|
|
expect(screen.getByRole('textbox', { name: /playlist name/i })).toHaveValue('');
|
|
});
|
|
|
|
it('then interval field should have 5m as default value', () => {
|
|
getTestContext();
|
|
|
|
expect(screen.getByRole('textbox', { name: /playlist interval/i })).toHaveValue('5m');
|
|
});
|
|
});
|
|
|
|
describe('when mounted with a playlist', () => {
|
|
it('then name field should have correct value', () => {
|
|
getTestContext(playlist);
|
|
|
|
expect(screen.getByRole('textbox', { name: /playlist name/i })).toHaveValue('A test playlist');
|
|
});
|
|
|
|
it('then interval field should have correct value', () => {
|
|
getTestContext(playlist);
|
|
|
|
expect(screen.getByRole('textbox', { name: /playlist interval/i })).toHaveValue('10m');
|
|
});
|
|
|
|
it('then items row count should be correct', () => {
|
|
getTestContext(playlist);
|
|
|
|
expect(screen.getAllByRole('row')).toHaveLength(3);
|
|
});
|
|
|
|
it('then the first item row should be correct', () => {
|
|
getTestContext(playlist);
|
|
|
|
expectCorrectRow({ index: 0, type: 'dashboard_by_uid', value: 'uid_1' });
|
|
expectCorrectRow({ index: 1, type: 'dashboard_by_uid', value: 'uid_2' });
|
|
expectCorrectRow({ index: 2, type: 'dashboard_by_tag', value: 'tag_A' });
|
|
});
|
|
});
|
|
|
|
describe('when deleting a playlist item', () => {
|
|
it('then the item should be removed and other items should be correct', async () => {
|
|
getTestContext(playlist);
|
|
|
|
expect(rows()).toHaveLength(3);
|
|
await userEvent.click(within(rows()[2]).getByRole('button', { name: /delete playlist item/i }));
|
|
expect(rows()).toHaveLength(2);
|
|
expectCorrectRow({ index: 0, type: 'dashboard_by_uid', value: 'uid_1' });
|
|
expectCorrectRow({ index: 1, type: 'dashboard_by_uid', value: 'uid_2' });
|
|
});
|
|
});
|
|
|
|
describe('when submitting the form', () => {
|
|
it('then the correct item should be submitted', async () => {
|
|
const { onSubmitMock } = getTestContext(playlist);
|
|
|
|
await userEvent.click(screen.getByRole('button', { name: /save/i }));
|
|
expect(onSubmitMock).toHaveBeenCalledTimes(1);
|
|
expect(onSubmitMock).toHaveBeenCalledWith({
|
|
name: 'A test playlist',
|
|
interval: '10m',
|
|
items: [
|
|
{ type: 'dashboard_by_uid', value: 'uid_1' },
|
|
{ type: 'dashboard_by_uid', value: 'uid_2' },
|
|
{ type: 'dashboard_by_tag', value: 'tag_A' },
|
|
],
|
|
});
|
|
});
|
|
|
|
describe('and name is missing', () => {
|
|
it('then an alert should appear and nothing should be submitted', async () => {
|
|
const { onSubmitMock } = getTestContext({ ...playlist, name: undefined });
|
|
|
|
await userEvent.click(screen.getByRole('button', { name: /save/i }));
|
|
expect(screen.getAllByRole('alert')).toHaveLength(1);
|
|
expect(onSubmitMock).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
describe('and interval is missing', () => {
|
|
it('then an alert should appear and nothing should be submitted', async () => {
|
|
const { onSubmitMock } = getTestContext(playlist);
|
|
|
|
await userEvent.clear(screen.getByRole('textbox', { name: /playlist interval/i }));
|
|
await userEvent.click(screen.getByRole('button', { name: /save/i }));
|
|
expect(screen.getAllByRole('alert')).toHaveLength(1);
|
|
expect(onSubmitMock).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('when items are missing', () => {
|
|
it('then save button is disabled', async () => {
|
|
getTestContext({ ...playlist, items: [] });
|
|
|
|
expect(screen.getByRole('button', { name: /save/i })).toBeDisabled();
|
|
});
|
|
});
|
|
});
|
|
|
|
interface ExpectCorrectRowArgs {
|
|
index: number;
|
|
type: 'dashboard_by_tag' | 'dashboard_by_uid';
|
|
value: string;
|
|
}
|
|
|
|
function expectCorrectRow({ index, type, value }: ExpectCorrectRowArgs) {
|
|
const row = within(rows()[index]);
|
|
const cell = `Playlist item, ${type}, ${value}`;
|
|
const regex = new RegExp(cell, 'i');
|
|
expect(row.getByRole('cell', { name: regex })).toBeInTheDocument();
|
|
}
|