mirror of
https://github.com/grafana/grafana.git
synced 2025-02-15 01:53:33 -06:00
* chore: fix go lint issues * feat(Routing): route standalone plugin pages to the `AppRoutePage` * feat(plugin.json): introduce a new field called `isCorePage` for `includes` * chore: add explanatory comments for types * refactor(AppRootPage): receive the `pluginId` and `pluginSection` through the props Now we are able to receive these as props as the pluginId is defined on navLinks that are registered by plugins. * chore: update teests for AppRootPage * fix: remove rebase issue * tests(applinks): add a test for checking isCorePage plugin page setting * refactor(applinks): update tests to use FindById() and be more resilient to changes * fix: Go lint issues * refactor(routes): use cleaner types when working with plugin nav nodes Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com> * chore: fix linting issues * t: remove `isCorePage` field from includes Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>
86 lines
2.4 KiB
TypeScript
86 lines
2.4 KiB
TypeScript
import { NavModelItem } from '@grafana/data';
|
|
import { config } from '@grafana/runtime';
|
|
import { HOME_NAV_ID } from 'app/core/reducers/navModel';
|
|
|
|
import { buildPluginSectionNav } from './utils';
|
|
|
|
describe('buildPluginSectionNav', () => {
|
|
const pluginNav = { main: { text: 'Plugin nav' }, node: { text: 'Plugin nav' } };
|
|
const app1: NavModelItem = {
|
|
text: 'App1',
|
|
id: 'plugin-page-app1',
|
|
url: '/a/plugin1',
|
|
children: [
|
|
{
|
|
text: 'page1',
|
|
url: '/a/plugin1/page1',
|
|
},
|
|
{
|
|
text: 'page2',
|
|
url: '/a/plugin1/page2',
|
|
},
|
|
],
|
|
};
|
|
|
|
const appsSection = {
|
|
text: 'apps',
|
|
id: 'apps',
|
|
children: [app1],
|
|
};
|
|
|
|
const home = {
|
|
id: HOME_NAV_ID,
|
|
text: 'Home',
|
|
};
|
|
|
|
const adminSection: NavModelItem = {
|
|
text: 'Admin',
|
|
id: 'admin',
|
|
children: [],
|
|
parentItem: home,
|
|
};
|
|
|
|
const standalonePluginPage = {
|
|
id: 'standalone-plugin-page-/a/app2/config',
|
|
text: 'Standalone page',
|
|
parentItem: adminSection,
|
|
};
|
|
|
|
adminSection.children = [standalonePluginPage];
|
|
|
|
app1.parentItem = appsSection;
|
|
|
|
it('Should return pluginNav if topnav is disabled', () => {
|
|
config.featureToggles.topnav = false;
|
|
const result = buildPluginSectionNav(appsSection, pluginNav, '/a/plugin1/page1');
|
|
expect(result).toBe(pluginNav);
|
|
});
|
|
|
|
it('Should return return section nav if topnav is enabled', () => {
|
|
config.featureToggles.topnav = true;
|
|
const result = buildPluginSectionNav(appsSection, pluginNav, '/a/plugin1/page1');
|
|
expect(result?.main.text).toBe('apps');
|
|
});
|
|
|
|
it('Should set active page', () => {
|
|
config.featureToggles.topnav = true;
|
|
const result = buildPluginSectionNav(appsSection, null, '/a/plugin1/page2');
|
|
expect(result?.main.children![0].children![1].active).toBe(true);
|
|
expect(result?.node.text).toBe('page2');
|
|
});
|
|
|
|
it('Should set app section to active', () => {
|
|
config.featureToggles.topnav = true;
|
|
const result = buildPluginSectionNav(appsSection, null, '/a/plugin1');
|
|
expect(result?.main.children![0].active).toBe(true);
|
|
expect(result?.node.text).toBe('App1');
|
|
});
|
|
|
|
it('Should handle standalone page', () => {
|
|
config.featureToggles.topnav = true;
|
|
const result = buildPluginSectionNav(adminSection, pluginNav, '/a/app2/config');
|
|
expect(result?.main.text).toBe('Admin');
|
|
expect(result?.node.text).toBe('Standalone page');
|
|
});
|
|
});
|