mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
* Add split view and basic APIs to extensions * Add comments * Update public/app/AppWrapper.tsx Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com> * Moved the .grafana-app element and deduplicate some code * Remove the provider variants of usePluginLinks/Components * Change buildPluginSectionNav * Update comment * Use eventBus * Remove non existent exports * refactor: use a sidecar service to encapsulate the state * Don't wrap single app in split wrapper * Use hook splitter * Remove inline styles * Type the style props from useSplitter * Move the overflow style changes to appWrapper * Deduplicate some common top level providers * Move modals * Move routes wrappers to it's own file * Use better css and add comments * Remove query rows app extension point * Fix test --------- Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
188 lines
6.0 KiB
TypeScript
188 lines
6.0 KiB
TypeScript
import { memo } from 'react';
|
|
|
|
import { PluginExtensionAddedLinkConfig, PluginExtensionLinkConfig, PluginExtensionPoints } from '@grafana/data';
|
|
|
|
import {
|
|
assertConfigureIsValid,
|
|
assertLinkPathIsValid,
|
|
assertStringProps,
|
|
isGrafanaCoreExtensionPoint,
|
|
isReactComponent,
|
|
} from './validators';
|
|
|
|
describe('Plugin Extension Validators', () => {
|
|
describe('assertLinkPathIsValid()', () => {
|
|
it('should not throw an error if the link path is valid', () => {
|
|
expect(() => {
|
|
const pluginId = 'myorg-b-app';
|
|
const extension = {
|
|
path: `/a/${pluginId}/overview`,
|
|
title: 'My Plugin',
|
|
description: 'My Plugin Description',
|
|
extensionPointId: '...',
|
|
};
|
|
|
|
assertLinkPathIsValid(pluginId, extension.path);
|
|
}).not.toThrowError();
|
|
});
|
|
|
|
it('should throw an error if the link path is pointing to a different plugin', () => {
|
|
expect(() => {
|
|
const extension = {
|
|
path: `/a/myorg-b-app/overview`,
|
|
title: 'My Plugin',
|
|
description: 'My Plugin Description',
|
|
extensionPointId: '...',
|
|
};
|
|
|
|
assertLinkPathIsValid('another-plugin-app', extension.path);
|
|
}).toThrowError();
|
|
});
|
|
|
|
it('should throw an error if the link path is not prefixed with "/a/<PLUGIN_ID>"', () => {
|
|
expect(() => {
|
|
const extension = {
|
|
path: `/some-bad-path`,
|
|
title: 'My Plugin',
|
|
description: 'My Plugin Description',
|
|
extensionPointId: '...',
|
|
};
|
|
|
|
assertLinkPathIsValid('myorg-b-app', extension.path);
|
|
}).toThrowError();
|
|
});
|
|
});
|
|
|
|
describe('assertConfigureIsValid()', () => {
|
|
it('should NOT throw an error if the configure() function is missing', () => {
|
|
expect(() => {
|
|
assertConfigureIsValid({
|
|
title: 'Title',
|
|
description: 'Description',
|
|
targets: 'grafana/some-page/extension-point-a',
|
|
} as PluginExtensionAddedLinkConfig);
|
|
}).not.toThrowError();
|
|
});
|
|
|
|
it('should NOT throw an error if the configure() function is a valid function', () => {
|
|
expect(() => {
|
|
assertConfigureIsValid({
|
|
title: 'Title',
|
|
description: 'Description',
|
|
targets: 'grafana/some-page/extension-point-a',
|
|
configure: (_, {}) => {},
|
|
} as PluginExtensionAddedLinkConfig);
|
|
}).not.toThrowError();
|
|
});
|
|
|
|
it('should throw an error if the configure() function is defined but is not a function', () => {
|
|
expect(() => {
|
|
assertConfigureIsValid(
|
|
// @ts-ignore
|
|
{
|
|
title: 'Title',
|
|
description: 'Description',
|
|
extensionPointId: 'grafana/some-page/extension-point-a',
|
|
handler: () => {},
|
|
configure: '() => {}',
|
|
} as PluginExtensionLinkConfig
|
|
);
|
|
}).toThrowError();
|
|
});
|
|
});
|
|
|
|
describe('assertStringProps()', () => {
|
|
it('should throw an error if any of the expected string properties is missing', () => {
|
|
expect(() => {
|
|
assertStringProps(
|
|
{
|
|
description: 'Description',
|
|
extensionPointId: 'grafana/some-page/extension-point-a',
|
|
},
|
|
['title', 'description', 'extensionPointId']
|
|
);
|
|
}).toThrowError();
|
|
});
|
|
|
|
it('should throw an error if any of the expected string properties is an empty string', () => {
|
|
expect(() => {
|
|
assertStringProps(
|
|
{
|
|
title: '',
|
|
description: 'Description',
|
|
extensionPointId: 'grafana/some-page/extension-point-a',
|
|
},
|
|
['title', 'description', 'extensionPointId']
|
|
);
|
|
}).toThrowError();
|
|
});
|
|
|
|
it('should NOT throw an error if the expected string props are present and not empty', () => {
|
|
expect(() => {
|
|
assertStringProps(
|
|
{
|
|
title: 'Title',
|
|
description: 'Description',
|
|
extensionPointId: 'grafana/some-page/extension-point-a',
|
|
},
|
|
['title', 'description', 'extensionPointId']
|
|
);
|
|
}).not.toThrowError();
|
|
});
|
|
|
|
it('should NOT throw an error if there are other existing and empty string properties, that we did not specify', () => {
|
|
expect(() => {
|
|
assertStringProps(
|
|
{
|
|
title: 'Title',
|
|
description: 'Description',
|
|
extensionPointId: 'grafana/some-page/extension-point-a',
|
|
dontCare: '',
|
|
},
|
|
['title', 'description', 'extensionPointId']
|
|
);
|
|
}).not.toThrowError();
|
|
});
|
|
});
|
|
|
|
describe('isReactComponent()', () => {
|
|
it('should return TRUE if we pass in a valid React component', () => {
|
|
expect(isReactComponent(() => <div>Some text</div>)).toBe(true);
|
|
});
|
|
|
|
it('should return TRUE if we pass in a component wrapped with React.memo()', () => {
|
|
const Component = () => <div>Some text</div>;
|
|
const wrapped = memo(() => (
|
|
<div>
|
|
<Component />
|
|
</div>
|
|
));
|
|
wrapped.displayName = 'MyComponent';
|
|
|
|
expect(isReactComponent(wrapped)).toBe(true);
|
|
});
|
|
|
|
it('should return FALSE if we pass in a valid React component', () => {
|
|
expect(isReactComponent('Foo bar')).toBe(false);
|
|
expect(isReactComponent(123)).toBe(false);
|
|
expect(isReactComponent(false)).toBe(false);
|
|
expect(isReactComponent(undefined)).toBe(false);
|
|
expect(isReactComponent(null)).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('isGrafanaCoreExtensionPoint()', () => {
|
|
it('should return TRUE if we pass an PluginExtensionPoints value', () => {
|
|
expect(isGrafanaCoreExtensionPoint(PluginExtensionPoints.AlertingAlertingRuleAction)).toBe(true);
|
|
});
|
|
|
|
it('should return TRUE if we pass a string that is not listed under the PluginExtensionPoints enum', () => {
|
|
expect(isGrafanaCoreExtensionPoint('grafana/alerting/alertingrule/action')).toBe(true);
|
|
});
|
|
|
|
it('should return FALSE if we pass a string that is not listed under the PluginExtensionPoints enum', () => {
|
|
expect(isGrafanaCoreExtensionPoint('grafana/dashboard/alertingrule/action')).toBe(false);
|
|
});
|
|
});
|
|
});
|