IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

Added debug log for missing post id in embedded permalink (#23790)

Browse Source 
* Added stricter checks for accessing other post embed data

* Added debug log

* Removed unused import

* lint fix
This commit is contained in:
Harshil Sharma 2023-06-22 11:36:12 +05:30 committed by GitHub
parent 2788c883b0
commit 178dbb9f95
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
webapp/channels/src/packages/mattermost-redux/src/reducers/entities/posts.ts
View File

@ -218,6 +218,13 @@ export function handlePosts(state: RelationOneToOne<Post, Post> = {}, action: Ge
const newEmbeds: PostEmbed[] = []; const newEmbeds: PostEmbed[] = [];
for (const embed of otherPost.metadata.embeds) { for (const embed of otherPost.metadata.embeds) {
if (embed.type === 'permalink' && embed.data && !('post_id' in embed.data)) {
// eslint-disable-next-line no-console
console.error('post_id missing in post embed data for permalink.');
// eslint-disable-next-line no-console
console.error(embed.data);
}
if (embed.type === 'permalink' && (embed.data as PostPreviewMetadata).post_id === post.id) { if (embed.type === 'permalink' && (embed.data as PostPreviewMetadata).post_id === post.id) {
// skip if the embed is the deleted post // skip if the embed is the deleted post
continue; continue;