mirror of
https://github.com/mattermost/mattermost.git
synced 2025-02-25 18:55:24 -06:00
[MM-56890] Expose allocs and mutex pprof profiling data (#26243)
This commit is contained in:
parent
994e437f2a
commit
18f7c3775a
@ -175,8 +175,10 @@ func (pm *platformMetrics) initMetricsRouter() error {
|
||||
// Manually add support for paths linked to by index page at /debug/pprof/
|
||||
pm.router.Handle("/debug/pprof/goroutine", pprof.Handler("goroutine"))
|
||||
pm.router.Handle("/debug/pprof/heap", pprof.Handler("heap"))
|
||||
pm.router.Handle("/debug/pprof/allocs", pprof.Handler("allocs"))
|
||||
pm.router.Handle("/debug/pprof/threadcreate", pprof.Handler("threadcreate"))
|
||||
pm.router.Handle("/debug/pprof/block", pprof.Handler("block"))
|
||||
pm.router.Handle("/debug/pprof/mutex", pprof.Handler("mutex"))
|
||||
|
||||
// Plugins metrics route
|
||||
pluginsMetricsRoute := pm.router.PathPrefix("/plugins/{plugin_id:[A-Za-z0-9\\_\\-\\.]+}/metrics").Subrouter()
|
||||
|
93
server/channels/app/platform/metrics_test.go
Normal file
93
server/channels/app/platform/metrics_test.go
Normal file
@ -0,0 +1,93 @@
|
||||
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
||||
// See LICENSE.txt for license information.
|
||||
|
||||
package platform
|
||||
|
||||
import (
|
||||
"io"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"testing"
|
||||
|
||||
"github.com/mattermost/mattermost/server/public/model"
|
||||
"github.com/mattermost/mattermost/server/public/shared/mlog"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
func TestMetricsRouter(t *testing.T) {
|
||||
logger := mlog.CreateTestLogger(t)
|
||||
|
||||
cfg := &model.Config{}
|
||||
cfg.SetDefaults()
|
||||
|
||||
metrics := &platformMetrics{
|
||||
cfgFn: func() *model.Config { return cfg },
|
||||
logger: logger,
|
||||
}
|
||||
|
||||
err := metrics.initMetricsRouter()
|
||||
require.NoError(t, err)
|
||||
|
||||
server := httptest.NewServer(metrics.router)
|
||||
t.Cleanup(server.Close)
|
||||
client := server.Client()
|
||||
|
||||
for name, tc := range map[string]struct {
|
||||
path string
|
||||
method string
|
||||
ExpectedBodyContains string
|
||||
ExpectedCode int
|
||||
}{
|
||||
"root": {path: "", ExpectedBodyContains: "<div><a href=\"/debug/pprof/\">Profiling Root</a></div>"},
|
||||
"root with slash": {path: "/", ExpectedBodyContains: "<div><a href=\"/debug/pprof/\">Profiling Root</a></div>"},
|
||||
"debug redirect": {path: "/debug", ExpectedBodyContains: "<div><a href=\"/debug/pprof/\">Profiling Root</a></div>"},
|
||||
"debug redirect with slash": {path: "/debug/", ExpectedBodyContains: "<div><a href=\"/debug/pprof/\">Profiling Root</a></div>"},
|
||||
"pprof index page": {path: "/debug/pprof", ExpectedBodyContains: "<p>Set debug=1 as a query parameter to export in legacy text format</p>"},
|
||||
"pprof index page with slash": {path: "/debug/pprof/", ExpectedBodyContains: "<p>Set debug=1 as a query parameter to export in legacy text format</p>"},
|
||||
"pprof allocs": {path: "/debug/pprof/allocs"},
|
||||
"pprof block": {path: "/debug/pprof/block"},
|
||||
"pprof cmdline": {path: "/debug/pprof/cmdline"},
|
||||
"pprof goroutine": {path: "/debug/pprof/goroutine"},
|
||||
"pprof heap": {path: "/debug/pprof/heap"},
|
||||
"pprof mutex": {path: "/debug/pprof/mutex"},
|
||||
"pprof profile": {path: "/debug/pprof/profile?seconds=1"},
|
||||
"pprof symbol": {path: "/debug/pprof/symbol"},
|
||||
"pprof threadcreate": {path: "/debug/pprof/threadcreate"},
|
||||
"pprof trace": {path: "/debug/pprof/trace"},
|
||||
} {
|
||||
t.Run(name, func(t *testing.T) {
|
||||
name := name // TODO: Remove once go1.22 is used
|
||||
tc := tc // TODO: Remove once go1.22 is used
|
||||
t.Parallel()
|
||||
|
||||
method := http.MethodGet
|
||||
if tc.method != "" {
|
||||
method = tc.method
|
||||
}
|
||||
url := server.URL + tc.path
|
||||
|
||||
req, err := http.NewRequest(method, url, nil)
|
||||
require.NoError(t, err, name)
|
||||
|
||||
resp, err := client.Do(req)
|
||||
require.NoError(t, err, name)
|
||||
t.Cleanup(func() {
|
||||
err := resp.Body.Close()
|
||||
assert.NoError(t, err)
|
||||
})
|
||||
|
||||
expectedCode := 200
|
||||
if tc.ExpectedCode != 0 {
|
||||
expectedCode = tc.ExpectedCode
|
||||
}
|
||||
assert.Equal(t, expectedCode, resp.StatusCode)
|
||||
|
||||
if tc.ExpectedBodyContains != "" {
|
||||
b, err := io.ReadAll(resp.Body)
|
||||
require.NoError(t, err, name)
|
||||
assert.Contains(t, string(b), tc.ExpectedBodyContains)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
Loading…
Reference in New Issue
Block a user