IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix TestGetServiceEnvironment (#24506)

Browse Source 
A late change to the service environment functionality had us defaulting to `dev` instead of `test` without the `production` build tag. Unfortunately, because these tests were unintentionally being skipped within the submodule, the failure wasn't caught at the time. A simple update addresses the unit tests.

Fixes: https://mattermost.atlassian.net/browse/MM-54197
This commit is contained in:
Jesse Hallam 2023-09-08 11:00:48 -03:00 committed by GitHub
parent 4022d2e762
commit 2d1848bf14
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
server/public/model/service_environment_test.go
View File

@ -16,15 +16,13 @@ import (
// semantics at the unit test level. Validating the default, enterprise service environment is left
// to smoketests before releasing.
func TestGetServiceEnvironment(t *testing.T) {
t.Run("no env defaults to test (without production tag)", func(t *testing.T) {
t.Skip("https://mattermost.atlassian.net/browse/MM-54197")
require.Equal(t, model.ServiceEnvironmentTest, model.GetServiceEnvironment())
t.Run("no env defaults to dev (without production tag)", func(t *testing.T) {
require.Equal(t, model.ServiceEnvironmentDev, model.GetServiceEnvironment())
})
t.Run("empty string defaults to test (without production tag)", func(t *testing.T) {
t.Skip("https://mattermost.atlassian.net/browse/MM-54197")
t.Run("empty string defaults to dev (without production tag)", func(t *testing.T) {
os.Setenv("MM_SERVICEENVIRONMENT", "")
defer os.Unsetenv("MM_SERVICEENVIRONMENT")
require.Equal(t, model.ServiceEnvironmentTest, model.GetServiceEnvironment())
require.Equal(t, model.ServiceEnvironmentDev, model.GetServiceEnvironment())
})
t.Run("production", func(t *testing.T) {
os.Setenv("MM_SERVICEENVIRONMENT", "production")