From 34b87fe88a7e1c05ce97324861124e531a8a840b Mon Sep 17 00:00:00 2001 From: Jonathan Fritz Date: Thu, 27 Jul 2017 10:51:23 -0400 Subject: [PATCH] PLT-7140: Removed all static function decorators that I previously added to jsx files. These were suggested by eslint, but can cause issues for functions that override parent functionality. still can't reproduce the errors seen on spinmint locally, so I'm guessing at this point --- webapp/components/search_bar.jsx | 10 +++++----- webapp/components/search_results.jsx | 2 +- webapp/components/signup/components/signup_email.jsx | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/webapp/components/search_bar.jsx b/webapp/components/search_bar.jsx index f8bb9f4306..fc3c9776e3 100644 --- a/webapp/components/search_bar.jsx +++ b/webapp/components/search_bar.jsx @@ -48,7 +48,7 @@ export default class SearchBar extends React.Component { this.suggestionProviders = [new SearchChannelProvider(), new SearchUserProvider()]; } - static getSearchTermStateFromStores() { + getSearchTermStateFromStores() { var term = SearchStore.getSearchTerm() || ''; return { searchTerm: term @@ -83,7 +83,7 @@ export default class SearchBar extends React.Component { } } - static handleClose(e) { + handleClose(e) { e.preventDefault(); if (Utils.isMobile()) { @@ -110,7 +110,7 @@ export default class SearchBar extends React.Component { }); } - static handleKeyDown() { + handleKeyDown() { // This is just to prevent a JS error } @@ -184,7 +184,7 @@ export default class SearchBar extends React.Component { this.search.blur(); } - static searchMentions(e) { + searchMentions(e) { e.preventDefault(); const user = UserStore.getCurrentUser(); if (SearchStore.isMentionSearch) { @@ -195,7 +195,7 @@ export default class SearchBar extends React.Component { } } - static getFlagged(e) { + getFlagged(e) { e.preventDefault(); if (SearchStore.isFlaggedPosts) { GlobalActions.toggleSideBarAction(false); diff --git a/webapp/components/search_results.jsx b/webapp/components/search_results.jsx index 1e3a85e095..0d403dec18 100644 --- a/webapp/components/search_results.jsx +++ b/webapp/components/search_results.jsx @@ -175,7 +175,7 @@ export default class SearchResults extends React.Component { this.setState({statuses: Object.assign({}, UserStore.getStatuses())}); } - static resize() { + resize() { $('#search-items-container').scrollTop(0); } diff --git a/webapp/components/signup/components/signup_email.jsx b/webapp/components/signup/components/signup_email.jsx index ac083b9241..872439eda5 100644 --- a/webapp/components/signup/components/signup_email.jsx +++ b/webapp/components/signup/components/signup_email.jsx @@ -40,7 +40,7 @@ export default class SignupEmail extends React.Component { this.state = this.getInviteInfo(); } - static componentDidMount() { + componentDidMount() { trackEvent('signup', 'signup_user_01_welcome'); }