diff --git a/app/team.go b/app/team.go index 022f1146b6..a114d8584c 100644 --- a/app/team.go +++ b/app/team.go @@ -609,11 +609,7 @@ func (a *App) GetTeamByInviteId(inviteId string) (*model.Team, *model.AppError) } func (a *App) GetAllTeams() ([]*model.Team, *model.AppError) { - result := <-a.Srv.Store.Team().GetAll() - if result.Err != nil { - return nil, result.Err - } - return result.Data.([]*model.Team), nil + return a.Srv.Store.Team().GetAll() } func (a *App) GetAllTeamsPage(offset int, limit int) ([]*model.Team, *model.AppError) { diff --git a/store/sqlstore/team_store.go b/store/sqlstore/team_store.go index 02cf36cc11..00b4efc46b 100644 --- a/store/sqlstore/team_store.go +++ b/store/sqlstore/team_store.go @@ -357,16 +357,14 @@ func (s SqlTeamStore) SearchPrivate(term string) store.StoreChannel { }) } -func (s SqlTeamStore) GetAll() store.StoreChannel { - return store.Do(func(result *store.StoreResult) { - var data []*model.Team - if _, err := s.GetReplica().Select(&data, "SELECT * FROM Teams ORDER BY DisplayName"); err != nil { - result.Err = model.NewAppError("SqlTeamStore.GetAllTeams", "store.sql_team.get_all.app_error", nil, err.Error(), http.StatusInternalServerError) - return - } +func (s SqlTeamStore) GetAll() ([]*model.Team, *model.AppError) { + var teams []*model.Team - result.Data = data - }) + _, err := s.GetReplica().Select(&teams, "SELECT * FROM Teams ORDER BY DisplayName") + if err != nil { + return nil, model.NewAppError("SqlTeamStore.GetAllTeams", "store.sql_team.get_all.app_error", nil, err.Error(), http.StatusInternalServerError) + } + return teams, nil } func (s SqlTeamStore) GetAllPage(offset int, limit int) store.StoreChannel { diff --git a/store/store.go b/store/store.go index 0946c0f6ec..074edba494 100644 --- a/store/store.go +++ b/store/store.go @@ -90,7 +90,7 @@ type TeamStore interface { SearchAll(term string) StoreChannel SearchOpen(term string) StoreChannel SearchPrivate(term string) StoreChannel - GetAll() StoreChannel + GetAll() ([]*model.Team, *model.AppError) GetAllPage(offset int, limit int) StoreChannel GetAllPrivateTeamListing() StoreChannel GetAllPrivateTeamPageListing(offset int, limit int) StoreChannel diff --git a/store/storetest/mocks/TeamStore.go b/store/storetest/mocks/TeamStore.go index 1ab3533100..9ab52076f0 100644 --- a/store/storetest/mocks/TeamStore.go +++ b/store/storetest/mocks/TeamStore.go @@ -108,19 +108,28 @@ func (_m *TeamStore) GetActiveMemberCount(teamId string) store.StoreChannel { } // GetAll provides a mock function with given fields: -func (_m *TeamStore) GetAll() store.StoreChannel { +func (_m *TeamStore) GetAll() ([]*model.Team, *model.AppError) { ret := _m.Called() - var r0 store.StoreChannel - if rf, ok := ret.Get(0).(func() store.StoreChannel); ok { + var r0 []*model.Team + if rf, ok := ret.Get(0).(func() []*model.Team); ok { r0 = rf() } else { if ret.Get(0) != nil { - r0 = ret.Get(0).(store.StoreChannel) + r0 = ret.Get(0).([]*model.Team) } } - return r0 + var r1 *model.AppError + if rf, ok := ret.Get(1).(func() *model.AppError); ok { + r1 = rf() + } else { + if ret.Get(1) != nil { + r1 = ret.Get(1).(*model.AppError) + } + } + + return r0, r1 } // GetAllForExportAfter provides a mock function with given fields: limit, afterId