IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

MM-56925: Fix unnecessary cache invalidation of pinned post count (#26264)

Browse Source 
invalidateCacheForChannelPosts invalidated the pinned post count
and the lastPostTime cache.

But not all endpoints actually pins or unpins the post. That's only
possible via the UpdatePost or PatchPost methods. Therefore, we remove
the unnecessary cache invalidation.

This is also important because this gets called for every single
channel load, and every new post would invalidate this cache.

https://mattermost.atlassian.net/browse/MM-56925
```release-note
NONE
```
This commit is contained in:
Agniva De Sarker 2024-02-24 11:55:20 +05:30 committed by GitHub
parent 1ae96cefad
commit 401de9b321
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
server/channels/app/post.go
View File

@ -489,7 +489,10 @@ func (a *App) handlePostEvents(c request.CTX, post *model.Post, user *model.User
} }
a.Srv().Platform().InvalidateCacheForChannel(channel) a.Srv().Platform().InvalidateCacheForChannel(channel)
a.invalidateCacheForChannelPosts(channel.Id) if post.IsPinned {
a.Srv().Store().Channel().InvalidatePinnedPostCount(channel.Id)
}
a.Srv().Store().Post().InvalidateLastPostTimeCache(channel.Id)
if _, err := a.SendNotifications(c, post, team, channel, user, parentPostList, setOnline); err != nil { if _, err := a.SendNotifications(c, post, team, channel, user, parentPostList, setOnline); err != nil {
return err return err

12
server/channels/app/post_acknowledgements.go
View File

@ -46,11 +46,9 @@ func (a *App) SaveAcknowledgementForPost(c request.CTX, postID, userID string) (
} }
// The post is always modified since the UpdateAt always changes // The post is always modified since the UpdateAt always changes
a.invalidateCacheForChannelPosts(channel.Id) a.Srv().Store().Post().InvalidateLastPostTimeCache(channel.Id)
a.Srv().Go(func() { a.sendAcknowledgementEvent(model.WebsocketEventAcknowledgementAdded, acknowledgement, post)
a.sendAcknowledgementEvent(model.WebsocketEventAcknowledgementAdded, acknowledgement, post)
})
return acknowledgement, nil return acknowledgement, nil
} }
@ -92,11 +90,9 @@ func (a *App) DeleteAcknowledgementForPost(c request.CTX, postID, userID string)
} }
// The post is always modified since the UpdateAt always changes // The post is always modified since the UpdateAt always changes
a.invalidateCacheForChannelPosts(channel.Id) a.Srv().Store().Post().InvalidateLastPostTimeCache(channel.Id)
a.Srv().Go(func() { a.sendAcknowledgementEvent(model.WebsocketEventAcknowledgementRemoved, oldAck, post)
a.sendAcknowledgementEvent(model.WebsocketEventAcknowledgementRemoved, oldAck, post)
})
return nil return nil
} }

4
server/channels/app/reaction.go
View File

@ -71,7 +71,7 @@ func (a *App) SaveReactionForPost(c request.CTX, reaction *model.Reaction) (*mod
} }
// The post is always modified since the UpdateAt always changes // The post is always modified since the UpdateAt always changes
a.invalidateCacheForChannelPosts(post.ChannelId) a.Srv().Store().Post().InvalidateLastPostTimeCache(channel.Id)
pluginContext := pluginContext(c) pluginContext := pluginContext(c)
a.Srv().Go(func() { a.Srv().Go(func() {
@ -144,7 +144,7 @@ func (a *App) DeleteReactionForPost(c request.CTX, reaction *model.Reaction) *mo
} }
// The post is always modified since the UpdateAt always changes // The post is always modified since the UpdateAt always changes
a.invalidateCacheForChannelPosts(post.ChannelId) a.Srv().Store().Post().InvalidateLastPostTimeCache(channel.Id)
pluginContext := pluginContext(c) pluginContext := pluginContext(c)
a.Srv().Go(func() { a.Srv().Go(func() {