diff --git a/app/user.go b/app/user.go index f6fa82f76d..0c0c5f1bf4 100644 --- a/app/user.go +++ b/app/user.go @@ -618,11 +618,7 @@ func (a *App) GetTeamGroupUsers(teamID string) ([]*model.User, *model.AppError) // GetChannelGroupUsers returns the users who are associated to the channel via GroupChannels and GroupMembers. func (a *App) GetChannelGroupUsers(channelID string) ([]*model.User, *model.AppError) { - result := <-a.Srv.Store.User().GetChannelGroupUsers(channelID) - if result.Err != nil { - return nil, result.Err - } - return result.Data.([]*model.User), nil + return a.Srv.Store.User().GetChannelGroupUsers(channelID) } func (a *App) GetUsersByIds(userIds []string, asAdmin bool, viewRestrictions *model.ViewUsersRestrictions) ([]*model.User, *model.AppError) { diff --git a/store/sqlstore/user_store.go b/store/sqlstore/user_store.go index 58abcc0a6d..0b1efc3b12 100644 --- a/store/sqlstore/user_store.go +++ b/store/sqlstore/user_store.go @@ -1671,28 +1671,24 @@ func (us SqlUserStore) GetTeamGroupUsers(teamID string) store.StoreChannel { }) } -func (us SqlUserStore) GetChannelGroupUsers(channelID string) store.StoreChannel { - return store.Do(func(result *store.StoreResult) { - query := applyChannelGroupConstrainedFilter(us.usersQuery, channelID) +func (us SqlUserStore) GetChannelGroupUsers(channelID string) ([]*model.User, *model.AppError) { + query := applyChannelGroupConstrainedFilter(us.usersQuery, channelID) - queryString, args, err := query.ToSql() - if err != nil { - result.Err = model.NewAppError("SqlUserStore.GetChannelGroupUsers", "store.sql_user.app_error", nil, err.Error(), http.StatusInternalServerError) - return - } + queryString, args, err := query.ToSql() + if err != nil { + return nil, model.NewAppError("SqlUserStore.GetChannelGroupUsers", "store.sql_user.app_error", nil, err.Error(), http.StatusInternalServerError) + } - var users []*model.User - if _, err := us.GetReplica().Select(&users, queryString, args...); err != nil { - result.Err = model.NewAppError("SqlUserStore.GetChannelGroupUsers", "store.sql_user.get_profiles.app_error", nil, err.Error(), http.StatusInternalServerError) - return - } + var users []*model.User + if _, err := us.GetReplica().Select(&users, queryString, args...); err != nil { + return nil, model.NewAppError("SqlUserStore.GetChannelGroupUsers", "store.sql_user.get_profiles.app_error", nil, err.Error(), http.StatusInternalServerError) + } - for _, u := range users { - u.Sanitize(map[string]bool{}) - } + for _, u := range users { + u.Sanitize(map[string]bool{}) + } - result.Data = users - }) + return users, nil } func applyViewRestrictionsFilter(query sq.SelectBuilder, restrictions *model.ViewUsersRestrictions, distinct bool) sq.SelectBuilder { diff --git a/store/store.go b/store/store.go index e226527fe2..1fb11cd7d4 100644 --- a/store/store.go +++ b/store/store.go @@ -303,7 +303,7 @@ type UserStore interface { GetUsersBatchForIndexing(startTime, endTime int64, limit int) ([]*model.UserForIndexing, *model.AppError) Count(options model.UserCountOptions) (int64, *model.AppError) GetTeamGroupUsers(teamID string) StoreChannel - GetChannelGroupUsers(channelID string) StoreChannel + GetChannelGroupUsers(channelID string) ([]*model.User, *model.AppError) } type BotStore interface { diff --git a/store/storetest/mocks/UserStore.go b/store/storetest/mocks/UserStore.go index 3f01e25622..c1c1a97884 100644 --- a/store/storetest/mocks/UserStore.go +++ b/store/storetest/mocks/UserStore.go @@ -309,19 +309,28 @@ func (_m *UserStore) GetByUsername(username string) store.StoreChannel { } // GetChannelGroupUsers provides a mock function with given fields: channelID -func (_m *UserStore) GetChannelGroupUsers(channelID string) store.StoreChannel { +func (_m *UserStore) GetChannelGroupUsers(channelID string) ([]*model.User, *model.AppError) { ret := _m.Called(channelID) - var r0 store.StoreChannel - if rf, ok := ret.Get(0).(func(string) store.StoreChannel); ok { + var r0 []*model.User + if rf, ok := ret.Get(0).(func(string) []*model.User); ok { r0 = rf(channelID) } else { if ret.Get(0) != nil { - r0 = ret.Get(0).(store.StoreChannel) + r0 = ret.Get(0).([]*model.User) } } - return r0 + var r1 *model.AppError + if rf, ok := ret.Get(1).(func(string) *model.AppError); ok { + r1 = rf(channelID) + } else { + if ret.Get(1) != nil { + r1 = ret.Get(1).(*model.AppError) + } + } + + return r0, r1 } // GetEtagForAllProfiles provides a mock function with given fields: diff --git a/store/storetest/user_store.go b/store/storetest/user_store.go index 66db407fee..846ea4dc2b 100644 --- a/store/storetest/user_store.go +++ b/store/storetest/user_store.go @@ -3899,9 +3899,8 @@ func testUserStoreGetChannelGroupUsers(t *testing.T, ss store.Store) { var users []*model.User requireNUsers := func(n int) { - res = <-ss.User().GetChannelGroupUsers(channel.Id) - require.Nil(t, res.Err) - users = res.Data.([]*model.User) + users, err = ss.User().GetChannelGroupUsers(channel.Id) + require.Nil(t, err) require.NotNil(t, users) require.Len(t, users, n) }