IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

[MM-MM-52695] webapp/channels : Change plain import of PropsFromRedux to "import type" for certain files (#23337)

Browse Source 
A while ago, we introduced the PropsFromRedux pattern, which was mostly used in class-based components or functional components if hooks were not used for selectors and dispatch. However, we discussed that it is recommended to import the type PropsFromRedux back to the component file from its index file with the type to avoid any cyclic import bugs.
`import type {PropsFromRedux} from './index'; `
This commit is contained in:
M-ZubairAhmed 2023-05-09 16:28:44 +05:30 committed by GitHub
parent f815c20fca
commit 5c28071fb3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
webapp/channels/src/components/post_edit_history/edited_post_item/edited_post_item.tsx
View File

@ -29,7 +29,7 @@ import InfoToast from 'components/info_toast/info_toast';
import RestorePostModal from '../restore_post_modal';
import {PropsFromRedux} from '.';
import type {PropsFromRedux} from './index';
const DATE_RANGES = [
RelativeRanges.TODAY_TITLE_CASE,

2
webapp/channels/src/components/post_edit_history/post_edit_history.tsx
View File

@ -11,7 +11,7 @@ import LoadingScreen from 'components/loading_screen';
import EditedPostItem from './edited_post_item';
import {PropsFromRedux} from '.';
import type {PropsFromRedux} from './index';
const renderView = (props: Record<string, unknown>): JSX.Element => (
<div

2
webapp/channels/src/components/post_reminder_custom_time_picker_modal/post_reminder_custom_time_picker_modal.tsx
View File

@ -15,7 +15,7 @@ import {getCurrentMomentForTimezone} from 'utils/timezone';
import Constants from 'utils/constants';
import {PropsFromRedux} from './index';
import type {PropsFromRedux} from './index';
import './post_reminder_custom_time_picker_modal.scss';