IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

[MM-18150] plugin panic trace should not be lost (#13559)

Browse Source 
* Transit panic from debug to error

* Parse plugin's StdErr and output panic to the mlog.Error

* Add unit tests

* Change log test

* Remove buffer from logger

* Remove 'panic' string filter

* Change *Buffer to io.Writer

Co-authored-by: mattermod <mattermod@users.noreply.github.com>
This commit is contained in:
Shota Gvinepadze
2020-03-11 11:41:11 +04:00
committed by GitHub
parent 771574b652
commit 5d928b4f94
6 changed files with 76 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
plugin/supervisor.go
View File

@@ -63,6 +63,7 @@ func newSupervisor(pluginInfo *model.BundleInfo, apiImpl API, parentLogger *mlog
HandshakeConfig: handshake,
Plugins: pluginMap,
Cmd: cmd,
Stderr: wrappedLogger.With(mlog.String("source", "plugin_stderr_panic")).StdErrPanicLogWriter(),
SyncStdout: wrappedLogger.With(mlog.String("source", "plugin_stdout")).StdLogWriter(),
SyncStderr: wrappedLogger.With(mlog.String("source", "plugin_stderr")).StdLogWriter(),
Logger: hclogAdaptedLogger,