From 6d427cf005e4013f230d3f74c51840ce6cc99efd Mon Sep 17 00:00:00 2001 From: Ben Schumacher Date: Thu, 4 Jul 2024 19:13:15 +0200 Subject: [PATCH] Revert "Added GetPluginID method and tests (#27281)" (#27540) This reverts commit 4acc4796edb2c1ff93e861b4732c1c758ac76371. --- server/public/model/manifest.go | 4 ---- server/public/model/manifest_test.go | 23 ----------------------- 2 files changed, 27 deletions(-) diff --git a/server/public/model/manifest.go b/server/public/model/manifest.go index 57a1efbc7e..98c4e9abf5 100644 --- a/server/public/model/manifest.go +++ b/server/public/model/manifest.go @@ -322,10 +322,6 @@ func (m *Manifest) IsValid() error { return nil } -func (m *Manifest) GetPluginID() string { - return m.Id -} - func (s *PluginSettingsSchema) isValid() error { for _, setting := range s.Settings { err := setting.isValid() diff --git a/server/public/model/manifest_test.go b/server/public/model/manifest_test.go index 84d3cfb65d..8f42ab5f4b 100644 --- a/server/public/model/manifest_test.go +++ b/server/public/model/manifest_test.go @@ -81,29 +81,6 @@ func TestIsValid(t *testing.T) { } } -func TestGetPluginIdReturnsCorrectId(t *testing.T) { - testCases := []struct { - Title string - Id string - manifest *Manifest - ExpectEqual bool - }{ - {"Ids are Different", "not-same.com.company.test", &Manifest{Id: "com.company.test"}, false}, - {"Ids are the same", "com.company.test", &Manifest{Id: "com.company.test"}, true}, - } - - for _, tc := range testCases { - t.Run(tc.Title, func(t *testing.T) { - id := tc.manifest.GetPluginID() - if tc.ExpectEqual { - assert.Equal(t, tc.Id, id) - } else { - assert.NotEqual(t, tc.Id, id) - } - }) - } -} - func TestIsValidSettingsSchema(t *testing.T) { testCases := []struct { Title string