IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

[MM-47612] Fix flaky TestPluginAPIDeleteUserPreferences (#24406)

Browse Source
This commit is contained in:
Ben Schumacher 2023-09-04 10:41:05 +02:00 committed by GitHub
parent 4dfe790a72
commit 918fff378d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
server/channels/app/plugin_api_test.go
View File

@ -193,7 +193,6 @@ func TestPluginAPIGetUserPreferences(t *testing.T) {
} }
func TestPluginAPIDeleteUserPreferences(t *testing.T) { func TestPluginAPIDeleteUserPreferences(t *testing.T) {
t.Skip("MM-47612")
th := Setup(t) th := Setup(t)
defer th.TearDown() defer th.TearDown()
api := th.SetupPluginAPI() api := th.SetupPluginAPI()
@ -208,7 +207,7 @@ func TestPluginAPIDeleteUserPreferences(t *testing.T) {
preferences, err := api.GetPreferencesForUser(user1.Id) preferences, err := api.GetPreferencesForUser(user1.Id)
require.Nil(t, err) require.Nil(t, err)
assert.Equal(t, 3, len(preferences)) assert.Equal(t, 2, len(preferences))
err = api.DeletePreferencesForUser(user1.Id, preferences) err = api.DeletePreferencesForUser(user1.Id, preferences)
require.Nil(t, err) require.Nil(t, err)
@ -235,15 +234,17 @@ func TestPluginAPIDeleteUserPreferences(t *testing.T) {
preferences, err = api.GetPreferencesForUser(user2.Id) preferences, err = api.GetPreferencesForUser(user2.Id)
require.Nil(t, err) require.Nil(t, err)
assert.Equal(t, 4, len(preferences)) assert.Equal(t, 3, len(preferences))
err = api.DeletePreferencesForUser(user2.Id, []model.Preference{preference}) err = api.DeletePreferencesForUser(user2.Id, []model.Preference{preference})
require.Nil(t, err) require.Nil(t, err)
preferences, err = api.GetPreferencesForUser(user2.Id) preferences, err = api.GetPreferencesForUser(user2.Id)
require.Nil(t, err) require.Nil(t, err)
assert.Equal(t, 2, len(preferences)) assert.Equal(t, 2, len(preferences))
assert.Equal(t, model.PreferenceRecommendedNextSteps, preferences[0].Category) assert.ElementsMatch(t,
assert.Equal(t, model.PreferenceCategoryTutorialSteps, preferences[1].Category) []string{model.PreferenceRecommendedNextSteps, model.PreferenceCategoryTutorialSteps},
[]string{preferences[0].Category, preferences[1].Category},
)
} }
func TestPluginAPIUpdateUserPreferences(t *testing.T) { func TestPluginAPIUpdateUserPreferences(t *testing.T) {