IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

Moved saving multiple user preferences into a database transaction

Browse Source
This commit is contained in:
hmhealey
2015-10-07 10:19:02 -04:00
parent 5832232b6d
commit a6cd2a7961
5 changed files with 152 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
api/preference.go
View File

@@ -20,7 +20,7 @@ func InitPreference(r *mux.Router) {
}
func setPreferences(c *Context, w http.ResponseWriter, r *http.Request) {
var preferences []model.Preference
var preferences []*model.Preference
decoder := json.NewDecoder(r.Body)
if err := decoder.Decode(&preferences); err != nil {
@@ -29,21 +29,17 @@ func setPreferences(c *Context, w http.ResponseWriter, r *http.Request) {
return
}
// just attempt to save/update them one by one and abort if one fails
// in the future, this could probably be done in a transaction, but that's unnecessary now
for _, preference := range preferences {
if c.Session.UserId != preference.UserId {
c.Err = model.NewAppError("setPreferences", "Unable to set preferences for other user", "session.user_id="+c.Session.UserId+", preference.user_id="+preference.UserId)
c.Err.StatusCode = http.StatusUnauthorized
return
}
}
if result := <-Srv.Store.Preference().Save(&preference); result.Err != nil {
if result = <-Srv.Store.Preference().Update(&preference); result.Err != nil {
c.Err = result.Err
return
}
}
if result := <-Srv.Store.Preference().SaveOrUpdate(preferences...); result.Err != nil {
c.Err = result.Err
return
}
w.Write([]byte("true"))