mirror of
https://github.com/mattermost/mattermost.git
synced 2026-08-26 21:27:40 -05:00
Gate ci-report and ci-artifacts on relevant-changed to fix skipped-job failures (#37777)
server-ci.yml always triggers now, but ci-report and ci-artifacts were missed when #37557 gated the other jobs on needs.go.outputs.relevant-changed. On PRs that don't touch server code, build-mattermost-server and the test jobs are skipped, so ci-artifacts fails trying to download a server-dist-artifact that was never uploaded, and ci-report fails trying to validate test logs that don't exist. Skip both cleanly instead. Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
@@ -391,7 +391,9 @@ jobs:
|
||||
|
||||
ci-report:
|
||||
name: Server CI Report
|
||||
if: always()
|
||||
# Skip cleanly (rather than fail) when no relevant Server CI paths
|
||||
# changed, since none of the test jobs it reports on will have run.
|
||||
if: always() && needs.go.outputs.relevant-changed == 'true'
|
||||
permissions:
|
||||
contents: read
|
||||
actions: read
|
||||
@@ -399,6 +401,7 @@ jobs:
|
||||
pull-requests: write
|
||||
issues: write
|
||||
needs:
|
||||
- go
|
||||
- ci-complete
|
||||
uses: ./.github/workflows/server-ci-report.yml
|
||||
secrets:
|
||||
@@ -414,8 +417,11 @@ jobs:
|
||||
|
||||
ci-artifacts:
|
||||
name: Server CI Artifacts
|
||||
# Skip when no relevant Server CI paths changed, since build-mattermost-server
|
||||
# (and thus server-dist-artifact) will not have run.
|
||||
if: >-
|
||||
success('ci-complete') &&
|
||||
needs.go.outputs.relevant-changed == 'true' &&
|
||||
github.repository_owner == 'mattermost' &&
|
||||
github.event_name == 'pull_request' &&
|
||||
github.event.pull_request.head.repo.full_name == github.repository
|
||||
@@ -424,6 +430,7 @@ jobs:
|
||||
actions: read
|
||||
statuses: write
|
||||
needs:
|
||||
- go
|
||||
- ci-complete
|
||||
uses: ./.github/workflows/server-ci-artifacts.yml
|
||||
secrets:
|
||||
|
||||
Reference in New Issue
Block a user