From b9f52126c20eabc34da7348fc9bb5a80f1e12244 Mon Sep 17 00:00:00 2001 From: Harrison Healey Date: Fri, 9 Jun 2023 16:39:48 -0400 Subject: [PATCH] MM-53115 Fix ridiculous Babel bug by removing unused code (#23696) * MM-53115 Fix ridiculous Babel bug by removing unused code * Fix Playbooks clean script missing some files * Turn on typescript-eslint/no-unused-vars ESLint rule for Playbooks --- webapp/playbooks/.eslintrc.json | 7 +++++++ webapp/playbooks/package.json | 2 +- webapp/playbooks/src/actions.ts | 7 +++---- .../components/actions_modal_action_children.tsx | 3 --- .../assets/illustrations/bug_search_svg.tsx | 2 +- .../assets/illustrations/dumpster_fire_svg.tsx | 2 +- .../assets/illustrations/gears_svg.tsx | 2 +- .../assets/illustrations/handshake_svg.tsx | 2 +- .../assets/illustrations/light_bulb_svg.tsx | 2 +- .../assets/illustrations/rocket_man_svg.tsx | 2 +- .../assets/illustrations/rocket_svg.tsx | 2 +- .../assets/illustrations/search_svg.tsx | 2 +- .../illustrations/smiley_sunglasses_svg.tsx | 2 +- .../components/backstage/file_drag_detection.tsx | 4 ++-- .../playbook_edit/automation/menu_list.tsx | 10 ++++++++-- .../playbook_editor/outline/section_actions.tsx | 14 -------------- .../components/backstage/runs_list/filters.tsx | 16 ---------------- .../src/components/backstage/stats_view.tsx | 6 +++--- .../src/components/backstage/upgrade_modal.tsx | 5 +---- .../components/checklist_item/checklist_item.tsx | 1 - .../components/checklist_item/task_actions.tsx | 3 +-- .../checklist_item/task_actions_modal.tsx | 6 ++---- .../src/components/create_playbook_modal.tsx | 3 +-- .../src/components/datetime_parsing.test.ts | 2 +- .../src/components/formatted_duration.tsx | 8 -------- .../src/components/modals/run_update_channel.tsx | 9 --------- .../src/components/modals/run_update_name.tsx | 2 -- webapp/playbooks/src/components/rhs/rhs_home.tsx | 2 +- .../src/components/rhs/rhs_run_list.tsx | 4 ++-- .../playbooks/src/components/upgrade_banner.tsx | 5 +---- .../src/graphql/generated/fragment-masking.ts | 1 + webapp/playbooks/src/hooks/general.test.ts | 4 ++-- webapp/playbooks/src/index.tsx | 2 -- webapp/playbooks/src/types/playbook_run.ts | 4 ---- webapp/playbooks/src/types/settings.ts | 1 + 35 files changed, 47 insertions(+), 102 deletions(-) diff --git a/webapp/playbooks/.eslintrc.json b/webapp/playbooks/.eslintrc.json index 981cb77baa..4ddac0c3e6 100644 --- a/webapp/playbooks/.eslintrc.json +++ b/webapp/playbooks/.eslintrc.json @@ -649,6 +649,13 @@ "@typescript-eslint/ban-ts-ignore": 0, "@typescript-eslint/ban-types": 1, "@typescript-eslint/ban-ts-comment": 0, + "@typescript-eslint/no-unused-vars": [ + 2, + { + "vars": "all", + "args": "after-used" + } + ], "@typescript-eslint/no-var-requires": 0, "@typescript-eslint/prefer-interface": 0, "@typescript-eslint/explicit-function-return-type": 0, diff --git a/webapp/playbooks/package.json b/webapp/playbooks/package.json index 7be642268d..85ce7f6b6c 100644 --- a/webapp/playbooks/package.json +++ b/webapp/playbooks/package.json @@ -107,6 +107,6 @@ "report-unused-exports": "ts-prune", "start:product": "webpack --mode=development --watch", "deploy:product": "node scripts/deploy.js", - "clean": "rm -rf node_modules" + "clean": "rm -rf dist node_modules .eslintcache" } } diff --git a/webapp/playbooks/src/actions.ts b/webapp/playbooks/src/actions.ts index 45542c5e05..df0f4ef139 100644 --- a/webapp/playbooks/src/actions.ts +++ b/webapp/playbooks/src/actions.ts @@ -102,10 +102,9 @@ export function startPlaybookRun(teamId: string, postId?: string) { }; } -export function openUpdateRunNameModal(playbookRunId: string, teamId: string, type: PlaybookRunType, onSubmit: (newName: string) => void) { +export function openUpdateRunNameModal(playbookRunId: string, onSubmit: (newName: string) => void) { return modals.openModal(makeUpdateRunNameModalDefinition({ playbookRunId, - teamId, onSubmit, })); } @@ -352,8 +351,8 @@ export const setChecklistItemsFilter = (key: string, nextState: ChecklistItemsFi nextState, }); -export function openTaskActionsModal(onTaskActionsChange: (newTaskActions: TaskActionType[]) => void, taskActions?: TaskActionType[] | null, playbookRunId?: string) { - return modals.openModal(makeTaskActionsModalDefinition(onTaskActionsChange, taskActions, playbookRunId)); +export function openTaskActionsModal(onTaskActionsChange: (newTaskActions: TaskActionType[]) => void, taskActions?: TaskActionType[] | null) { + return modals.openModal(makeTaskActionsModalDefinition(onTaskActionsChange, taskActions)); } export const closeBackstageRHS = (): CloseBackstageRHS => ({ diff --git a/webapp/playbooks/src/components/actions_modal_action_children.tsx b/webapp/playbooks/src/components/actions_modal_action_children.tsx index 1ade6e2113..ed4272b9af 100644 --- a/webapp/playbooks/src/components/actions_modal_action_children.tsx +++ b/webapp/playbooks/src/components/actions_modal_action_children.tsx @@ -4,8 +4,6 @@ import React from 'react'; import {useIntl} from 'react-intl'; -import {useFloatingPortalNode} from '@floating-ui/react-dom-interactions'; - import {usePlaybook, usePlaybooksCrud} from 'src/hooks'; import MarkdownTextbox from 'src/components/markdown_textbox'; @@ -49,7 +47,6 @@ interface OptionType { export const RunPlaybookChildren = ({playbookId, onUpdate, editable}: RunPlaybookProps) => { const {formatMessage} = useIntl(); - const portalEl = useFloatingPortalNode(); const [playbook] = usePlaybook(playbookId); const {playbooks, params, setSearchTerm} = usePlaybooksCrud({sort: 'title'}, {infinitePaging: false}); diff --git a/webapp/playbooks/src/components/assets/illustrations/bug_search_svg.tsx b/webapp/playbooks/src/components/assets/illustrations/bug_search_svg.tsx index 3e453c09a3..b173c4c8a8 100644 --- a/webapp/playbooks/src/components/assets/illustrations/bug_search_svg.tsx +++ b/webapp/playbooks/src/components/assets/illustrations/bug_search_svg.tsx @@ -5,7 +5,7 @@ import React from 'react'; import Svg from 'src/components/assets/svg'; -const BugSearch = (props: {className?: string}) => ( +const BugSearch = () => ( ( +const DumpsterFire = () => ( ( +const Gears = () => ( ( +const Handshake = () => ( ( +const LightBulb = () => ( ( +const RocketMan = () => ( ( +const Rocket = () => ( ( +const Search = () => ( ( +const SmileySunglasses = () => ( { setIsDraggingFile(dragDepth > 0); }; - const handleDragEnter = (e: DragEvent) => { + const handleDragEnter = () => { dragDepth++; updateIsDraggingFile(); }; - const handleDragLeave = (e: DragEvent) => { + const handleDragLeave = () => { dragDepth--; updateIsDraggingFile(); }; diff --git a/webapp/playbooks/src/components/backstage/playbook_edit/automation/menu_list.tsx b/webapp/playbooks/src/components/backstage/playbook_edit/automation/menu_list.tsx index 13dd230ebf..ca9e3bc55c 100644 --- a/webapp/playbooks/src/components/backstage/playbook_edit/automation/menu_list.tsx +++ b/webapp/playbooks/src/components/backstage/playbook_edit/automation/menu_list.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import React, {useCallback} from 'react'; import styled from 'styled-components'; import {Scrollbars} from 'react-custom-scrollbars'; @@ -26,11 +26,17 @@ const ThumbVertical = styled.div` `; const MenuList = (props: MenuListComponentProps) => { + const renderThumbVertical = useCallback((thumbProps) => { + const thumbPropsWithoutStyle = {...thumbProps}; + Reflect.deleteProperty(thumbPropsWithoutStyle, 'style'); + return ; + }, []); + return ( } + renderThumbVertical={renderThumbVertical} > {props.children} diff --git a/webapp/playbooks/src/components/backstage/playbook_editor/outline/section_actions.tsx b/webapp/playbooks/src/components/backstage/playbook_editor/outline/section_actions.tsx index 47e4eafc98..ae9c369f74 100644 --- a/webapp/playbooks/src/components/backstage/playbook_editor/outline/section_actions.tsx +++ b/webapp/playbooks/src/components/backstage/playbook_editor/outline/section_actions.tsx @@ -154,20 +154,6 @@ const LegacyActionsEdit = ({playbook}: Props) => { }); }; - const handleToggleCategorizePlaybookRun = () => { - updatePlaybook({ - categorizeChannelEnabled: !playbook.categorize_channel_enabled, - }); - }; - - const handleCategoryNameChange = (categoryName: string) => { - if (playbook.category_name !== categoryName) { - updatePlaybook({ - categoryName, - }); - } - }; - return ( <> diff --git a/webapp/playbooks/src/components/backstage/runs_list/filters.tsx b/webapp/playbooks/src/components/backstage/runs_list/filters.tsx index cb97ce0d42..f406d412da 100644 --- a/webapp/playbooks/src/components/backstage/runs_list/filters.tsx +++ b/webapp/playbooks/src/components/backstage/runs_list/filters.tsx @@ -64,10 +64,6 @@ const OwnerControlComponent = (ownProps: ControlProps) = return controlComponent(ownProps, 'owners'); }; -const TeamControlComponent = (ownProps: ControlProps) => { - return controlComponent(ownProps, 'teams'); -}; - const PlaybookControlComponent = (ownProps: ControlProps) => { return controlComponent(ownProps, 'playbooks'); }; @@ -75,7 +71,6 @@ const PlaybookControlComponent = (ownProps: ControlProps { const {formatMessage} = useIntl(); const [profileSelectorToggle, setProfileSelectorToggle] = useState(false); - const [teamSelectorToggle, setTeamSelectorToggle] = useState(false); const [playbookSelectorToggle, setPlaybookSelectorToggle] = useState(false); const currentTeamId = useSelector(getCurrentTeamId); @@ -92,12 +87,6 @@ const Filters = ({fetchParams, setFetchParams, fixedPlaybook, fixedFinished}: Pr }); }; - const setTeamId = (teamId?: string) => { - setFetchParams((oldParams) => { - return {...oldParams, team_id: teamId, page: 0}; - }); - }; - const setPlaybookId = (playbookId?: string) => { setFetchParams((oldParams) => { return {...oldParams, playbook_id: playbookId, page: 0}; @@ -122,11 +111,6 @@ const Filters = ({fetchParams, setFetchParams, fixedPlaybook, fixedFinished}: Pr setProfileSelectorToggle(!profileSelectorToggle); }; - const resetTeam = () => { - setTeamId(); - setTeamSelectorToggle(!teamSelectorToggle); - }; - const resetPlaybook = () => { setPlaybookId(); setPlaybookSelectorToggle(!playbookSelectorToggle); diff --git a/webapp/playbooks/src/components/backstage/stats_view.tsx b/webapp/playbooks/src/components/backstage/stats_view.tsx index 74ac8dd93d..b722c11b66 100644 --- a/webapp/playbooks/src/components/backstage/stats_view.tsx +++ b/webapp/playbooks/src/components/backstage/stats_view.tsx @@ -147,7 +147,7 @@ const StatsView = (props: Props) => { DateTime.fromMillis(start).toLocaleString(DateTimeFormats.DATE_MED_NO_YEAR))} + labels={props.stats.runs_started_per_week_times.map(([start]) => DateTime.fromMillis(start).toLocaleString(DateTimeFormats.DATE_MED_NO_YEAR))} data={props.stats.runs_started_per_week} tooltipTitleCallback={(date) => formatMessage({defaultMessage: 'Week of {date}'}, {date})} tooltipLabelCallback={(numTotalRuns) => formatMessage({defaultMessage: '{numTotalRuns, plural, =0 {no runs started} =1 {# run started} other {# runs started}}'}, {numTotalRuns})} @@ -159,7 +159,7 @@ const StatsView = (props: Props) => { DateTime.fromMillis(start).toLocaleString(DateTimeFormats.DATE_MED_NO_YEAR))} + labels={props.stats.active_runs_per_day_times.map(([start]) => DateTime.fromMillis(start).toLocaleString(DateTimeFormats.DATE_MED_NO_YEAR))} data={props.stats.active_runs_per_day} tooltipTitleCallback={(date) => formatMessage({defaultMessage: 'Day: {date}'}, {date})} tooltipLabelCallback={(numActiveRuns) => formatMessage({defaultMessage: '{numActiveRuns, plural, =0 {no active runs} =1 {# active run} other {# active runs}}'}, {numActiveRuns})} @@ -169,7 +169,7 @@ const StatsView = (props: Props) => { DateTime.fromMillis(start).toLocaleString(DateTimeFormats.DATE_MED_NO_YEAR))} + labels={props.stats.active_participants_per_day_times.map(([start]) => DateTime.fromMillis(start).toLocaleString(DateTimeFormats.DATE_MED_NO_YEAR))} data={props.stats.active_participants_per_day} color={'--center-channel-color-40'} tooltipTitleCallback={(date) => formatMessage({defaultMessage: 'Day: {date}'}, {date})} diff --git a/webapp/playbooks/src/components/backstage/upgrade_modal.tsx b/webapp/playbooks/src/components/backstage/upgrade_modal.tsx index 999f9de68b..36260e922c 100644 --- a/webapp/playbooks/src/components/backstage/upgrade_modal.tsx +++ b/webapp/playbooks/src/components/backstage/upgrade_modal.tsx @@ -7,7 +7,7 @@ import GenericModal, {DefaultFooterContainer} from 'src/components/widgets/gener import {postMessageToAdmins} from 'src/client'; import UpgradeModalFooter from 'src/components/backstage/upgrade_modal_footer'; -import {getAdminAnalytics, isCurrentUserAdmin, isTeamEdition} from 'src/selectors'; +import {isCurrentUserAdmin, isTeamEdition} from 'src/selectors'; import {AdminNotificationType} from 'src/constants'; import {isCloud} from 'src/license'; @@ -33,9 +33,6 @@ const UpgradeModal = (props: Props) => { const [actionState, setActionState] = useState(ModalActionState.Uninitialized); - const analytics = useSelector(getAdminAnalytics); - const serverTotalUsers = analytics?.TOTAL_USERS || 0; - const requestLicenseSelfHosted = async () => { if (actionState === ModalActionState.Loading) { return; diff --git a/webapp/playbooks/src/components/checklist_item/checklist_item.tsx b/webapp/playbooks/src/components/checklist_item/checklist_item.tsx index 3d8e8f7cba..b566e93424 100644 --- a/webapp/playbooks/src/components/checklist_item/checklist_item.tsx +++ b/webapp/playbooks/src/components/checklist_item/checklist_item.tsx @@ -280,7 +280,6 @@ export const ChecklistItem = (props: ChecklistItemProps): React.ReactElement => ); diff --git a/webapp/playbooks/src/components/checklist_item/task_actions.tsx b/webapp/playbooks/src/components/checklist_item/task_actions.tsx index c6cbc99637..3ecf97815e 100644 --- a/webapp/playbooks/src/components/checklist_item/task_actions.tsx +++ b/webapp/playbooks/src/components/checklist_item/task_actions.tsx @@ -10,7 +10,6 @@ import {openTaskActionsModal} from 'src/actions'; interface TaskActionsProps { taskActions?: TaskActionType[] | null onTaskActionsChange: (newTaskActions: TaskActionType[]) => void; - playbookRunId?: string; editable: boolean; } @@ -33,7 +32,7 @@ const TaskActions = (props: TaskActionsProps) => { isPlaceholder={!(lenTasks > 0 && enabledAction)} onClick={() => { if (props.editable) { - dispatch(openTaskActionsModal(props.onTaskActionsChange, props.taskActions, props.playbookRunId)); + dispatch(openTaskActionsModal(props.onTaskActionsChange, props.taskActions)); } }} > diff --git a/webapp/playbooks/src/components/checklist_item/task_actions_modal.tsx b/webapp/playbooks/src/components/checklist_item/task_actions_modal.tsx index c7c847850b..513096071b 100644 --- a/webapp/playbooks/src/components/checklist_item/task_actions_modal.tsx +++ b/webapp/playbooks/src/components/checklist_item/task_actions_modal.tsx @@ -21,11 +21,10 @@ const MarkItemAsDoneActionType = 'mark_item_as_done'; export const makeTaskActionsModalDefinition = ( onTaskActionsChange: (newTaskActions: TaskActionType[]) => void, taskActions?: TaskActionType[] | null, - playbookRunId?: string, ) => ({ modalId: ID, dialogType: TaskActionsModal, - dialogProps: {taskActions, onTaskActionsChange, playbookRunId}, + dialogProps: {taskActions, onTaskActionsChange}, }); type KeywordsTriggerPayload = {keywords: string[]; user_ids: string[];} @@ -49,10 +48,9 @@ const markAsDonePayloadFromTaskAction = (taskAction: TaskActionType): MarkAsDone type Props = { onTaskActionsChange: (newTaskActions: TaskActionType[]) => void, taskActions?: TaskActionType[] | null, - playbookRunId?: string, } & Partial>; -const TaskActionsModal = ({onTaskActionsChange, taskActions, playbookRunId, ...modalProps}: Props) => { +const TaskActionsModal = ({onTaskActionsChange, taskActions, ...modalProps}: Props) => { const {formatMessage} = useIntl(); const emptyTask = {} as TaskActionType; const taskAction = (taskActions && (taskActions.length > 0)) ? taskActions[0] : emptyTask; diff --git a/webapp/playbooks/src/components/create_playbook_modal.tsx b/webapp/playbooks/src/components/create_playbook_modal.tsx index 1b5e9abcd7..f63fce1fb4 100644 --- a/webapp/playbooks/src/components/create_playbook_modal.tsx +++ b/webapp/playbooks/src/components/create_playbook_modal.tsx @@ -26,7 +26,6 @@ export const makePlaybookCreateModal = (props: PlaybookCreateModalProps) => ({ export type PlaybookCreateModalProps = { startingName?: string - startingTeamId?: string startingTemplate?: string startingDescription?: string startingPublic?: boolean @@ -45,7 +44,7 @@ const Body = styled.div` } `; -const PlaybookCreateModal = ({startingName, startingTeamId, startingTemplate, startingDescription, startingPublic, ...modalProps}: PlaybookCreateModalProps) => { +const PlaybookCreateModal = ({startingName, startingTemplate, startingDescription, startingPublic, ...modalProps}: PlaybookCreateModalProps) => { const {formatMessage} = useIntl(); const [name, setName] = useState(startingName); const teamId = useSelector(getCurrentTeamId); diff --git a/webapp/playbooks/src/components/datetime_parsing.test.ts b/webapp/playbooks/src/components/datetime_parsing.test.ts index e7429c9b83..5917e15877 100644 --- a/webapp/playbooks/src/components/datetime_parsing.test.ts +++ b/webapp/playbooks/src/components/datetime_parsing.test.ts @@ -69,7 +69,7 @@ describe('durationFromQuery', () => { Settings.defaultLocale = locale; const duration = Duration.fromObject(durationObj); - const [long, short, narrow] = [...queries].map((query) => durationFromQuery(locale, query)); + const [long/*, short, narrow*/] = [...queries].map((query) => durationFromQuery(locale, query)); expect(long?.toMillis()).toBe(duration.toMillis()); diff --git a/webapp/playbooks/src/components/formatted_duration.tsx b/webapp/playbooks/src/components/formatted_duration.tsx index 94114573f8..5775e54286 100644 --- a/webapp/playbooks/src/components/formatted_duration.tsx +++ b/webapp/playbooks/src/components/formatted_duration.tsx @@ -27,14 +27,6 @@ interface DurationProps { truncate?: TruncateBehavior; } -const label = (num: number, style: FormatStyle, narrow: string, singular: string, plural: string) => { - if (style === 'narrow') { - return narrow; - } - - return num >= 2 ? plural : singular; -}; - const UNITS: DurationUnit[] = ['years', 'days', 'hours', 'minutes']; export const formatDuration = (value: Duration, style: FormatStyle = 'narrow', truncate: TruncateBehavior = 'none') => { diff --git a/webapp/playbooks/src/components/modals/run_update_channel.tsx b/webapp/playbooks/src/components/modals/run_update_channel.tsx index e4c53adaf4..524cb5145d 100644 --- a/webapp/playbooks/src/components/modals/run_update_channel.tsx +++ b/webapp/playbooks/src/components/modals/run_update_channel.tsx @@ -44,15 +44,6 @@ const UpdateRunModal = ({ } }, [run, run?.channel_id]); - const header = ( -
- {isPlaybookRun ? formatMessage({defaultMessage: 'Link run to a different channel'}) : formatMessage({defaultMessage: 'Link checklist to a different channel'})} - - {run?.name} - -
- ); - return ( void; } & Partial>; @@ -26,7 +25,6 @@ export const makeModalDefinition = (props: Props) => ({ const UpdateRunModal = ({ playbookRunId, - teamId, onSubmit, ...modalProps }: Props) => { diff --git a/webapp/playbooks/src/components/rhs/rhs_home.tsx b/webapp/playbooks/src/components/rhs/rhs_home.tsx index 9edfb57c36..15cb0be76a 100644 --- a/webapp/playbooks/src/components/rhs/rhs_home.tsx +++ b/webapp/playbooks/src/components/rhs/rhs_home.tsx @@ -118,7 +118,7 @@ const RHSHome = () => { telemetryEventForTemplate(template.title, 'use_template_option'); } - dispatch(displayPlaybookCreateModal({startingTemplate: template?.title, startingTeamId: currentTeamId})); + dispatch(displayPlaybookCreateModal({startingTemplate: template?.title})); }; const headerContent = ( diff --git a/webapp/playbooks/src/components/rhs/rhs_run_list.tsx b/webapp/playbooks/src/components/rhs/rhs_run_list.tsx index 62d3ed2102..b326f9771c 100644 --- a/webapp/playbooks/src/components/rhs/rhs_run_list.tsx +++ b/webapp/playbooks/src/components/rhs/rhs_run_list.tsx @@ -808,7 +808,7 @@ const ContextMenu = (props: ContextMenuProps) => { dispatch(openUpdateRunNameModal(props.playbookRunID, props.teamID, PlaybookRunType.Playbook, props.onUpdateName))} + onClick={() => dispatch(openUpdateRunNameModal(props.playbookRunID, props.onUpdateName))} disabled={!props.canEditRun} disabledAltText={formatMessage({defaultMessage: 'You do not have permission to edit this run'})} > @@ -871,7 +871,7 @@ const ChannelChecklistContextMenu = (props: ChannelChecklistContextMenuProps) => dispatch(openUpdateRunNameModal(props.playbookRunID, props.teamID, PlaybookRunType.ChannelChecklist, props.onUpdateName))} + onClick={() => dispatch(openUpdateRunNameModal(props.playbookRunID, props.onUpdateName))} disabled={!props.canEditRun} disabledAltText={formatMessage({defaultMessage: 'You do not have permission to edit this checklist'})} > diff --git a/webapp/playbooks/src/components/upgrade_banner.tsx b/webapp/playbooks/src/components/upgrade_banner.tsx index 0de5d5b5bf..d97816df0e 100644 --- a/webapp/playbooks/src/components/upgrade_banner.tsx +++ b/webapp/playbooks/src/components/upgrade_banner.tsx @@ -11,7 +11,7 @@ import General from 'mattermost-redux/constants/general'; import {FormattedMessage} from 'react-intl'; import LoadingSpinner from 'src/components/assets/loading_spinner'; -import {getAdminAnalytics, isTeamEdition} from 'src/selectors'; +import {isTeamEdition} from 'src/selectors'; import StartTrialNotice from 'src/components/backstage/start_trial_notice'; import ConvertEnterpriseNotice from 'src/components/backstage/convert_enterprise_notice'; import {postMessageToAdmins} from 'src/client'; @@ -127,9 +127,6 @@ const UpgradeBanner = (props: Props) => { const isServerTeamEdition = useSelector(isTeamEdition); const openTrialFormModal = useOpenStartTrialFormModal(); - const analytics = useSelector(getAdminAnalytics); - const serverTotalUsers = analytics?.TOTAL_USERS || 0; - const endUserMainAction = async () => { if (actionState === ActionState.Loading) { return; diff --git a/webapp/playbooks/src/graphql/generated/fragment-masking.ts b/webapp/playbooks/src/graphql/generated/fragment-masking.ts index 444584ff66..c6921e8217 100644 --- a/webapp/playbooks/src/graphql/generated/fragment-masking.ts +++ b/webapp/playbooks/src/graphql/generated/fragment-masking.ts @@ -1,3 +1,4 @@ +/* eslint-disable */ import {TypedDocumentNode as DocumentNode, ResultOf} from '@graphql-typed-document-node/core'; export type FragmentType> = TDocumentType extends DocumentNode< diff --git a/webapp/playbooks/src/hooks/general.test.ts b/webapp/playbooks/src/hooks/general.test.ts index 9ffce12007..313dc7e61f 100644 --- a/webapp/playbooks/src/hooks/general.test.ts +++ b/webapp/playbooks/src/hooks/general.test.ts @@ -80,7 +80,7 @@ describe('useEnsureProfile', () => { useDispatchSpy.mockReturnValue(mockDispatchFn); const userId = 'unknown'; - const {rerender} = renderHook(() => { + renderHook(() => { useEnsureProfile(userId); }); expect(mockDispatchFn).toHaveBeenCalledTimes(1); @@ -184,7 +184,7 @@ describe('useEnsureProfiles', () => { useDispatchSpy.mockReturnValue(mockDispatchFn); const userIds = ['user1', 'user2', 'unknown']; - const {rerender} = renderHook(() => { + renderHook(() => { useEnsureProfiles(userIds); }); expect(mockDispatchFn).toHaveBeenCalledTimes(1); diff --git a/webapp/playbooks/src/index.tsx b/webapp/playbooks/src/index.tsx index d72b244f2f..2e4ff7e91d 100644 --- a/webapp/playbooks/src/index.tsx +++ b/webapp/playbooks/src/index.tsx @@ -6,7 +6,6 @@ import {render, unmountComponentAtNode} from 'react-dom'; import {Store, Unsubscribe} from 'redux'; import {Redirect, useLocation, useRouteMatch} from 'react-router-dom'; import {GlobalState} from '@mattermost/types/store'; -import {getConfig} from 'mattermost-redux/selectors/entities/general'; import {Client4} from 'mattermost-redux/client'; import WebsocketEvents from 'mattermost-redux/constants/websocket'; import {General} from 'mattermost-redux/constants'; @@ -203,7 +202,6 @@ export default class Plugin { // App Bar icon if (registry.registerAppBarComponent) { - const siteUrl = getConfig(store.getState())?.SiteURL || ''; registry.registerAppBarComponent(appIcon, boundToggleRHSAction, ChannelHeaderTooltip); } diff --git a/webapp/playbooks/src/types/playbook_run.ts b/webapp/playbooks/src/types/playbook_run.ts index 7c1cd75799..d30425eb60 100644 --- a/webapp/playbooks/src/types/playbook_run.ts +++ b/webapp/playbooks/src/types/playbook_run.ts @@ -93,10 +93,6 @@ export interface RunMetricData { value: number | null; } -function isString(arg: any): arg is string { - return Boolean(typeof arg === 'string'); -} - export function playbookRunIsActive(playbookRun: PlaybookRun): boolean { return playbookRun.current_status === PlaybookRunStatus.InProgress; } diff --git a/webapp/playbooks/src/types/settings.ts b/webapp/playbooks/src/types/settings.ts index 56c8427c92..8bde2f4be9 100644 --- a/webapp/playbooks/src/types/settings.ts +++ b/webapp/playbooks/src/types/settings.ts @@ -20,6 +20,7 @@ export function globalSettingsSetDefaults(globalSettings?: Partial value !== null)); return {...defaults, ...fixedGlobalSettings};