From ce63a20980d6ee3d688105bc53efdc26ab734a0e Mon Sep 17 00:00:00 2001 From: Angel Mendez Date: Wed, 9 Oct 2024 07:32:39 -0600 Subject: [PATCH] refactor: convert accessibility specs to ts (#28348) --- ...spec.js => accessibility_input_fields_spec.ts} | 6 ++++-- ....js => accessibility_modals_dialogs_1_spec.ts} | 15 +++++++++------ ...ec.js => accessibility_modals_dialogs_spec.ts} | 15 +++++++++------ 3 files changed, 22 insertions(+), 14 deletions(-) rename e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/{accessibility_input_fields_spec.js => accessibility_input_fields_spec.ts} (99%) rename e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/{accessibility_modals_dialogs_1_spec.js => accessibility_modals_dialogs_1_spec.ts} (91%) rename e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/{accessibility_modals_dialogs_spec.js => accessibility_modals_dialogs_spec.ts} (95%) diff --git a/e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_input_fields_spec.js b/e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_input_fields_spec.ts similarity index 99% rename from e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_input_fields_spec.js rename to e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_input_fields_spec.ts index 08f25fc8d4..d4474c3f14 100644 --- a/e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_input_fields_spec.js +++ b/e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_input_fields_spec.ts @@ -10,11 +10,13 @@ // Stage: @prod // Group: @channels @enterprise @accessibility +import {Channel} from '@mattermost/types/channels'; +import {Team} from '@mattermost/types/teams'; import * as TIMEOUTS from '../../../../fixtures/timeouts'; describe('Verify Accessibility Support in different input fields', () => { - let testTeam; - let testChannel; + let testTeam: Team; + let testChannel: Channel; before(() => { // * Check if server has license for Guest Accounts diff --git a/e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_1_spec.js b/e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_1_spec.ts similarity index 91% rename from e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_1_spec.js rename to e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_1_spec.ts index b7cad800a8..0397a8e2f4 100644 --- a/e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_1_spec.js +++ b/e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_1_spec.ts @@ -9,12 +9,15 @@ // Group: @channels @enterprise @accessibility +import {Channel} from '@mattermost/types/channels'; +import {Team} from '@mattermost/types/teams'; +import {UserProfile} from '@mattermost/types/users'; import * as TIMEOUTS from '../../../../fixtures/timeouts'; describe('Verify Accessibility Support in Modals & Dialogs', () => { - let testTeam; - let testChannel; - let testUser; + let testTeam: Team; + let testChannel: Channel; + let testUser: UserProfile; before(() => { // * Check if server has license for Guest Accounts @@ -109,12 +112,12 @@ describe('Verify Accessibility Support in Modals & Dialogs', () => { }); }); -function verifyMainMenuModal(menuItem, modalName) { +function verifyMainMenuModal(menuItem: string, modalName?: string) { cy.uiGetLHSHeader().click(); verifyModal(menuItem, modalName); } -function verifyChannelMenuModal(menuItem, modalName) { +function verifyChannelMenuModal(menuItem: string, modalName?: string) { cy.get('#channelHeaderDropdownIcon').click(); verifyModal(menuItem, modalName); } @@ -124,7 +127,7 @@ function verifyUserMenuModal(menuItem) { verifyModal(menuItem); } -function verifyModal(menuItem, modalName) { +function verifyModal(menuItem: string, modalName?: string) { // * Verify that menu is open cy.findByRole('menu'); diff --git a/e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_spec.js b/e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_spec.ts similarity index 95% rename from e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_spec.js rename to e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_spec.ts index 6f5d89aa5c..a3ec143980 100644 --- a/e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_spec.js +++ b/e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_spec.ts @@ -10,13 +10,16 @@ // Stage: @prod // Group: @channels @enterprise @accessibility +import {Channel} from '@mattermost/types/channels'; +import {Team} from '@mattermost/types/teams'; +import {UserProfile} from '@mattermost/types/users'; import * as TIMEOUTS from '../../../../fixtures/timeouts'; describe('Verify Accessibility Support in Modals & Dialogs', () => { - let testTeam; - let testChannel; - let testUser; - let selectedRowText; + let testTeam: Team; + let testChannel: Channel; + let testUser: UserProfile; + let selectedRowText: string; before(() => { // * Check if server has license for Guest Accounts @@ -46,8 +49,8 @@ describe('Verify Accessibility Support in Modals & Dialogs', () => { cy.uiAddDirectMessage().click(); // * Verify the accessibility support in Direct Messages Dialog - cy.findAllByRole('dialog', 'Direct Messages').eq(0).within(() => { - cy.findByRole('heading', 'Direct Messages'); + cy.findAllByRole('dialog', {name: 'Direct Messages'}).eq(0).within(() => { + cy.findByRole('heading', {name: 'Direct Messages'}); // * Verify the accessibility support in search input cy.findByRole('textbox', {name: 'Search for people'}).