Space out plugin list in mmctl (#25986)

* Space out plugin list in mmctl

* Fix test

* Fix test part 2
This commit is contained in:
Ben Schumacher 2024-01-31 13:48:00 +01:00 committed by GitHub
parent ed82ca8d11
commit d9200ab5e9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 6 deletions

View File

@ -187,6 +187,7 @@ func pluginListCmdF(c client.Client, cmd *cobra.Command, args []string) error {
printer.PrintT("{{.Manifest.Id}}: {{.Manifest.Name}}, Version: {{.Manifest.Version}}", plugin)
}
printer.Print("")
printer.Print("Listing disabled plugins")
for _, plugin := range pluginsResp.Inactive {
printer.PrintT("{{.Manifest.Id}}: {{.Manifest.Name}}, Version: {{.Manifest.Version}}", plugin)

View File

@ -431,16 +431,17 @@ func (s *MmctlUnitTestSuite) TestPluginListCmd() {
err := pluginListCmdF(s.client, &cobra.Command{}, nil)
s.Require().NoError(err)
s.Require().Len(printer.GetErrorLines(), 0)
s.Require().Len(printer.GetLines(), 8)
s.Require().Len(printer.GetLines(), 9)
s.Require().Equal("Listing enabled plugins", printer.GetLines()[0])
for i, plugin := range mockList.Active {
s.Require().Equal(plugin, printer.GetLines()[i+1])
}
s.Require().Equal("Listing disabled plugins", printer.GetLines()[4])
s.Require().Equal("", printer.GetLines()[4])
s.Require().Equal("Listing disabled plugins", printer.GetLines()[5])
for i, plugin := range mockList.Inactive {
s.Require().Equal(plugin, printer.GetLines()[i+5])
s.Require().Equal(plugin, printer.GetLines()[i+6])
}
})
@ -506,16 +507,17 @@ func (s *MmctlUnitTestSuite) TestPluginListCmd() {
err := pluginListCmdF(s.client, &cobra.Command{}, nil)
s.Require().NoError(err)
s.Require().Len(printer.GetErrorLines(), 0)
s.Require().Len(printer.GetLines(), 8)
s.Require().Len(printer.GetLines(), 9)
s.Require().Equal("Listing enabled plugins", printer.GetLines()[0])
for i, plugin := range mockList.Active {
s.Require().Equal(plugin.Id+": "+plugin.Name+", Version: "+plugin.Version, printer.GetLines()[i+1])
}
s.Require().Equal("Listing disabled plugins", printer.GetLines()[4])
s.Require().Equal("", printer.GetLines()[4])
s.Require().Equal("Listing disabled plugins", printer.GetLines()[5])
for i, plugin := range mockList.Inactive {
s.Require().Equal(plugin.Id+": "+plugin.Name+", Version: "+plugin.Version, printer.GetLines()[i+5])
s.Require().Equal(plugin.Id+": "+plugin.Name+", Version: "+plugin.Version, printer.GetLines()[i+6])
}
})