MM-27512: Use an authenticated user to bump up request rate limit (#15251)

* MM-27512: Use an authenticated user to bump up request rate limit

An unauthenticated user can only make 60 requests per hour which means 1
request every minute. This can lead to frequent rate limit errors while
getting the latest release.

We change that to use an authenticated user which is already available
in the CI. This moves us to make 5000 requests per hour.

We also add additional logging in the Makefile targets in case
the command fails again so that it's clear what has happened, and not return
cryptic 404 errors again.

Ideally, we should be able to inspect the output of the curl command, but since
the output value of the entire bash script is fed into the variable, it is a bit
difficult to print debug output.

If this still gives error, then we need to either use a cached artifact somehow
or add additional logging and add a retry logic on top of it.

* fix mistake
This commit is contained in:
Agniva De Sarker
2020-08-18 19:42:12 +05:30
committed by GitHub
parent f619de2c83
commit e1ca3e348f
3 changed files with 25 additions and 4 deletions

View File

@@ -188,6 +188,10 @@ prepackaged-plugins: ## Populate the prepackaged-plugins directory
done
prepackaged-binaries: ## Populate the prepackaged-binaries to the bin directory
ifeq ($(MMCTL_REL_TO_DOWNLOAD),)
@echo "An error has occured trying to get the latest mmctl release. Aborting. Perhaps api.github.com is down?"
@exit 1
endif
# Externally built binaries
ifeq ($(shell test -f bin/mmctl && printf "yes"),yes)
@echo mmctl installed