diff --git a/app/session.go b/app/session.go index 0e4dbb7058..0900fb7068 100644 --- a/app/session.go +++ b/app/session.go @@ -327,8 +327,8 @@ func (a *App) DisableUserAccessToken(token *model.UserAccessToken) *model.AppErr var session *model.Session session, _ = a.Srv.Store.Session().Get(token.Token) - if result := <-a.Srv.Store.UserAccessToken().UpdateTokenDisable(token.Id); result.Err != nil { - return result.Err + if err := a.Srv.Store.UserAccessToken().UpdateTokenDisable(token.Id); err != nil { + return err } if session == nil { diff --git a/store/sqlstore/user_access_token_store.go b/store/sqlstore/user_access_token_store.go index d37896a1a1..679be8f2e0 100644 --- a/store/sqlstore/user_access_token_store.go +++ b/store/sqlstore/user_access_token_store.go @@ -222,30 +222,24 @@ func (s SqlUserAccessTokenStore) UpdateTokenEnable(tokenId string) store.StoreCh }) } -func (s SqlUserAccessTokenStore) UpdateTokenDisable(tokenId string) store.StoreChannel { - return store.Do(func(result *store.StoreResult) { - transaction, err := s.GetMaster().Begin() - if err != nil { - result.Err = model.NewAppError("SqlUserAccessTokenStore.UpdateTokenDisable", "store.sql_user_access_token.update_token_disable.app_error", nil, err.Error(), http.StatusInternalServerError) - } else { - defer finalizeTransaction(transaction) - if extrasResult := s.deleteSessionsAndDisableToken(transaction, tokenId); extrasResult.Err != nil { - *result = extrasResult - } +func (s SqlUserAccessTokenStore) UpdateTokenDisable(tokenId string) *model.AppError { + transaction, err := s.GetMaster().Begin() + if err != nil { + return model.NewAppError("SqlUserAccessTokenStore.UpdateTokenDisable", "store.sql_user_access_token.update_token_disable.app_error", nil, err.Error(), http.StatusInternalServerError) + } + defer finalizeTransaction(transaction) - if result.Err == nil { - if err := transaction.Commit(); err != nil { - // don't need to rollback here since the transaction is already closed - result.Err = model.NewAppError("SqlUserAccessTokenStore.UpdateTokenDisable", "store.sql_user_access_token.update_token_disable.app_error", nil, err.Error(), http.StatusInternalServerError) - } - } - } - }) + if err := s.deleteSessionsAndDisableToken(transaction, tokenId); err != nil { + return err + } + if err := transaction.Commit(); err != nil { + // don't need to rollback here since the transaction is already closed + return model.NewAppError("SqlUserAccessTokenStore.UpdateTokenDisable", "store.sql_user_access_token.update_token_disable.app_error", nil, err.Error(), http.StatusInternalServerError) + } + return nil } -func (s SqlUserAccessTokenStore) deleteSessionsAndDisableToken(transaction *gorp.Transaction, tokenId string) store.StoreResult { - result := store.StoreResult{} - +func (s SqlUserAccessTokenStore) deleteSessionsAndDisableToken(transaction *gorp.Transaction, tokenId string) *model.AppError { query := "" if s.DriverName() == model.DATABASE_DRIVER_POSTGRES { query = "DELETE FROM Sessions s USING UserAccessTokens o WHERE o.Token = s.Token AND o.Id = :Id" @@ -254,19 +248,16 @@ func (s SqlUserAccessTokenStore) deleteSessionsAndDisableToken(transaction *gorp } if _, err := transaction.Exec(query, map[string]interface{}{"Id": tokenId}); err != nil { - result.Err = model.NewAppError("SqlUserAccessTokenStore.deleteSessionsAndDisableToken", "store.sql_user_access_token.update_token_disable.app_error", nil, "id="+tokenId+", err="+err.Error(), http.StatusInternalServerError) - return result + return model.NewAppError("SqlUserAccessTokenStore.deleteSessionsAndDisableToken", "store.sql_user_access_token.update_token_disable.app_error", nil, "id="+tokenId+", err="+err.Error(), http.StatusInternalServerError) } return s.updateTokenDisable(transaction, tokenId) } -func (s SqlUserAccessTokenStore) updateTokenDisable(transaction *gorp.Transaction, tokenId string) store.StoreResult { - result := store.StoreResult{} - +func (s SqlUserAccessTokenStore) updateTokenDisable(transaction *gorp.Transaction, tokenId string) *model.AppError { if _, err := transaction.Exec("UPDATE UserAccessTokens SET IsActive = FALSE WHERE Id = :Id", map[string]interface{}{"Id": tokenId}); err != nil { - result.Err = model.NewAppError("SqlUserAccessTokenStore.updateTokenDisable", "store.sql_user_access_token.update_token_disable.app_error", nil, "", http.StatusInternalServerError) + return model.NewAppError("SqlUserAccessTokenStore.updateTokenDisable", "store.sql_user_access_token.update_token_disable.app_error", nil, "", http.StatusInternalServerError) } - return result + return nil } diff --git a/store/store.go b/store/store.go index a39949dbb2..2fb0d11768 100644 --- a/store/store.go +++ b/store/store.go @@ -524,7 +524,7 @@ type UserAccessTokenStore interface { GetByUser(userId string, page, perPage int) ([]*model.UserAccessToken, *model.AppError) Search(term string) StoreChannel UpdateTokenEnable(tokenId string) StoreChannel - UpdateTokenDisable(tokenId string) StoreChannel + UpdateTokenDisable(tokenId string) *model.AppError } type PluginStore interface { diff --git a/store/storetest/mocks/UserAccessTokenStore.go b/store/storetest/mocks/UserAccessTokenStore.go index d26faa4166..c3d5362b1d 100644 --- a/store/storetest/mocks/UserAccessTokenStore.go +++ b/store/storetest/mocks/UserAccessTokenStore.go @@ -187,15 +187,15 @@ func (_m *UserAccessTokenStore) Search(term string) store.StoreChannel { } // UpdateTokenDisable provides a mock function with given fields: tokenId -func (_m *UserAccessTokenStore) UpdateTokenDisable(tokenId string) store.StoreChannel { +func (_m *UserAccessTokenStore) UpdateTokenDisable(tokenId string) *model.AppError { ret := _m.Called(tokenId) - var r0 store.StoreChannel - if rf, ok := ret.Get(0).(func(string) store.StoreChannel); ok { + var r0 *model.AppError + if rf, ok := ret.Get(0).(func(string) *model.AppError); ok { r0 = rf(tokenId) } else { if ret.Get(0) != nil { - r0 = ret.Get(0).(store.StoreChannel) + r0 = ret.Get(0).(*model.AppError) } } diff --git a/store/storetest/user_access_token_store.go b/store/storetest/user_access_token_store.go index ed54cd7b42..4429edee55 100644 --- a/store/storetest/user_access_token_store.go +++ b/store/storetest/user_access_token_store.go @@ -117,7 +117,7 @@ func testUserAccessTokenDisableEnable(t *testing.T, ss store.Store) { t.Fatal(err) } - if err = (<-ss.UserAccessToken().UpdateTokenDisable(uat.Id)).Err; err != nil { + if err = ss.UserAccessToken().UpdateTokenDisable(uat.Id); err != nil { t.Fatal(err) }