From e41ab1a3b8a89df602aba981acb83ab10d5b1093 Mon Sep 17 00:00:00 2001 From: Rohan Sharma <117426013+RS-labhub@users.noreply.github.com> Date: Wed, 9 Oct 2024 18:26:22 +0530 Subject: [PATCH] fix: plugin errcheck issues (#28517) Co-authored-by: Ben Schumacher --- server/.golangci.yml | 1 - server/channels/api4/plugin.go | 8 ++++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index 2f11550531..4ce0f954c8 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -81,7 +81,6 @@ issues: channels/api4/license.go|\ channels/api4/license_local.go|\ channels/api4/oauth_test.go|\ - channels/api4/plugin.go|\ channels/api4/post_test.go|\ channels/api4/preference_test.go|\ channels/api4/reaction_test.go|\ diff --git a/server/channels/api4/plugin.go b/server/channels/api4/plugin.go index 972fe46f06..f5d4374fb8 100644 --- a/server/channels/api4/plugin.go +++ b/server/channels/api4/plugin.go @@ -276,7 +276,9 @@ func getWebappPlugins(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(js) + if _, err := w.Write(js); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } } func getMarketplacePlugins(c *Context, w http.ResponseWriter, r *http.Request) { @@ -314,7 +316,9 @@ func getMarketplacePlugins(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(json) + if _, err := w.Write(json); err != nil { + c.Logger.Warn("Error while writing json response", mlog.Err(err)) + } } func enablePlugin(c *Context, w http.ResponseWriter, r *http.Request) {