IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

MM-52834 : Migrate "components/admin_console/dropdown_setting.jsx" and tests to Typescript (#23533)

Browse Source
This commit is contained in:
Ujwal Kumar
2023-06-27 10:21:26 +05:30
committed by GitHub
parent 7efbb11fae
commit e84eb900ff
4 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
webapp/channels/src/components/admin_console/dropdown_setting.jsx → webapp/channels/src/components/admin_console/dropdown_setting.tsx
View File

@@ -2,11 +2,23 @@
// See LICENSE.txt for license information.
import PropTypes from 'prop-types';
import React from 'react';
import React, {PureComponent, ReactNode, ChangeEvent} from 'react';
import Setting from './setting';
import {EmailSettings} from '@mattermost/types/config';
export default class DropdownSetting extends React.PureComponent {
type Props = {
id: string;
values: Array<{text: string; value: string}>;
label: ReactNode;
value: string;
onChange: (id: string, value: string | EmailSettings['PushNotificationServerType'] | EmailSettings['PushNotificationServerLocation']) => void;
disabled?: boolean;
setByEnv: boolean;
helpText?: ReactNode;
}
export default class DropdownSetting extends PureComponent<Props> {
static propTypes = {
id: PropTypes.string.isRequired,
values: PropTypes.array.isRequired,
@@ -22,7 +34,7 @@ export default class DropdownSetting extends React.PureComponent {
isDisabled: false,
};
handleChange = (e) => {
handleChange = (e: ChangeEvent<HTMLSelectElement>) => {
this.props.onChange(this.props.id, e.target.value);
};

2
webapp/channels/src/components/admin_console/message_export_settings.jsx
View File

@@ -14,7 +14,7 @@ import ExternalLink from 'components/external_link';
import AdminSettings from './admin_settings';
import BooleanSetting from './boolean_setting';
import DropdownSetting from './dropdown_setting.jsx';
import DropdownSetting from './dropdown_setting';
import JobsTable from './jobs';
import SettingsGroup from './settings_group';
import TextSetting from './text_setting';

4
webapp/channels/src/components/admin_console/push_settings.tsx
View File

@@ -10,7 +10,7 @@ import {Constants, DocLinks} from 'utils/constants';
import * as Utils from 'utils/utils';
import AdminSettings, {BaseProps, BaseState} from './admin_settings';
import DropdownSetting from './dropdown_setting.jsx';
import DropdownSetting from './dropdown_setting';
import SettingsGroup from './settings_group';
import TextSetting from './text_setting';
import {AdminConfig, ClientLicense, EmailSettings} from '@mattermost/types/config';
@@ -54,7 +54,7 @@ export default class PushSettings extends AdminSettings<Props, State> {
});
};
handleDropdownChange = (id: string, value: EmailSettings['PushNotificationServerType'] | EmailSettings['PushNotificationServerLocation']) => {
handleDropdownChange = (id: string, value: string) => {
if (id === DROPDOWN_ID_SERVER_TYPE) {
this.setState({
agree: false,

2
webapp/channels/src/components/admin_console/schema_admin_settings.jsx
View File

@@ -16,7 +16,7 @@ import * as Utils from 'utils/utils';
import RequestButton from 'components/admin_console/request_button/request_button';
import BooleanSetting from 'components/admin_console/boolean_setting';
import TextSetting from 'components/admin_console/text_setting';
import DropdownSetting from 'components/admin_console/dropdown_setting.jsx';
import DropdownSetting from 'components/admin_console/dropdown_setting';
import MultiSelectSetting from 'components/admin_console/multiselect_settings';
import RadioSetting from 'components/admin_console/radio_setting';
import ColorSetting from 'components/admin_console/color_setting';