IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

PLT-5455 Added caching for OG metadata of link preview. (#5361)

Browse Source
This commit is contained in:
Debanshu Kundu
2017-02-12 22:01:49 +05:30
committed by Joram Wilander
parent 37222ec1b3
commit eab15da321
2 changed files with 43 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
api/post.go
View File

@@ -14,6 +14,10 @@ import (
"github.com/mattermost/platform/utils"
)
const OPEN_GRAPH_METADATA_CACHE_SIZE = 10000
var openGraphDataCache = utils.NewLru(OPEN_GRAPH_METADATA_CACHE_SIZE)
func InitPost() {
l4g.Debug(utils.T("api.post.init.debug"))
@@ -432,8 +436,14 @@ func getFileInfosForPost(c *Context, w http.ResponseWriter, r *http.Request) {
func getOpenGraphMetadata(c *Context, w http.ResponseWriter, r *http.Request) {
props := model.StringInterfaceFromJson(r.Body)
ogJSONGeneric, ok := openGraphDataCache.Get(props["url"])
if ok {
w.Write(ogJSONGeneric.([]byte))
return
}
url := ""
ok := false
ok = false
if url, ok = props["url"].(string); len(url) == 0 || !ok {
c.SetInvalidParam("getOpenGraphMetadata", "url")
return
@@ -441,10 +451,12 @@ func getOpenGraphMetadata(c *Context, w http.ResponseWriter, r *http.Request) {
og := app.GetOpenGraphMetadata(url)
ogJson, err := og.ToJSON()
ogJSON, err := og.ToJSON()
if err != nil {
w.Write([]byte(`{"url": ""}`))
return
}
w.Write(ogJson)
openGraphDataCache.AddWithExpiresInSecs(props["url"], ogJSON, 3600) // Cache would expire after 1 houre
w.Write(ogJSON)
}

32
api/post_test.go
View File

@@ -1306,7 +1306,11 @@ func TestGetOpenGraphMetadata(t *testing.T) {
th := Setup().InitBasic()
Client := th.BasicClient
ogDataCacheMissCount := 0
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
ogDataCacheMissCount++
if r.URL.Path == "/og-data/" {
fmt.Fprintln(w, `
<html><head><meta property="og:type" content="article" />
@@ -1319,15 +1323,35 @@ func TestGetOpenGraphMetadata(t *testing.T) {
}
}))
for _, data := range [](map[string]string){{"path": "/og-data/", "title": "Test Title"}, {"path": "/no-og-data/", "title": ""}} {
res, err := Client.DoApiPost("/get_opengraph_metadata", fmt.Sprintf("{\"url\":\"%s\"}", ts.URL+data["path"]))
for _, data := range [](map[string]interface{}){
{"path": "/og-data/", "title": "Test Title", "cacheMissCount": 1},
{"path": "/no-og-data/", "title": "", "cacheMissCount": 2},
// Data should be cached for following
{"path": "/og-data/", "title": "Test Title", "cacheMissCount": 2},
{"path": "/no-og-data/", "title": "", "cacheMissCount": 2},
} {
res, err := Client.DoApiPost(
"/get_opengraph_metadata",
fmt.Sprintf("{\"url\":\"%s\"}", ts.URL+data["path"].(string)),
)
if err != nil {
t.Fatal(err)
}
ogData := model.StringInterfaceFromJson(res.Body)
if strings.Compare(ogData["title"].(string), data["title"]) != 0 {
t.Fatal(fmt.Sprintf("OG data title mismatch for path \"%s\". Expected title: \"%s\". Actual title: \"%s\"", data["path"], data["title"], ogData["title"]))
if strings.Compare(ogData["title"].(string), data["title"].(string)) != 0 {
t.Fatal(fmt.Sprintf(
"OG data title mismatch for path \"%s\". Expected title: \"%s\". Actual title: \"%s\"",
data["path"].(string), data["title"].(string), ogData["title"].(string),
))
}
if ogDataCacheMissCount != data["cacheMissCount"].(int) {
t.Fatal(fmt.Sprintf(
"Cache miss count didn't match. Expected value %d. Actual value %d.",
data["cacheMissCount"].(int), ogDataCacheMissCount,
))
}
}
}