IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

[MM-61652]: Removed unnecessary role and aria-level from channel header (#29540)

Browse Source 
* [BST-183]: Removed unnecessary role and aria-level from channel header

* [BST-183]: Fix failing E2E test case

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
This commit is contained in:
ayush-chauhan233 2024-12-19 04:08:21 +05:30 committed by GitHub
parent fd6a662d76
commit eb3862f6eb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
e2e-tests/cypress/tests/integration/playbooks/channels/rhs/about_spec.js
View File

@ -90,7 +90,7 @@ describe('channels > rhs > header', {testIsolation: true}, () => {
cy.get('#rhsContainer').findByTestId('rendered-run-name').should('be.visible').contains('new run name');
// * make sure the channel name remains unchanged
cy.get('#channelHeaderInfo').findByRole('heading').contains(playbookRunName);
cy.get('#channelHeaderInfo').contains(playbookRunName);
});
});

6
webapp/channels/src/components/channel_header/channel_header_title.tsx
View File

@ -103,8 +103,6 @@ const ChannelHeaderTitle = ({
size='sm'
/>
<strong
role='heading'
aria-level={2}
id='channelHeaderTitle'
className='heading'
>
@ -141,8 +139,6 @@ const ChannelHeaderTitle = ({
title={channelTitle as string}
>
<strong
role='heading'
aria-level={2}
id='channelHeaderTitle'
className='heading'
ref={headerItemRef}
@ -156,8 +152,6 @@ const ChannelHeaderTitle = ({
</WithTooltip>
) : (
<strong
role='heading'
aria-level={2}
id='channelHeaderTitle'
className='heading'
ref={headerItemRef}