diff --git a/app/user.go b/app/user.go index eab68c4372..c3c5ae1a0c 100644 --- a/app/user.go +++ b/app/user.go @@ -1438,8 +1438,8 @@ func (a *App) PermanentDeleteUser(user *model.User) *model.AppError { return err } - if result := <-a.Srv.Store.UserAccessToken().DeleteAllForUser(user.Id); result.Err != nil { - return result.Err + if err := a.Srv.Store.UserAccessToken().DeleteAllForUser(user.Id); err != nil { + return err } if err := a.Srv.Store.OAuth().PermanentDeleteAuthDataByUser(user.Id); err != nil { diff --git a/store/sqlstore/user_access_token_store.go b/store/sqlstore/user_access_token_store.go index 0c0f2c4665..ad95c03359 100644 --- a/store/sqlstore/user_access_token_store.go +++ b/store/sqlstore/user_access_token_store.go @@ -92,30 +92,24 @@ func (s SqlUserAccessTokenStore) deleteTokensById(transaction *gorp.Transaction, return nil } -func (s SqlUserAccessTokenStore) DeleteAllForUser(userId string) store.StoreChannel { - return store.Do(func(result *store.StoreResult) { - transaction, err := s.GetMaster().Begin() - if err != nil { - result.Err = model.NewAppError("SqlUserAccessTokenStore.DeleteAllForUser", "store.sql_user_access_token.delete.app_error", nil, err.Error(), http.StatusInternalServerError) - } else { - defer finalizeTransaction(transaction) - if extrasResult := s.deleteSessionsandTokensByUser(transaction, userId); extrasResult.Err != nil { - *result = extrasResult - } +func (s SqlUserAccessTokenStore) DeleteAllForUser(userId string) *model.AppError { + transaction, err := s.GetMaster().Begin() + if err != nil { + return model.NewAppError("SqlUserAccessTokenStore.DeleteAllForUser", "store.sql_user_access_token.delete.app_error", nil, err.Error(), http.StatusInternalServerError) + } + defer finalizeTransaction(transaction) + if err := s.deleteSessionsandTokensByUser(transaction, userId); err != nil { + return err + } - if result.Err == nil { - if err := transaction.Commit(); err != nil { - // don't need to rollback here since the transaction is already closed - result.Err = model.NewAppError("SqlUserAccessTokenStore.DeleteAllForUser", "store.sql_user_access_token.delete.app_error", nil, err.Error(), http.StatusInternalServerError) - } - } - } - }) + if err := transaction.Commit(); err != nil { + // don't need to rollback here since the transaction is already closed + return model.NewAppError("SqlUserAccessTokenStore.DeleteAllForUser", "store.sql_user_access_token.delete.app_error", nil, err.Error(), http.StatusInternalServerError) + } + return nil } -func (s SqlUserAccessTokenStore) deleteSessionsandTokensByUser(transaction *gorp.Transaction, userId string) store.StoreResult { - result := store.StoreResult{} - +func (s SqlUserAccessTokenStore) deleteSessionsandTokensByUser(transaction *gorp.Transaction, userId string) *model.AppError { query := "" if s.DriverName() == model.DATABASE_DRIVER_POSTGRES { query = "DELETE FROM Sessions s USING UserAccessTokens o WHERE o.Token = s.Token AND o.UserId = :UserId" @@ -124,21 +118,18 @@ func (s SqlUserAccessTokenStore) deleteSessionsandTokensByUser(transaction *gorp } if _, err := transaction.Exec(query, map[string]interface{}{"UserId": userId}); err != nil { - result.Err = model.NewAppError("SqlUserAccessTokenStore.deleteSessionsByUser", "store.sql_user_access_token.delete.app_error", nil, "user_id="+userId+", err="+err.Error(), http.StatusInternalServerError) - return result + return model.NewAppError("SqlUserAccessTokenStore.deleteSessionsByUser", "store.sql_user_access_token.delete.app_error", nil, "user_id="+userId+", err="+err.Error(), http.StatusInternalServerError) } return s.deleteTokensByUser(transaction, userId) } -func (s SqlUserAccessTokenStore) deleteTokensByUser(transaction *gorp.Transaction, userId string) store.StoreResult { - result := store.StoreResult{} - +func (s SqlUserAccessTokenStore) deleteTokensByUser(transaction *gorp.Transaction, userId string) *model.AppError { if _, err := transaction.Exec("DELETE FROM UserAccessTokens WHERE UserId = :UserId", map[string]interface{}{"UserId": userId}); err != nil { - result.Err = model.NewAppError("SqlUserAccessTokenStore.deleteTokensByUser", "store.sql_user_access_token.delete.app_error", nil, "", http.StatusInternalServerError) + return model.NewAppError("SqlUserAccessTokenStore.deleteTokensByUser", "store.sql_user_access_token.delete.app_error", nil, "", http.StatusInternalServerError) } - return result + return nil } func (s SqlUserAccessTokenStore) Get(tokenId string) (*model.UserAccessToken, *model.AppError) { diff --git a/store/store.go b/store/store.go index c513c51ac0..c0cada8b98 100644 --- a/store/store.go +++ b/store/store.go @@ -519,8 +519,8 @@ type JobStore interface { type UserAccessTokenStore interface { Save(token *model.UserAccessToken) (*model.UserAccessToken, *model.AppError) + DeleteAllForUser(userId string) *model.AppError Delete(tokenId string) *model.AppError - DeleteAllForUser(userId string) StoreChannel Get(tokenId string) (*model.UserAccessToken, *model.AppError) GetAll(offset int, limit int) ([]*model.UserAccessToken, *model.AppError) GetByToken(tokenString string) (*model.UserAccessToken, *model.AppError) diff --git a/store/storetest/mocks/UserAccessTokenStore.go b/store/storetest/mocks/UserAccessTokenStore.go index 1183e494f1..937cec89d9 100644 --- a/store/storetest/mocks/UserAccessTokenStore.go +++ b/store/storetest/mocks/UserAccessTokenStore.go @@ -30,15 +30,15 @@ func (_m *UserAccessTokenStore) Delete(tokenId string) *model.AppError { } // DeleteAllForUser provides a mock function with given fields: userId -func (_m *UserAccessTokenStore) DeleteAllForUser(userId string) store.StoreChannel { +func (_m *UserAccessTokenStore) DeleteAllForUser(userId string) *model.AppError { ret := _m.Called(userId) - var r0 store.StoreChannel - if rf, ok := ret.Get(0).(func(string) store.StoreChannel); ok { + var r0 *model.AppError + if rf, ok := ret.Get(0).(func(string) *model.AppError); ok { r0 = rf(userId) } else { if ret.Get(0) != nil { - r0 = ret.Get(0).(store.StoreChannel) + r0 = ret.Get(0).(*model.AppError) } } diff --git a/store/storetest/user_access_token_store.go b/store/storetest/user_access_token_store.go index 0bd803bb12..8490c1030f 100644 --- a/store/storetest/user_access_token_store.go +++ b/store/storetest/user_access_token_store.go @@ -86,8 +86,8 @@ func testUserAccessTokenSaveGetDelete(t *testing.T, ss store.Store) { t.Fatal(err) } - if result := <-ss.UserAccessToken().DeleteAllForUser(uat.UserId); result.Err != nil { - t.Fatal(result.Err) + if err := ss.UserAccessToken().DeleteAllForUser(uat.UserId); err != nil { + t.Fatal(err) } if _, err := ss.Session().Get(s2.Token); err == nil {