MM-33893: Disable TCP_NO_DELAY for websocket connections (#17129)

* MM-33893: Disable TCP_NO_DELAY for websocket connections

In very large installations, websocket messages cause too much
traffic congestion by sending too small packets and thereby cause
a drop in throughput.

To counter this, we disable the TCP_NO_DELAY flag for websocket
connections. This has shown to give noticeable improvements in
load tests.

We wrap this in a feature flag for now to let it soak in Community
first.

```release-note
NONE
```

https://mattermost.atlassian.net/browse/MM-33893

* fix gorilla specific conn
This commit is contained in:
Agniva De Sarker
2021-03-24 21:04:18 +05:30
committed by GitHub
parent 1f165799e0
commit f60b7437da
2 changed files with 15 additions and 0 deletions

View File

@@ -23,6 +23,8 @@ type FeatureFlags struct {
PluginIncidentManagement string `plugin_id:"com.mattermost.plugin-incident-management"`
// Toggle on and off support for Files search
FilesSearch bool
// Feature flag to control setting the TCP_NO_DELAY setting for websockets.
WebSocketDelay bool
}
func (f *FeatureFlags) SetDefaults() {
@@ -32,6 +34,7 @@ func (f *FeatureFlags) SetDefaults() {
f.CollapsedThreads = false
f.FilesSearch = false
f.PluginIncidentManagement = "1.6.0"
f.WebSocketDelay = false
}
func (f *FeatureFlags) Plugins() map[string]string {