IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

Sanitize user in update user response (#24362)

Browse Source
This commit is contained in:
Elias Nahum 2023-08-25 19:31:48 -04:00 committed by GitHub
parent 818225dffe
commit f787fd6336
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
server/channels/app/user.go
View File

@ -1285,6 +1285,8 @@ func (a *App) UpdateUser(c request.CTX, user *model.User, sendNotifications bool
}(user.Id)
}
newUser.Sanitize(map[string]bool{})
return newUser, nil
}

4
server/channels/app/user_test.go
View File

@ -205,6 +205,7 @@ func TestUpdateUser(t *testing.T) {
require.Nil(t, err)
require.NotNil(t, u)
require.Less(t, u.LastPictureUpdate, iLastPictureUpdate)
require.Empty(t, u.Password)
})
t.Run("fails if profile picture is updated when user has custom profile picture and username is changed", func(t *testing.T) {
@ -1731,11 +1732,12 @@ func TestPatchUser(t *testing.T) {
})
t.Run("Patch username with a new username", func(t *testing.T) {
_, err := th.App.PatchUser(th.Context, testUser.Id, &model.UserPatch{
u, err := th.App.PatchUser(th.Context, testUser.Id, &model.UserPatch{
Username: model.NewString(model.NewId()),
}, true)
require.Nil(t, err)
require.Empty(t, u.Password)
})
}