Commit Graph

19308 Commits

Author SHA1 Message Date
Pablo Vélez
88ad3bb95b
MM-60419 - fix styling regression by adding back placeholder injection link element (#28219)
* MM-60419 - fix styling regression by adding back placeholder injection link

* add relevant comment

* add more details to how the link element work

* Update webapp/channels/src/root.html

---------

Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
2024-09-24 15:28:35 +02:00
Pablo Vélez
5c7f99921b
MM-60312 - replace office365 logo with entraId new logo (#28234)
* MM-60312 - replace office365 logo with entraId new logo

* rename icon file name

* remove unncessary aria-label in svg inside a button

* remove unnecessary translation

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2024-09-24 15:27:04 +02:00
M-ZubairAhmed
df901b132e
[MM-60514] Accessing bot_accounts page directly fails to load (#28247) 2024-09-24 10:40:33 +00:00
M-ZubairAhmed
a03972e502
[MM-60303] Changing status in mobile app doesn't change your status in the webapp (#28246) 2024-09-24 10:39:26 +00:00
Daniel Espino García
040838b056
Add metrics for mobile versions snapshots (#28191)
* Add metrics for mobile versions snapshots

* Add notifications disabled and fix lint

* Address feedback

* Verify all references to JobTypeActiveUsers

* Fix typos

* Improve platform values

* Add test and MySQL support
2024-09-24 12:02:19 +02:00
Agniva De Sarker
d45a54a8e9
MM-60480: Do not invalidate channel member cache on login (#28143)
On user login, we were aggressively clearing the channel member
cache when it wasn't necessary. There is no channel membership
info that is changing on a user login.

Additionally, we fix some more issues with pointer passing
to the cache. It's a known problem that our value passing
style isn't consistent when we fetch items from cache.
Sometimes we pass pointer-to-pointer, sometimes it's just a
pointer. This is also the reason for https://github.com/mattermost/mattermost/pull/27830.

We fix 2 such cases where we passed pointer-to-pointer
but didn't handle the special case inside the cache.
This time, we actually fix it in the app layer instead
of the cache layer and also add a test for good measure.

https://mattermost.atlassian.net/browse/MM-60480

```release-note
NONE
```

Co-authored-by: Mattermost Build <build@mattermost.com>
2024-09-24 13:01:19 +05:30
Weblate (bot)
b6f83c8438
Translations update from Mattermost Weblate (#28282)
Automatic Merge
2024-09-23 16:14:32 +02:00
Pablo Vélez
b798dd8106
MM-59950 - add deletedAt column to users export (#28137) 2024-09-23 15:15:50 +02:00
Saturnino Abril
073e2cecaa
use node's native fetch, add ensureLicense flag and update snapshots (#28279) 2024-09-23 21:11:45 +08:00
Guillermo Vayá
343746c4b6
MM-59954 Community plugins telemetry (#28226)
* add known plugins to the list of possible plugins to be located

* improve testing and fix config data collection

* Improve testing

* remove empty lines

* make linter happy

* go through all plugins
2024-09-23 12:59:19 +02:00
Ben Schumacher
87ad717434
[MM-57194] Don't return config values from plugins that are not installed (#28260) 2024-09-23 10:17:07 +02:00
Mario Vitale
60b38bb91a
Enhance reporting, add shellcheck (#28240)
* Enhance reporting, add shellcheck

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2024-09-20 15:05:51 +02:00
Guillermo Vayá
dfa1d1027b
MM-60415 ignore deactivated bots (#28184)
* ignore bot accounts when counting deactivated users

* moved query to squirrel

Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>

* set is null right

* Run a different query depending on driver due to performance reasons.

---------

Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
2024-09-20 13:02:09 +02:00
Alejandro García Montoro
9b368b9214
MM58746: Bump yuin/goldmark dependency (#28250)
* Bump yuin/goldmark dependency to latest version

* Add docs to modules-tidy make rule

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2024-09-20 12:08:35 +02:00
Miguel de la Cruz
8a735f1b03
Add a specific error when inviting a remote cluster to a remote channel (#28255) 2024-09-19 14:27:41 -05:00
Mario Vitale
c27d536ad3
Checkout latest stable pgloader release (#28251)
* Checkout latest stable pgloader release
* Disable Mystql to Postgres migration check
2024-09-19 15:19:42 +02:00
Ben Schumacher
40d2ae97f1
[MM-60307] Fix racy use of session in NewWebConn (#28195) 2024-09-19 14:10:17 +02:00
Caleb Roseland
d6c11d1d26
get channel id for bookmark files in ES/OS (#28221)
Co-authored-by: Miguel de la Cruz <mgdelacroix@gmail.com>
2024-09-19 11:57:10 +02:00
Miguel de la Cruz
987a25b4d0
Adds a make target and a database for a shared channels node (#28238)
This PR allows to run a different Mattermost instance in port :8066
using the `make run-node` target. This instance reuses the frontend
files compiled for the main development instance, has its own database
and local mode enabled through environment variables, and for the rest
of the configuration simply takes whatever properties are set in the
`config.json` file.

This target is specially useful to run a Shared Channels development
environment, compiling first the frontend and then running `make
run-server` and `make run-node` side by side, later connecting both
and testing Shared Channels features.
2024-09-19 10:00:56 +02:00
Harshil Sharma
13b6e75fa9
Fixed horizontal alignment of no draft graphic (#28224)
* Fixed horizontal alignment of no draft graphic

* Lint fix
2024-09-19 12:33:11 +05:30
Agniva De Sarker
7be7a47fd3
MM-59933: Increment/Decrement the member count directly (#28196)
While using Redis, there is no need to invalidate
and then update the new count from the DB when
we know the exact number it is going to be incremented
or decremented by.

In that case, we can directly use Redis primitives
to update the cache and prevent yet another DB query.

To achieve this, we modify the LRU cache get/set
paths slightly to not marshal into byte slices
for *int64 values. This is needed for Redis to operate
the INCR/DECR commands.

https://mattermost.atlassian.net/browse/MM-59933

```release-note
NONE
```

Co-authored-by: Mattermost Build <build@mattermost.com>
2024-09-19 09:38:38 +05:30
Claudio Costa
da24e0c4da
Prepackage Calls v1.1.0 (#28220) 2024-09-18 08:20:34 -06:00
Agniva De Sarker
75ed2860ac
MM-59934: Add Redis to CI and other improvements (#28164)
- Update library version.
- Added MaxFlush delay to help reduce CPU usage.
- Fall back to LRU cache for the caches which use SCAN.
- Added mattermost-redis and running for all api layer
tests in Postgres.

https://mattermost.atlassian.net/browse/MM-59934
```release-note
NONE
```
2024-09-18 19:13:44 +05:30
Ibrahim Serdar Acikgoz
02dfc2d205
[MM-60510] .github/workflows: add a sync workflow for migration-assist (#28166) 2024-09-18 14:40:26 +02:00
Elias Nahum
bbc281d807
Add MobileExternalBrowser to client config (#28180)
* Add MobileExternalBrowser to client config

* set config MobileExternalBrowser as a pointer

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2024-09-18 19:50:07 +08:00
Miguel de la Cruz
7a0019b63a
Allow shared channel remotes endpoint to be filtered by confirmation status (#28213)
* Allow shared channel remotes endpoint to be filtered by confirmation status

* Adds tests
2024-09-18 13:36:43 +02:00
goooov
70cb1934e9
[MM-55296] Added warning in Workspace dashboard if Mattermost is running as root (#27999)
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
2024-09-18 11:51:50 +02:00
Scott Bishel
c12e6d9e9c
MM-60240 Sanitize Channels based on user permissions (#28086)
* initial commit

* add unit tests

* update tests, self review

* update tests to verify something returned.

* update app-layer

* update unit tests

* fix tests

* add check for PermissionSysconsoleReadComplianceDataRetentionPolicy

* revert package-lock

* review suggestions

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2024-09-17 15:19:03 -06:00
Caleb Roseland
d99961f106
Channel Bookmarks: adds enable, reordering, and other fixes (MM-56286, MM-59807, MM-59808, MM-60031, MM-59872) (#28098)
Co-authored-by: Mattermost Build <build@mattermost.com>
2024-09-17 11:50:34 -05:00
Ibrahim Serdar Acikgoz
075681a412
[MM-59359] imports/import_validators.go: add openid to auth_service validation (#28082) 2024-09-17 07:13:54 +02:00
Agniva De Sarker
f18323980f
MM-60413: Fix issues due to incorrect cache provider (#28181)
We were using a mock cache provider which mixed up LRU caches
with each other. This led to incorrect unmarshalling method calls.

We fix this by using the real cache provider.

https://mattermost.atlassian.net/browse/MM-60413

```release-note
NONE
```
2024-09-17 09:37:54 +05:30
Julien Tant
1909206e16
[MM-59069] Make sure OTP are actual One Time Password (#28074)
Automatic Merge
2024-09-17 00:44:32 +02:00
Alejandro García Montoro
d1ecea4c84
Update /api/v4/cluster/status docs (#28189)
Co-authored-by: Mattermost Build <build@mattermost.com>
2024-09-16 17:51:51 +02:00
Scott Bishel
d1960daa20
update icon color to system color (#28190) 2024-09-16 17:38:39 +02:00
Ibrahim Serdar Acikgoz
ba2bdba6bc
server/Makefile: add metrics-plugin to the prepackaged plugins (#28134) 2024-09-16 16:44:12 +02:00
Weblate (bot)
35079452c8
Translations update from Mattermost Weblate (#28198)
Automatic Merge
2024-09-16 16:14:33 +02:00
Ibrahim Serdar Acikgoz
c7ae41b635
[MM-60278] app/config.go: add a nil check for a required field (#28064)
* app/config.go: add a nil check for a required field

* Apply suggestions from code review

Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>

---------

Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
2024-09-16 15:24:01 +02:00
armmanvaillancourt
73b14b417e
Improve E2E tests README for readability (#27884) 2024-09-16 15:02:46 +02:00
Vishal
3acceeefb2
quote names when using recent mention search (#28119) 2024-09-16 13:58:51 +05:30
Miguel de la Cruz
d2c69fbf95
Changes the event to send when a channel is shared or unshared (#28183)
* Changes the event to send when a channel is shared or unshared

Before we were sending the CHANNEL_CONVERTED websockets event, which
is intended to notify of a public channel being converted into a
private one, so the interface was showing the channel as private until
the client was refreshed.

Now a full channel update event is sent when the channel is shared or
unshared, so the interface gets the new information correctly.

* Fix message type on command tests
2024-09-13 21:40:02 +00:00
Miguel de la Cruz
cae456de2d
Adds includeDeleted flag to get remote cluster app and store methods (#28182) 2024-09-13 23:08:53 +02:00
Scott Bishel
46ca7747f8
set object to accept function, prevent javascript error (#28192) 2024-09-13 14:21:56 -06:00
TheInvincible
190d4c48b4
MM-56994 Used false as default for useMilitaryTime (#28128)
* used false as default for useMilitaryTime

* added test for user time-format preference
2024-09-13 13:43:54 -04:00
Nick Misasi
6cece9faa6
Update download app link in Cloud welcome email (#28123) 2024-09-13 10:53:29 -04:00
Harshil Sharma
a0a6c48773
FIxed scrolling issue on drafts (#28187) 2024-09-13 19:22:04 +05:30
Miguel de la Cruz
f41d54b336
Allows invites to be sent to offline remotes (#28176)
* Allows invites to be sent to offline remotes

Invites sent to remotes marked as offline will be stored as pending,
and when the remote comes back online, it will process the invites as
part of the synchronization process.

* Update condition name for excluding confirmed invites
2024-09-13 10:54:51 +02:00
Miguel de la Cruz
d879927876
Skip racy subtest from TestUpdateChannelBookmarkSortOrder (#28155) 2024-09-13 14:51:19 +08:00
Miguel de la Cruz
d1ae710d45
Adds a ConnectedWorkspaces.MaxPostsPerSync configuration property (#28154)
* Adds a ConnectedWorkspaces.MaxPostsPerSync configuration property

* Fix linter
2024-09-12 20:40:44 +02:00
Scott Bishel
d1557271f1
Remove lock from shared channels indicator (#28132)
* remove lock from shared channels indicator

* remove import

* remove channelType

* remove channel type after merging

* update snapshot

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2024-09-12 11:26:27 -06:00
Ben Schumacher
70fe2abea6
[MM-57194] Allow plugins to mark setting fields as secret (#27986)
Co-authored-by: Claudio Costa <cstcld91@gmail.com>
2024-09-12 19:23:57 +02:00