Commit Graph

17344 Commits

Author SHA1 Message Date
M-ZubairAhmed
cc6de45bde
Removed unneeded optional prop 'type' from 'admin_console/password_settings' (#24004) 2023-07-12 22:42:53 +05:30
Ibrahim Serdar Acikgoz
51c6e77972
[MM-53407] server/user_store: avoid antijoin for AnalyticsActiveCount query (#23993) 2023-07-12 17:40:34 +03:00
Devin Binnie
abdf4e58c3
[MM-37984] Allow Desktop App to authenticate via external providers outside of the app on supported servers (#23795)
* WIP

* Add rate limiting for desktop token API

* Missing mocks

* Style fixes

* Update snapshots

* Maybe use an actual redirect link :P

* Refactoring for tests

* Add tests for server

* Fix lint issue

* Fix tests

* Fix lint

* Add front-end screen component

* Component logic

* Style changes

* Quick style fix

* Lint fixes

* Initial PR feedback

* Enable logging into the browser as well when completing the login process

* Refactor to push more logic to the other component

* Remove unnecessary helper code

* Fix i18n

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-07-12 09:25:05 -04:00
M-ZubairAhmed
5e3c03a0a8
Fix component types of 'components/widgets/settings/text_setting.tsx' (#23919) 2023-07-12 16:25:05 +05:30
Antonis Stamatiou
98da282f7c
fix: Add e2e-tests paths for tests trigger (#23894) 2023-07-12 10:52:05 +03:00
Christopher Poile
46a659e06d
MM-53340 - Create registerDesktopNotificationHook for plugins, e.g. Calls (#23884)
* calls will notify in GM/DM channels for call started posts

* fix types

* add registerDesktopNotificationHook

* remove callsWillNotify

* cleanup unused types

* use an args object to shorten params

* add CUSTOM_CALLS_RECORDING to constants
2023-07-11 22:46:59 -04:00
Scott Bishel
f45f774ece
update for guest demotion and sysadmin edits (#23920)
* update for guest demotion and sysadmin edits

* update unit test

* update unit test

* use existing disabled flag

* remove commented line

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-07-11 16:10:44 -06:00
Harrison Healey
2672af30ea
MM-53467 Unrevert changes that update current user object (#23928)
* Revert "Revert "[MM-52547] Include current user profile in every redux action (#23219)""

This reverts commit 8f96888b1a.

* Revert "Revert "[MM-52546] webapp/channels : Update current user and status on WebSocket reconnect (#23071)""

This reverts commit 69ee162a6e.

* MM-53647 Fix overwriting the current user with sanitized data
2023-07-11 09:51:02 -07:00
Devin Binnie
116728424c
[MM-53124] Add optional Forgot Password custom link to override the default flow on the login page (#23831)
* [MM-53124] Add optional Forgot Password custom link to override the default flow on the login page

* Fix i18n

* Fix test

* Added the enable/disable flag

* Fix test

* Fix e2e

* Add blockable link for the Customization navigation
2023-07-11 09:04:39 -04:00
Harrison Healey
b59cba7e63
Re-add package target to web app Makefile (#23960) 2023-07-11 11:58:29 +05:30
Scott Bishel
30140c0a27
MM-53098 Fix for checking bot and user permissions on shared endpoints (#23751)
* temp commit

* update test to allow bot creation

* add bot check to updateUser and deleteUser

* add more unit tests

* lint fixes

* lint fix

* update based on doc

* add more unit tests

* lint fixes

* fix unit tests

* fix unit tests

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-07-10 13:28:40 -06:00
Devin Binnie
2abcdfe76a
[MM-53430] Don't stop the isDraftSubmitting flow when the notification modal is popped (#23962)
* [MM-53430] Don't stop the `isDraftSubmitting` flow when the notification modal is popped

* Reset to false if the modal closes without confirming
2023-07-10 08:33:32 -04:00
Agniva De Sarker
da3d5c73fe
MM-53406: Fix userstore.count to avoid antijoin (#23953)
For MySQL, a query for type LEFT JOIN .. IS NULL
leads to a nested antijoin which leads to poor performance.

We fix this by rewriting the query to avoid the antijoin.

See the JIRA epic for more context behind this.

We also make another improvement to remove the DISTINCT
clause. It didn't serve any purpose since userids would
already be unique.

https://mattermost.atlassian.net/browse/MM-53406

```release-note
NONE
```
2023-07-10 10:19:44 +05:30
Agniva De Sarker
49e1d039f5
Reduce number of calls to IsCRTEnabled (#23963)
In a single createPost flow, there were
3 separate calls to App.IsCRTEnabled. This
showed up very slightly in the CPU profiles.

Not a big deal, but good to get it out of
the way.

```release-note
NONE
```
2023-07-10 10:18:55 +05:30
Christopher Poile
b5a3eee739
calls -> v0.17.0 (#23975) 2023-07-09 20:41:45 -06:00
Maria A Nunez
62c83863a2
Remove bold markdown in translations strings (#23922)
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-07-09 21:59:36 -04:00
Maria A Nunez
96d3e5864f
Removed Post Priority feature flag (#23735)
* Removed post priority feature flag

* linting

* Update feature_flags.go
2023-07-07 11:42:57 -04:00
Maria A Nunez
3f126905c5
Fix icon for private channels in channel suggestion list (#23921) 2023-07-07 10:54:01 -04:00
Jesse Hallam
dd4f71b2b6
add Apache 2.0 license to public submodule (#23945) 2023-07-07 10:56:42 -03:00
notlelouch
c59c2eafe3
MM-47275 : Migrate 'header_footer_template_route.jsx' to TypeScript (#23791)
* header_footer_template_route.jsx to tsx

* extended Props to RouteProps

* removed Component checks

* changed "ComponentType<RouteComponentProps>" to "ComponentType<any>"

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-07-06 16:41:01 -04:00
Jesse Hallam
82b3b67e63
secrets: inherit, to fix flaky tests report (#23961) 2023-07-06 14:03:14 -03:00
Saturnino Abril
44a95d9f69
chore: add @plugins_uninstall metadata to sort it last during test (#23926) 2023-07-05 18:17:55 -04:00
Scott Bishel
739fc8edf1
links now add utm_ data added cannot do exact match (#23885)
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-07-05 15:09:22 -06:00
Harrison Healey
f7e87bfe29
MM-53377 Revert "[MM-52547] Include current user profile in every redux action (#23219)" (#23912)
* Revert "[MM-52547] Include current user profile in every redux action (#23219)"

This reverts commit a85c0b87b8.

* Revert "[MM-52546] webapp/channels : Update current user and status on WebSocket reconnect (#23071)"

This reverts commit 6d3354266a.
2023-07-05 16:43:51 -04:00
Hideaki Matsunami
3f7efe2df8
types: Add 'id' to AppExpandLevel (#23813)
Added properties that were omitted from the implementation.
ref: https://github.com/mattermost/mattermost/issues/23512

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-07-05 16:43:04 -04:00
Maria A Nunez
5779bd49d5
Remove Global Drafts Feature Flag (#23767)
* Remove global draft feature flag

* More removal - in progress

* Removed the rest in webapp

* Removed the rest in webapp

* Fix tests

* Update feature_flags.go

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-07-05 12:18:30 -04:00
Ben Cooke
bf0e0ed45a
[MM-53466] Remove concurrency from data retention delete batching (#23927)
* Add TimeBetweenBatches config value for data retention

* adding feature flag for data retention concurrency
---------

Co-authored-by: Julien Tant <julien@craftyx.fr>
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-07-05 11:09:03 -04:00
Agniva De Sarker
15eac83923
MM-52646: Fix data race on product notices (#23910)
The UpdateProductNotices method runs in a separate goroutine
which modifies a global structure called noticesCache.
This creates race condition when one test finishes
but the goroutine hasn't finished running.

To fix this, we simply prevent the spawning of the goroutine
by disabling the feature in the config.

Ideally, we'd not have global state in the first place.
But that's a separate matter.

https://mattermost.atlassian.net/browse/MM-52646

```release-note
NONE
```
2023-07-05 20:36:14 +05:30
Harshal sanghvi
fcb322b8f2
MM-52827, MM-52840 : Migrate "components/admin_console/session_length_settings.jsx" & "components/admin_console/cluster_table_container.jsx" to Typescript (#23509) 2023-07-05 19:50:41 +05:30
Hamza
2bb6830242
MM-52082 : Emoji Picker doesn't appear when clicking on Add Reaction from post menu in mobile view (#23174) 2023-07-05 19:45:12 +05:30
M-ZubairAhmed
b153a39d3e
[MM-53127] e2e-tests : Drafts badge doesn't clear when parent message deleted and removed (#23705) 2023-07-05 17:13:55 +05:30
Agniva De Sarker
33565dc118
MM-52168: Bump dependencies (#23917)
https://mattermost.atlassian.net/browse/MM-52168

```release-note
NONE
```
2023-07-05 09:08:36 +05:30
Sai Deepesh
70d0a0fe70
[MM-47090]: Migrate "components/integrations/abstract_command.jsx" to Typescript (#23325) 2023-07-02 12:25:10 +05:30
Jesse Hallam
8abc8ed65c
MM-53358: Revert Threads Everywhere (#23882)
Remove changes related to the unshipped threads everywhere feature, including commits b8da473da7 and 9f9e19e05d.

Since a version of Playbooks shipped calling this experimental API, keep a `nil` implementation to avoid breaking compatibility. We remove the hooks altogether, but keep the numbering again to avoid breaking compatbility.

Fixes: https://mattermost.atlassian.net/browse/MM-53358
2023-06-30 15:31:25 -03:00
Jesse Hallam
c506e01a97
server: automatically retry CI testing failures (#23820)
* server: --rerun-fails=3 for test-server(-race)?

* --rerun-fails=3 for IS_CI=true and -race as well
2023-06-30 15:00:37 -03:00
Agniva De Sarker
d9a28c1244
MM-52532: Fix golangci warnings for public module (#23918)
https://mattermost.atlassian.net/browse/MM-52532

```release-note
NONE
```
2023-06-30 20:12:56 +05:30
Scott Bishel
d74ee1a3da
don't allow deletedAt to be set when creating user (#23914) 2023-06-30 10:10:10 -04:00
Daniel Espino García
fda5dd8468
Remove guest badge (#23825)
* Remove guest badge

* Address feedback

* Fix lint, test and i18n

* Fix test
2023-06-30 11:06:18 +02:00
Harshil Sharma
05cd245e97
Fixed a bug that prevent post deletion (#23908)
* Fixed a bug that prevent post deletion

* lint fix:
2023-06-30 10:29:27 +05:30
Agniva De Sarker
29466bd33a
MM-53452: Skipping some flaky tests (#23911)
https://mattermost.atlassian.net/browse/MM-53452

```release-note
NONE
```
2023-06-29 22:23:46 +05:30
Jesse Hallam
53731f95ff
Pre-package Playbooks v1.37.0 (#23880) 2023-06-29 10:49:48 -03:00
ridker
292117d824
[MM-47081] Migrated "components/searcheable_channel_list_test.jsx" to TypeScript (#23886)
* Converted searcheable_list_test to TypeScript

* Reverted mock data for channels props. Resolved minor formatting issues

* Updated snapshot for searcheable_channel_list test file

* Removed obsolete snapshot of searchable_channel_list.test.jsx as searchable_channel_list.test has been converted to TypeScript
2023-06-29 09:25:42 -04:00
Miguel de la Cruz
4b1a37137d
Disable skipping SendNotifyAdminPosts test (#23874) 2023-06-29 13:23:35 +02:00
Sinan Sonmez (Chaush)
385bf19972
Update testlibrary helper.go to reflect Monorepo (#23848) 2023-06-29 11:32:25 +03:00
Ben Schumacher
c6916c7047
Bump Apps plugin version to 1.2.2 (#23622) 2023-06-29 09:26:33 +02:00
Doug Lauder
9d6d8cceec
Fix mismatched receiver name on method PostMetadata.Auditable (#23904) 2023-06-28 15:31:51 -04:00
Amy Blais
3d7af2fb55
Update NOTICE.txt (#23857) 2023-06-28 14:59:07 -04:00
Harrison Healey
e8353d2982
Ensure components tests run on CI and remove obsolete snapshot (#23878)
* Ensure components tests run on CI and remove obsolete snapshot

* Add missing snapshots
2023-06-28 14:58:23 -04:00
Jesse Hallam
9588e08a00
enable redux-devtools in all environments (#23867)
* enable redux-devools in all environments

[Redux DevTools](https://github.com/reduxjs/redux-devtools) gives developers and users insight into the client-side state of the Mattermost application. Instead of restricting this to developer builds, allow it for production builds too, simplifyin debugging when an issue reproduces in production but not in a development environment.

There is no performance overhead unless the devtools are installed and opened by the enduser. There is should be no security impact, since all this information is already client-side. Furthermore, major websites expose Redux in production: e.g. https://cbc.ca and https://medium.com/.

* preserve window.store for all environments, not as a supported API
2023-06-28 14:41:32 -04:00
Miguel de la Cruz
dcb9fb9f29
Set license for group mentions flaky test (#23873) 2023-06-28 10:51:32 +02:00