mirror of
https://github.com/mattermost/mattermost.git
synced 2025-02-25 18:55:24 -06:00
efaa6264cc
It was a good decision in hindsight to keep the public module as 0.x because this would have been a breaking change again. https://mattermost.atlassian.net/browse/MM-53032 ```release-note Changed the Go module path from github.com/mattermost/mattermost-server/server/v8 to github.com/mattermost/mattermost/server/v8. For the public facing module, it's path is also changed from github.com/mattermost/mattermost-server/server/public to github.com/mattermost/mattermost/server/public ```
390 lines
12 KiB
Go
390 lines
12 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/v8/channels/utils/testutils"
|
|
)
|
|
|
|
func TestGetDraft(t *testing.T) {
|
|
os.Setenv("MM_FEATUREFLAGS_GLOBALDRAFTS", "true")
|
|
defer os.Unsetenv("MM_FEATUREFLAGS_GLOBALDRAFTS")
|
|
os.Setenv("MM_SERVICESETTINGS_ALLOWSYNCEDDRAFTS", "true")
|
|
defer os.Unsetenv("MM_SERVICESETTINGS_ALLOWSYNCEDDRAFTS")
|
|
|
|
th := Setup(t).InitBasic()
|
|
defer th.TearDown()
|
|
|
|
th.Server.platform.SetConfigReadOnlyFF(false)
|
|
defer th.Server.platform.SetConfigReadOnlyFF(true)
|
|
|
|
th.App.UpdateConfig(func(cfg *model.Config) { cfg.FeatureFlags.GlobalDrafts = true })
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.AllowSyncedDrafts = true })
|
|
|
|
user := th.BasicUser
|
|
channel := th.BasicChannel
|
|
|
|
draft := &model.Draft{
|
|
CreateAt: 00001,
|
|
UpdateAt: 00001,
|
|
UserId: user.Id,
|
|
ChannelId: channel.Id,
|
|
Message: "draft",
|
|
}
|
|
|
|
_, upsertDraftErr := th.App.UpsertDraft(th.Context, draft, "")
|
|
assert.Nil(t, upsertDraftErr)
|
|
|
|
t.Run("get draft", func(t *testing.T) {
|
|
draftResp, err := th.App.GetDraft(user.Id, channel.Id, "")
|
|
assert.Nil(t, err)
|
|
|
|
assert.Equal(t, draft.Message, draftResp.Message)
|
|
assert.Equal(t, draft.ChannelId, draftResp.ChannelId)
|
|
})
|
|
|
|
t.Run("get draft feature flag", func(t *testing.T) {
|
|
os.Setenv("MM_FEATUREFLAGS_GLOBALDRAFTS", "false")
|
|
defer os.Unsetenv("MM_FEATUREFLAGS_GLOBALDRAFTS")
|
|
os.Setenv("MM_SERVICESETTINGS_ALLOWSYNCEDDRAFTS", "false")
|
|
defer os.Unsetenv("MM_SERVICESETTINGS_ALLOWSYNCEDDRAFTS")
|
|
|
|
th.App.UpdateConfig(func(cfg *model.Config) { cfg.FeatureFlags.GlobalDrafts = false })
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.AllowSyncedDrafts = false })
|
|
|
|
defer th.App.UpdateConfig(func(cfg *model.Config) { cfg.FeatureFlags.GlobalDrafts = true })
|
|
defer th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.AllowSyncedDrafts = true })
|
|
|
|
_, err := th.App.GetDraft(user.Id, channel.Id, "")
|
|
assert.NotNil(t, err)
|
|
})
|
|
}
|
|
|
|
func TestUpsertDraft(t *testing.T) {
|
|
th := Setup(t).InitBasic()
|
|
defer th.TearDown()
|
|
|
|
th.Server.platform.SetConfigReadOnlyFF(false)
|
|
defer th.Server.platform.SetConfigReadOnlyFF(true)
|
|
|
|
th.App.UpdateConfig(func(cfg *model.Config) { cfg.FeatureFlags.GlobalDrafts = true })
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.AllowSyncedDrafts = true })
|
|
|
|
user := th.BasicUser
|
|
channel := th.BasicChannel
|
|
|
|
draft := &model.Draft{
|
|
UserId: user.Id,
|
|
ChannelId: channel.Id,
|
|
Message: "draft",
|
|
}
|
|
|
|
t.Run("upsert draft", func(t *testing.T) {
|
|
_, err := th.App.UpsertDraft(th.Context, draft, "")
|
|
assert.Nil(t, err)
|
|
|
|
drafts, err := th.App.GetDraftsForUser(user.Id, th.BasicTeam.Id)
|
|
assert.Nil(t, err)
|
|
assert.Len(t, drafts, 1)
|
|
draft1 := drafts[0]
|
|
|
|
assert.Equal(t, "draft", draft1.Message)
|
|
assert.Equal(t, channel.Id, draft1.ChannelId)
|
|
assert.Greater(t, draft1.CreateAt, int64(0))
|
|
|
|
draft = &model.Draft{
|
|
UserId: user.Id,
|
|
ChannelId: channel.Id,
|
|
Message: "updated draft",
|
|
}
|
|
_, err = th.App.UpsertDraft(th.Context, draft, "")
|
|
assert.Nil(t, err)
|
|
|
|
drafts, err = th.App.GetDraftsForUser(user.Id, th.BasicTeam.Id)
|
|
assert.Nil(t, err)
|
|
assert.Len(t, drafts, 1)
|
|
draft2 := drafts[0]
|
|
|
|
assert.Equal(t, "updated draft", draft2.Message)
|
|
assert.Equal(t, channel.Id, draft2.ChannelId)
|
|
assert.Equal(t, draft1.CreateAt, draft2.CreateAt)
|
|
})
|
|
|
|
t.Run("upsert draft feature flag", func(t *testing.T) {
|
|
os.Setenv("MM_FEATUREFLAGS_GLOBALDRAFTS", "false")
|
|
defer os.Unsetenv("MM_FEATUREFLAGS_GLOBALDRAFTS")
|
|
os.Setenv("MM_SERVICESETTINGS_ALLOWSYNCEDDRAFTS", "false")
|
|
defer os.Unsetenv("MM_SERVICESETTINGS_ALLOWSYNCEDDRAFTS")
|
|
|
|
th.App.UpdateConfig(func(cfg *model.Config) { cfg.FeatureFlags.GlobalDrafts = false })
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.AllowSyncedDrafts = false })
|
|
|
|
defer th.App.UpdateConfig(func(cfg *model.Config) { cfg.FeatureFlags.GlobalDrafts = true })
|
|
defer th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.AllowSyncedDrafts = true })
|
|
|
|
_, err := th.App.UpsertDraft(th.Context, draft, "")
|
|
assert.NotNil(t, err)
|
|
})
|
|
}
|
|
|
|
func TestCreateDraft(t *testing.T) {
|
|
th := Setup(t).InitBasic()
|
|
defer th.TearDown()
|
|
|
|
th.Server.platform.SetConfigReadOnlyFF(false)
|
|
defer th.Server.platform.SetConfigReadOnlyFF(true)
|
|
|
|
th.App.UpdateConfig(func(cfg *model.Config) { cfg.FeatureFlags.GlobalDrafts = true })
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.AllowSyncedDrafts = true })
|
|
|
|
user := th.BasicUser
|
|
channel := th.BasicChannel
|
|
channel2 := th.CreateChannel(th.Context, th.BasicTeam)
|
|
th.AddUserToChannel(user, channel2)
|
|
|
|
draft1 := &model.Draft{
|
|
CreateAt: 00001,
|
|
UpdateAt: 00001,
|
|
UserId: user.Id,
|
|
ChannelId: channel.Id,
|
|
Message: "draft",
|
|
}
|
|
|
|
draft2 := &model.Draft{
|
|
CreateAt: 00001,
|
|
UpdateAt: 00001,
|
|
UserId: user.Id,
|
|
ChannelId: channel2.Id,
|
|
Message: "draft2",
|
|
}
|
|
|
|
t.Run("create draft", func(t *testing.T) {
|
|
draftResp, err := th.App.UpsertDraft(th.Context, draft1, "")
|
|
assert.Nil(t, err)
|
|
|
|
assert.Equal(t, draft1.Message, draftResp.Message)
|
|
assert.Equal(t, draft1.ChannelId, draftResp.ChannelId)
|
|
})
|
|
|
|
t.Run("create draft with files", func(t *testing.T) {
|
|
// upload file
|
|
sent, readFileErr := testutils.ReadTestFile("test.png")
|
|
require.NoError(t, readFileErr)
|
|
|
|
fileResp, uploadFileErr := th.App.UploadFile(th.Context, sent, channel.Id, "test.png")
|
|
assert.Nil(t, uploadFileErr)
|
|
|
|
draftWithFiles := draft2
|
|
draftWithFiles.FileIds = []string{fileResp.Id}
|
|
|
|
draftResp, err := th.App.UpsertDraft(th.Context, draftWithFiles, "")
|
|
assert.Nil(t, err)
|
|
|
|
assert.Equal(t, draftWithFiles.Message, draftResp.Message)
|
|
assert.Equal(t, draftWithFiles.ChannelId, draftResp.ChannelId)
|
|
assert.ElementsMatch(t, draftWithFiles.FileIds, draftResp.FileIds)
|
|
})
|
|
}
|
|
|
|
func TestUpdateDraft(t *testing.T) {
|
|
th := Setup(t).InitBasic()
|
|
defer th.TearDown()
|
|
|
|
th.Server.platform.SetConfigReadOnlyFF(false)
|
|
defer th.Server.platform.SetConfigReadOnlyFF(true)
|
|
|
|
th.App.UpdateConfig(func(cfg *model.Config) { cfg.FeatureFlags.GlobalDrafts = true })
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.AllowSyncedDrafts = true })
|
|
|
|
user := th.BasicUser
|
|
channel := th.BasicChannel
|
|
|
|
draft1 := &model.Draft{
|
|
UserId: user.Id,
|
|
ChannelId: channel.Id,
|
|
Message: "draft1",
|
|
}
|
|
|
|
_, createDraftErr := th.App.UpsertDraft(th.Context, draft1, "")
|
|
assert.Nil(t, createDraftErr)
|
|
|
|
t.Run("update draft with files", func(t *testing.T) {
|
|
// upload file
|
|
sent, readFileErr := testutils.ReadTestFile("test.png")
|
|
require.NoError(t, readFileErr)
|
|
|
|
fileResp, uploadFileErr := th.App.UploadFile(th.Context, sent, channel.Id, "test.png")
|
|
assert.Nil(t, uploadFileErr)
|
|
|
|
draftWithFiles := draft1
|
|
draftWithFiles.FileIds = []string{fileResp.Id}
|
|
|
|
_, err := th.App.UpsertDraft(th.Context, draft1, "")
|
|
assert.Nil(t, err)
|
|
|
|
drafts, err := th.App.GetDraftsForUser(user.Id, th.BasicTeam.Id)
|
|
assert.Nil(t, err)
|
|
|
|
draftResp := drafts[0]
|
|
assert.Equal(t, draftWithFiles.Message, draftResp.Message)
|
|
assert.Equal(t, draftWithFiles.ChannelId, draftResp.ChannelId)
|
|
assert.ElementsMatch(t, draftWithFiles.FileIds, draftResp.FileIds)
|
|
})
|
|
}
|
|
|
|
func TestGetDraftsForUser(t *testing.T) {
|
|
th := Setup(t).InitBasic()
|
|
defer th.TearDown()
|
|
|
|
th.Server.platform.SetConfigReadOnlyFF(false)
|
|
defer th.Server.platform.SetConfigReadOnlyFF(true)
|
|
|
|
th.App.UpdateConfig(func(cfg *model.Config) { cfg.FeatureFlags.GlobalDrafts = true })
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.AllowSyncedDrafts = true })
|
|
|
|
user := th.BasicUser
|
|
channel := th.BasicChannel
|
|
channel2 := th.CreateChannel(th.Context, th.BasicTeam)
|
|
th.AddUserToChannel(user, channel2)
|
|
|
|
draft1 := &model.Draft{
|
|
CreateAt: 00001,
|
|
UpdateAt: 00001,
|
|
UserId: user.Id,
|
|
ChannelId: channel.Id,
|
|
Message: "draft1",
|
|
}
|
|
|
|
draft2 := &model.Draft{
|
|
CreateAt: 00005,
|
|
UpdateAt: 00005,
|
|
UserId: user.Id,
|
|
ChannelId: channel2.Id,
|
|
Message: "draft2",
|
|
}
|
|
|
|
_, createDraftErr1 := th.App.UpsertDraft(th.Context, draft1, "")
|
|
assert.Nil(t, createDraftErr1)
|
|
|
|
_, createDraftErr2 := th.App.UpsertDraft(th.Context, draft2, "")
|
|
assert.Nil(t, createDraftErr2)
|
|
|
|
t.Run("get drafts", func(t *testing.T) {
|
|
t.Skip("MM-52088")
|
|
draftResp, err := th.App.GetDraftsForUser(user.Id, th.BasicTeam.Id)
|
|
assert.Nil(t, err)
|
|
|
|
assert.Equal(t, draft2.Message, draftResp[0].Message)
|
|
assert.Equal(t, draft2.ChannelId, draftResp[0].ChannelId)
|
|
|
|
assert.Equal(t, draft1.Message, draftResp[1].Message)
|
|
assert.Equal(t, draft1.ChannelId, draftResp[1].ChannelId)
|
|
})
|
|
|
|
t.Run("get drafts with files", func(t *testing.T) {
|
|
// upload file
|
|
sent, readFileErr := testutils.ReadTestFile("test.png")
|
|
require.NoError(t, readFileErr)
|
|
|
|
fileResp, updateDraftErr := th.App.UploadFile(th.Context, sent, channel.Id, "test.png")
|
|
assert.Nil(t, updateDraftErr)
|
|
|
|
draftWithFiles := draft1
|
|
draftWithFiles.FileIds = []string{fileResp.Id}
|
|
|
|
draftResp, updateDraftErr := th.App.UpsertDraft(th.Context, draft1, "")
|
|
assert.Nil(t, updateDraftErr)
|
|
|
|
assert.Equal(t, draftWithFiles.Message, draftResp.Message)
|
|
assert.Equal(t, draftWithFiles.ChannelId, draftResp.ChannelId)
|
|
assert.ElementsMatch(t, draftWithFiles.FileIds, draftResp.FileIds)
|
|
|
|
draftsWithFilesResp, err := th.App.GetDraftsForUser(user.Id, th.BasicTeam.Id)
|
|
assert.Nil(t, err)
|
|
|
|
assert.Equal(t, draftWithFiles.Message, draftsWithFilesResp[0].Message)
|
|
assert.Equal(t, draftWithFiles.ChannelId, draftsWithFilesResp[0].ChannelId)
|
|
assert.ElementsMatch(t, draftWithFiles.FileIds, draftsWithFilesResp[0].FileIds)
|
|
|
|
assert.Equal(t, fileResp.Name, draftsWithFilesResp[0].Metadata.Files[0].Name)
|
|
|
|
assert.Len(t, draftsWithFilesResp, 2)
|
|
})
|
|
|
|
t.Run("get drafts feature flag", func(t *testing.T) {
|
|
os.Setenv("MM_FEATUREFLAGS_GLOBALDRAFTS", "false")
|
|
defer os.Unsetenv("MM_FEATUREFLAGS_GLOBALDRAFTS")
|
|
os.Setenv("MM_SERVICESETTINGS_ALLOWSYNCEDDRAFTS", "false")
|
|
defer os.Unsetenv("MM_SERVICESETTINGS_ALLOWSYNCEDDRAFTS")
|
|
|
|
th.App.UpdateConfig(func(cfg *model.Config) { cfg.FeatureFlags.GlobalDrafts = false })
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.AllowSyncedDrafts = false })
|
|
|
|
defer th.App.UpdateConfig(func(cfg *model.Config) { cfg.FeatureFlags.GlobalDrafts = true })
|
|
defer th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.AllowSyncedDrafts = true })
|
|
|
|
_, err := th.App.GetDraftsForUser(user.Id, th.BasicTeam.Id)
|
|
assert.NotNil(t, err)
|
|
})
|
|
}
|
|
|
|
func TestDeleteDraft(t *testing.T) {
|
|
th := Setup(t).InitBasic()
|
|
defer th.TearDown()
|
|
|
|
th.Server.platform.SetConfigReadOnlyFF(false)
|
|
defer th.Server.platform.SetConfigReadOnlyFF(true)
|
|
|
|
th.App.UpdateConfig(func(cfg *model.Config) { cfg.FeatureFlags.GlobalDrafts = true })
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.AllowSyncedDrafts = true })
|
|
|
|
user := th.BasicUser
|
|
channel := th.BasicChannel
|
|
|
|
draft1 := &model.Draft{
|
|
CreateAt: 00001,
|
|
UpdateAt: 00001,
|
|
UserId: user.Id,
|
|
ChannelId: channel.Id,
|
|
Message: "draft1",
|
|
}
|
|
|
|
_, createDraftErr := th.App.UpsertDraft(th.Context, draft1, "")
|
|
assert.Nil(t, createDraftErr)
|
|
|
|
t.Run("delete draft", func(t *testing.T) {
|
|
draftResp, err := th.App.DeleteDraft(user.Id, channel.Id, "", "")
|
|
assert.Nil(t, err)
|
|
|
|
assert.Equal(t, draft1.Message, draftResp.Message)
|
|
assert.Equal(t, draft1.ChannelId, draftResp.ChannelId)
|
|
|
|
assert.Equal(t, draft1.Message, draftResp.Message)
|
|
assert.Equal(t, draft1.ChannelId, draftResp.ChannelId)
|
|
})
|
|
|
|
t.Run("delete drafts feature flag", func(t *testing.T) {
|
|
os.Setenv("MM_FEATUREFLAGS_GLOBALDRAFTS", "false")
|
|
defer os.Unsetenv("MM_FEATUREFLAGS_GLOBALDRAFTS")
|
|
os.Setenv("MM_SERVICESETTINGS_ALLOWSYNCEDDRAFTS", "false")
|
|
defer os.Unsetenv("MM_SERVICESETTINGS_ALLOWSYNCEDDRAFTS")
|
|
|
|
th.App.UpdateConfig(func(cfg *model.Config) { cfg.FeatureFlags.GlobalDrafts = false })
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.AllowSyncedDrafts = false })
|
|
|
|
defer th.App.UpdateConfig(func(cfg *model.Config) { cfg.FeatureFlags.GlobalDrafts = true })
|
|
defer th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.AllowSyncedDrafts = true })
|
|
|
|
_, err := th.App.DeleteDraft(user.Id, channel.Id, "", "")
|
|
assert.NotNil(t, err)
|
|
})
|
|
}
|