mirror of
https://github.com/mattermost/mattermost.git
synced 2025-02-25 18:55:24 -06:00
* Posts * Add missing translation * Fix internal store marshaling * [MM-22051] Remove To/From JSON (Channels) (#18116) * Channels * Channel members * ChannelSearch * Channel categories, list, sidebar, stats, view * Fix conversions * [MM-22051] Remove To/From JSON (Users) (#18121) * User related structs * Fix return * Team related structures (#18127) * [MM-22051] Remove To/From JSON (Status, Bot, Reaction, Thread, FileInfo) (#18130) * Status * Bot * Reaction * Thread * FileInfo * Some fixes * Translations update from Weblate (#18143) * Translated using Weblate (German) Currently translated at 100.0% (2309 of 2309 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/de/ * Translated using Weblate (Turkish) Currently translated at 100.0% (2309 of 2309 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/tr/ * Translated using Weblate (Hungarian) Currently translated at 100.0% (2309 of 2309 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/hu/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ * Translated using Weblate (German) Currently translated at 100.0% (2301 of 2301 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/de/ * Translated using Weblate (Turkish) Currently translated at 100.0% (2301 of 2301 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/tr/ * Translated using Weblate (Hungarian) Currently translated at 100.0% (2301 of 2301 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/hu/ * Translated using Weblate (English (Australia)) Currently translated at 100.0% (2301 of 2301 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/en_AU/ * Translated using Weblate (Bulgarian) Currently translated at 100.0% (2301 of 2301 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/bg/ * Translated using Weblate (Japanese) Currently translated at 100.0% (2301 of 2301 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ja/ * Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (2301 of 2301 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/zh_Hans/ Co-authored-by: JtheBAB <srast@bioc.uzh.ch> Co-authored-by: Kaya Zeren <kayazeren@gmail.com> Co-authored-by: Tóth Csaba // Online ERP Hungary Kft <csaba.toth@online-erp.hu> Co-authored-by: Matthew Williams <Matthew.Williams@outlook.com.au> Co-authored-by: Nikolai Zahariev <nikolaiz@yahoo.com> Co-authored-by: kaakaa <stooner.hoe@gmail.com> Co-authored-by: aeomin <lin@aeomin.net> Co-authored-by: Weblate (bot) <hosted@weblate.org> Co-authored-by: JtheBAB <srast@bioc.uzh.ch> Co-authored-by: Kaya Zeren <kayazeren@gmail.com> Co-authored-by: Tóth Csaba // Online ERP Hungary Kft <csaba.toth@online-erp.hu> Co-authored-by: Matthew Williams <Matthew.Williams@outlook.com.au> Co-authored-by: Nikolai Zahariev <nikolaiz@yahoo.com> Co-authored-by: kaakaa <stooner.hoe@gmail.com> Co-authored-by: aeomin <lin@aeomin.net> * [MM-22051] Remove To/From JSON methods from model (#18138) * Scheme * Role * Session * Config * Status * Fix logic * Emoji * GuestsInvite * Group * Command * ClusterInfo * License * Job * System * Plugin * Command2 * IncomingWebhook * OutgoingWebhook * Fix tests * Update traslation * Some fixes * Add missing return * Simplify * Make Config.ToJSONFiltered() return []byte * Make Busy.ToJSON() return []byte * Include error in log * Split logic * [MM-22051] Remove To/From JSON (final) (#18150) * SwitchRequest * PluginEventData * Permalink * PushNotification * SuggestCommand * PluginsResponse * WebSocketMessage * RemoteCluster * SharedChannel * PluginStatuses * InitialLoad * ClusterDiscovery * ClusterStats * MfaSecret * GroupSyncable * SAML * WebSocketRequest * TypingRequest * SecurityBulletin * OAuthApp * IntegrationAction * DataRetention * Preference * FileInfoList * Compliance * Preferences * FileInfoSearchResults * TermsOfService * InstallMarketplacePluginRequest * GitLabUser * UploadSessions * Remove unused helpers * Fix tests * [MM-23280] Fix linting for ToJSON/FromJSON (#18153) * SwitchRequest * PluginEventData * Permalink * PushNotification * SuggestCommand * PluginsResponse * WebSocketMessage * RemoteCluster * SharedChannel * PluginStatuses * InitialLoad * ClusterDiscovery * ClusterStats * MfaSecret * GroupSyncable * SAML * WebSocketRequest * TypingRequest * SecurityBulletin * OAuthApp * IntegrationAction * DataRetention * Preference * FileInfoList * Compliance * Preferences * FileInfoSearchResults * TermsOfService * InstallMarketplacePluginRequest * GitLabUser * UploadSessions * Remove unused helpers * Fix tests * Fix linting for ToJSON/FromJSON * Fix conversions Co-authored-by: Weblate (bot) <hosted@weblate.org> Co-authored-by: JtheBAB <srast@bioc.uzh.ch> Co-authored-by: Kaya Zeren <kayazeren@gmail.com> Co-authored-by: Tóth Csaba // Online ERP Hungary Kft <csaba.toth@online-erp.hu> Co-authored-by: Matthew Williams <Matthew.Williams@outlook.com.au> Co-authored-by: Nikolai Zahariev <nikolaiz@yahoo.com> Co-authored-by: kaakaa <stooner.hoe@gmail.com> Co-authored-by: aeomin <lin@aeomin.net> Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
379 lines
11 KiB
Go
379 lines
11 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package api4
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"io"
|
|
"mime/multipart"
|
|
"net/http"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/mattermost/mattermost-server/v6/model"
|
|
"github.com/mattermost/mattermost-server/v6/utils/fileutils"
|
|
)
|
|
|
|
func TestCreateUpload(t *testing.T) {
|
|
th := Setup(t).InitBasic()
|
|
defer th.TearDown()
|
|
|
|
us := &model.UploadSession{
|
|
ChannelId: th.BasicChannel.Id,
|
|
Filename: "upload",
|
|
FileSize: 8 * 1024 * 1024,
|
|
}
|
|
|
|
t.Run("file attachments disabled", func(t *testing.T) {
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.FileSettings.EnableFileAttachments = false })
|
|
defer th.App.UpdateConfig(func(cfg *model.Config) { *cfg.FileSettings.EnableFileAttachments = true })
|
|
u, resp, err := th.Client.CreateUpload(us)
|
|
require.Nil(t, u)
|
|
CheckErrorID(t, err, "api.file.attachments.disabled.app_error")
|
|
require.Equal(t, http.StatusNotImplemented, resp.StatusCode)
|
|
})
|
|
|
|
t.Run("no permissions", func(t *testing.T) {
|
|
us.ChannelId = th.BasicPrivateChannel2.Id
|
|
u, resp, err := th.Client.CreateUpload(us)
|
|
require.Nil(t, u)
|
|
CheckErrorID(t, err, "api.context.permissions.app_error")
|
|
require.Equal(t, http.StatusForbidden, resp.StatusCode)
|
|
})
|
|
|
|
t.Run("valid", func(t *testing.T) {
|
|
us.ChannelId = th.BasicChannel.Id
|
|
u, resp, err := th.Client.CreateUpload(us)
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, u)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode)
|
|
})
|
|
|
|
t.Run("import file", func(t *testing.T) {
|
|
testsDir, _ := fileutils.FindDir("tests")
|
|
|
|
importFile, err := os.Open(testsDir + "/import_test.zip")
|
|
require.NoError(t, err)
|
|
defer importFile.Close()
|
|
|
|
info, err := importFile.Stat()
|
|
require.NoError(t, err)
|
|
|
|
t.Run("permissions error", func(t *testing.T) {
|
|
us := &model.UploadSession{
|
|
Filename: info.Name(),
|
|
FileSize: info.Size(),
|
|
Type: model.UploadTypeImport,
|
|
}
|
|
u, resp, err := th.Client.CreateUpload(us)
|
|
require.Nil(t, u)
|
|
CheckErrorID(t, err, "api.context.permissions.app_error")
|
|
require.Equal(t, http.StatusForbidden, resp.StatusCode)
|
|
})
|
|
|
|
t.Run("success", func(t *testing.T) {
|
|
us := &model.UploadSession{
|
|
Filename: info.Name(),
|
|
FileSize: info.Size(),
|
|
Type: model.UploadTypeImport,
|
|
}
|
|
u, _, err := th.SystemAdminClient.CreateUpload(us)
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, u)
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestGetUpload(t *testing.T) {
|
|
th := Setup(t).InitBasic()
|
|
defer th.TearDown()
|
|
|
|
us := &model.UploadSession{
|
|
Id: model.NewId(),
|
|
Type: model.UploadTypeAttachment,
|
|
CreateAt: model.GetMillis(),
|
|
UserId: th.BasicUser2.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Filename: "upload",
|
|
FileSize: 8 * 1024 * 1024,
|
|
}
|
|
us, err := th.App.CreateUploadSession(us)
|
|
require.Nil(t, err)
|
|
require.NotNil(t, us)
|
|
require.NotEmpty(t, us)
|
|
|
|
t.Run("upload not found", func(t *testing.T) {
|
|
u, resp, err := th.Client.GetUpload(model.NewId())
|
|
require.Nil(t, u)
|
|
CheckErrorID(t, err, "app.upload.get.app_error")
|
|
require.Equal(t, http.StatusNotFound, resp.StatusCode)
|
|
})
|
|
|
|
t.Run("no permissions", func(t *testing.T) {
|
|
u, _, err := th.Client.GetUpload(us.Id)
|
|
require.Nil(t, u)
|
|
CheckErrorID(t, err, "api.upload.get_upload.forbidden.app_error")
|
|
})
|
|
|
|
t.Run("success", func(t *testing.T) {
|
|
expected, resp, err := th.Client.CreateUpload(us)
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, expected)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode)
|
|
|
|
u, _, err := th.Client.GetUpload(expected.Id)
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, u)
|
|
require.Equal(t, expected, u)
|
|
})
|
|
}
|
|
|
|
func TestGetUploadsForUser(t *testing.T) {
|
|
th := Setup(t).InitBasic()
|
|
defer th.TearDown()
|
|
|
|
t.Run("no permissions", func(t *testing.T) {
|
|
uss, _, err := th.Client.GetUploadsForUser(th.BasicUser2.Id)
|
|
require.Error(t, err)
|
|
CheckErrorID(t, err, "api.user.get_uploads_for_user.forbidden.app_error")
|
|
require.Nil(t, uss)
|
|
})
|
|
|
|
t.Run("empty", func(t *testing.T) {
|
|
uss, _, err := th.Client.GetUploadsForUser(th.BasicUser.Id)
|
|
require.NoError(t, err)
|
|
require.Empty(t, uss)
|
|
})
|
|
|
|
t.Run("success", func(t *testing.T) {
|
|
uploads := make([]*model.UploadSession, 4)
|
|
for i := 0; i < len(uploads); i++ {
|
|
us := &model.UploadSession{
|
|
Id: model.NewId(),
|
|
Type: model.UploadTypeAttachment,
|
|
CreateAt: model.GetMillis(),
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Filename: "upload",
|
|
FileSize: 8 * 1024 * 1024,
|
|
}
|
|
us, err := th.App.CreateUploadSession(us)
|
|
require.Nil(t, err)
|
|
require.NotNil(t, us)
|
|
require.NotEmpty(t, us)
|
|
us.Path = ""
|
|
uploads[i] = us
|
|
}
|
|
|
|
uss, _, err := th.Client.GetUploadsForUser(th.BasicUser.Id)
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, uss)
|
|
require.Len(t, uss, len(uploads))
|
|
for i := range uploads {
|
|
require.Contains(t, uss, uploads[i])
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestUploadData(t *testing.T) {
|
|
th := Setup(t).InitBasic()
|
|
defer th.TearDown()
|
|
if *th.App.Config().FileSettings.DriverName == "" {
|
|
t.Skip("skipping because no file driver is enabled")
|
|
}
|
|
|
|
us := &model.UploadSession{
|
|
Id: model.NewId(),
|
|
Type: model.UploadTypeAttachment,
|
|
CreateAt: model.GetMillis(),
|
|
UserId: th.BasicUser2.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Filename: "upload",
|
|
FileSize: 8 * 1024 * 1024,
|
|
}
|
|
us, err := th.App.CreateUploadSession(us)
|
|
require.Nil(t, err)
|
|
require.NotNil(t, us)
|
|
require.NotEmpty(t, us)
|
|
|
|
data := randomBytes(t, int(us.FileSize))
|
|
|
|
t.Run("file attachments disabled", func(t *testing.T) {
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.FileSettings.EnableFileAttachments = false })
|
|
defer th.App.UpdateConfig(func(cfg *model.Config) { *cfg.FileSettings.EnableFileAttachments = true })
|
|
info, _, err := th.Client.UploadData(model.NewId(), bytes.NewReader(data))
|
|
require.Nil(t, info)
|
|
CheckErrorID(t, err, "api.file.attachments.disabled.app_error")
|
|
})
|
|
|
|
t.Run("upload not found", func(t *testing.T) {
|
|
info, resp, err := th.Client.UploadData(model.NewId(), bytes.NewReader(data))
|
|
require.Nil(t, info)
|
|
CheckErrorID(t, err, "app.upload.get.app_error")
|
|
require.Equal(t, http.StatusNotFound, resp.StatusCode)
|
|
})
|
|
|
|
t.Run("no permissions", func(t *testing.T) {
|
|
info, _, err := th.Client.UploadData(us.Id, bytes.NewReader(data))
|
|
require.Nil(t, info)
|
|
CheckErrorID(t, err, "api.context.permissions.app_error")
|
|
})
|
|
|
|
t.Run("bad content-length", func(t *testing.T) {
|
|
u, resp, err := th.Client.CreateUpload(us)
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, u)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode)
|
|
|
|
info, _, err := th.Client.UploadData(u.Id, bytes.NewReader(append(data, 0x00)))
|
|
require.Nil(t, info)
|
|
CheckErrorID(t, err, "api.upload.upload_data.invalid_content_length")
|
|
})
|
|
|
|
t.Run("success", func(t *testing.T) {
|
|
u, resp, err := th.Client.CreateUpload(us)
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, u)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode)
|
|
|
|
info, _, err := th.Client.UploadData(u.Id, bytes.NewReader(data))
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, info)
|
|
require.Equal(t, u.Filename, info.Name)
|
|
|
|
file, _, err := th.Client.GetFile(info.Id)
|
|
require.NoError(t, err)
|
|
require.Equal(t, file, data)
|
|
})
|
|
|
|
t.Run("resume success", func(t *testing.T) {
|
|
u, resp, err := th.Client.CreateUpload(us)
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, u)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode)
|
|
|
|
rd := &io.LimitedReader{
|
|
R: bytes.NewReader(data),
|
|
N: 5 * 1024 * 1024,
|
|
}
|
|
info, resp, err := th.Client.UploadData(u.Id, rd)
|
|
require.NoError(t, err)
|
|
require.Nil(t, info)
|
|
require.Equal(t, http.StatusNoContent, resp.StatusCode)
|
|
|
|
info, _, err = th.Client.UploadData(u.Id, bytes.NewReader(data[5*1024*1024:]))
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, info)
|
|
require.Equal(t, u.Filename, info.Name)
|
|
|
|
file, _, err := th.Client.GetFile(info.Id)
|
|
require.NoError(t, err)
|
|
require.Equal(t, file, data)
|
|
})
|
|
}
|
|
|
|
func TestUploadDataMultipart(t *testing.T) {
|
|
th := Setup(t).InitBasic()
|
|
defer th.TearDown()
|
|
if *th.App.Config().FileSettings.DriverName == "" {
|
|
t.Skip("skipping because no file driver is enabled")
|
|
}
|
|
|
|
us := &model.UploadSession{
|
|
Id: model.NewId(),
|
|
Type: model.UploadTypeAttachment,
|
|
CreateAt: model.GetMillis(),
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Filename: "upload",
|
|
FileSize: 8 * 1024 * 1024,
|
|
}
|
|
us, _, err := th.Client.CreateUpload(us)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, us)
|
|
require.NotEmpty(t, us)
|
|
|
|
data := randomBytes(t, int(us.FileSize))
|
|
|
|
genMultipartData := func(t *testing.T, data []byte) (io.Reader, string) {
|
|
mpData := &bytes.Buffer{}
|
|
mpWriter := multipart.NewWriter(mpData)
|
|
part, err := mpWriter.CreateFormFile("data", us.Filename)
|
|
require.NoError(t, err)
|
|
n, err := part.Write(data)
|
|
require.NoError(t, err)
|
|
require.Equal(t, len(data), n)
|
|
err = mpWriter.Close()
|
|
require.NoError(t, err)
|
|
return mpData, mpWriter.FormDataContentType()
|
|
}
|
|
|
|
t.Run("bad content-type", func(t *testing.T) {
|
|
info, _, err := th.Client.DoUploadFile("/uploads/"+us.Id, data, "multipart/form-data;")
|
|
require.Nil(t, info)
|
|
CheckErrorID(t, err, "api.upload.upload_data.invalid_content_type")
|
|
})
|
|
|
|
t.Run("success", func(t *testing.T) {
|
|
mpData, contentType := genMultipartData(t, data)
|
|
|
|
req, err := http.NewRequest("POST", th.Client.APIURL+"/uploads/"+us.Id, mpData)
|
|
require.NoError(t, err)
|
|
req.Header.Set("Content-Type", contentType)
|
|
req.Header.Set(model.HeaderAuth, th.Client.AuthType+" "+th.Client.AuthToken)
|
|
res, err := th.Client.HTTPClient.Do(req)
|
|
require.NoError(t, err)
|
|
var info model.FileInfo
|
|
err = json.NewDecoder(res.Body).Decode(&info)
|
|
res.Body.Close()
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, info)
|
|
require.Equal(t, us.Filename, info.Name)
|
|
|
|
file, _, err := th.Client.GetFile(info.Id)
|
|
require.NoError(t, err)
|
|
require.Equal(t, file, data)
|
|
})
|
|
|
|
t.Run("resume success", func(t *testing.T) {
|
|
mpData, contentType := genMultipartData(t, data[:5*1024*1024])
|
|
|
|
u, _, err := th.Client.CreateUpload(us)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, u)
|
|
require.NotEmpty(t, u)
|
|
|
|
req, err := http.NewRequest("POST", th.Client.APIURL+"/uploads/"+u.Id, mpData)
|
|
require.NoError(t, err)
|
|
req.Header.Set("Content-Type", contentType)
|
|
req.Header.Set(model.HeaderAuth, th.Client.AuthType+" "+th.Client.AuthToken)
|
|
res, err := th.Client.HTTPClient.Do(req)
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusNoContent, res.StatusCode)
|
|
require.Equal(t, int64(0), res.ContentLength)
|
|
|
|
mpData, contentType = genMultipartData(t, data[5*1024*1024:])
|
|
|
|
req, err = http.NewRequest("POST", th.Client.APIURL+"/uploads/"+u.Id, mpData)
|
|
require.NoError(t, err)
|
|
req.Header.Set("Content-Type", contentType)
|
|
req.Header.Set(model.HeaderAuth, th.Client.AuthType+" "+th.Client.AuthToken)
|
|
res, err = th.Client.HTTPClient.Do(req)
|
|
require.NoError(t, err)
|
|
var info model.FileInfo
|
|
err = json.NewDecoder(res.Body).Decode(&info)
|
|
res.Body.Close()
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, info)
|
|
require.Equal(t, u.Filename, info.Name)
|
|
|
|
file, _, err := th.Client.GetFile(info.Id)
|
|
require.NoError(t, err)
|
|
require.Equal(t, file, data)
|
|
})
|
|
}
|