Pierre de La Morinerie 809a16458f Abort on critical error during server startup (#8204) ...

Only a handful of critical errors are present in the codebase.
They all occur during server startup (in `app.StartServer()`).

Currently, when one of these critical error occurs, it is simpled
mentionned in the logs – then the error is discarded, and the app
attempts to continue the execution (and probably fails pretty quickly in
a weird way).

Rather than continuing operations in an unknow state, these errors should
trigger a clean exit.

This commit rewrites critical startup errors to be correctly
propagated, logged, and then terminate the command execution.
Additionnaly, it makes the server return a proper error code to the
shell.

2018-02-07 02:11:15 -06:00

..

plugin

Update zoom plugin to latest (#8194)

2018-02-02 16:32:14 -05:00

admin.go

Remove global cfg vars (#8099)

2018-01-12 09:02:11 -05:00

analytics.go

Refactoring cfg refs and load / save functions (#7749)

2017-10-31 10:39:31 -04:00

app_test.go

Abort on critical error during server startup (#8204)

2018-02-07 02:11:15 -06:00

app.go

Remove global cfg vars (#8099)

2018-01-12 09:02:11 -05:00

apptestlib.go

Abort on critical error during server startup (#8204)

2018-02-07 02:11:15 -06:00

audit.go

Renaming repo

2017-09-06 23:11:59 -07:00

authentication_test.go

User based rate limiting (#8152)

2018-01-31 09:49:15 -08:00

authentication.go

add App.License, remove utils.IsLicensed / utils.License calls (#8203)

2018-02-06 17:25:49 -06:00

authorization_test.go

Role refactor (#7867)

2017-11-21 11:08:32 -08:00

authorization.go

Role refactor (#7867)

2017-11-21 11:08:32 -08:00

auto_channels.go

[PLT-6936] Translate AppError.Message automatically by default (#8063)

2018-01-08 13:13:24 -05:00

auto_constants.go

Renaming repo

2017-09-06 23:11:59 -07:00

auto_environment.go

simplify things (#7735)

2017-10-30 11:57:24 -05:00

auto_posts.go

several one-line panic, race, and logic fixes (#7766)

2017-11-03 08:25:38 -07:00

auto_teams.go

simplify things (#7735)

2017-10-30 11:57:24 -05:00

auto_users.go

[PLT-6936] Translate AppError.Message automatically by default (#8063)

2018-01-08 13:13:24 -05:00

brand.go

Reduce utils.Cfg references (#7650)

2017-10-18 15:36:43 -07:00

channel_test.go

Post a system message to the affected channel by CLI command (#7877) (#7968)

2018-01-18 16:05:00 -05:00

channel.go

ABC-79: Optimize channel autocomplete query (#8163)

2018-01-31 09:26:40 -05:00

cluster_discovery_test.go

Fix races / finally remove global app for good (#7570)

2017-10-04 13:09:41 -07:00

cluster_discovery.go

add App.License, remove utils.IsLicensed / utils.License calls (#8203)

2018-02-06 17:25:49 -06:00

cluster_handlers.go

remove remaining Global() calls (outside of tests) (#7521)

2017-09-28 00:52:34 +08:00

command_away.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_channel_header_test.go

Role refactor (#7867)

2017-11-21 11:08:32 -08:00

command_channel_header.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_channel_purpose.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_channel_rename_test.go

Role refactor (#7867)

2017-11-21 11:08:32 -08:00

command_channel_rename.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_code_test.go

remove more global references (#7442)

2017-09-14 13:01:44 -04:00

command_code.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_dnd.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_echo.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_expand_collapse.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_groupmsg_test.go

PLT-7111 Add groupmsg command (#7419)

2017-11-14 17:27:14 -05:00

command_groupmsg.go

PLT-7111: Fix for groupmsgProvider.GetCommand method signature. (#7835)

2017-11-15 11:14:36 -06:00

command_help.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_invite_people.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_join.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_leave.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_loadtest.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_logout.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_me.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_msg_test.go

Fix /msg switching teams (#7753)

2017-11-01 14:15:31 -04:00

command_msg.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_offline.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_online.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_open.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_remove.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_search.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_settings.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_shortcuts.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_shrug.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_test.go

PLT-7818 Updates to post type (#7579)

2017-10-09 10:30:48 -07:00

command.go

set from_webhook if a builtin slash command overrides username or icon (#8143)

2018-01-23 11:26:31 -08:00

compliance.go

add App.License, remove utils.IsLicensed / utils.License calls (#8203)

2018-02-06 17:25:49 -06:00

config_test.go

Remove global cfg vars (#8099)

2018-01-12 09:02:11 -05:00

config.go

add App.License, remove utils.IsLicensed / utils.License calls (#8203)

2018-02-06 17:25:49 -06:00

data_retention.go

PLT-7705: API to get data retention policy. (#7539)

2017-10-02 12:43:21 +01:00

diagnostics_test.go

Finally remove utils.Cfg (#8113)

2018-01-17 13:38:37 -05:00

diagnostics.go

add App.License, remove utils.IsLicensed / utils.License calls (#8203)

2018-02-06 17:25:49 -06:00

elasticsearch.go

Reduce utils.Cfg references (#7650)

2017-10-18 15:36:43 -07:00

email_batching_test.go

simplify things (#7735)

2017-10-30 11:57:24 -05:00

email_batching.go

add App.License, remove utils.IsLicensed / utils.License calls (#8203)

2018-02-06 17:25:49 -06:00

email.go

Remove utils.ClientCfg and utils.ClientCfgHash (#8041)

2018-01-05 16:17:57 -06:00

emoji.go

Add GET /emojis/name/{emoji_name} API endpoint (#8142)

2018-01-24 08:50:11 -05:00

file_test.go

Reorganize file util functionality (#7848)

2017-11-16 16:04:27 -05:00

file.go

Reorganize file util functionality (#7848)

2017-11-16 16:04:27 -05:00

import_test.go

XYZ-32: Increases size of position to 128 characters. (#8148)

2018-01-26 08:37:12 -05:00

import.go

[XYZ-6] Add sampledata platform command (#8027)

2018-01-11 10:57:47 -05:00

job_test.go

Fix races / finally remove global app for good (#7570)

2017-10-04 13:09:41 -07:00

job.go

remove jobs.Srv and other jobs-related globals (#7535)

2017-09-29 10:29:29 +01:00

ldap.go

add App.License, remove utils.IsLicensed / utils.License calls (#8203)

2018-02-06 17:25:49 -06:00

license_test.go

add App.License, remove utils.IsLicensed / utils.License calls (#8203)

2018-02-06 17:25:49 -06:00

license.go

Finally remove utils.Cfg (#8113)

2018-01-17 13:38:37 -05:00

login.go

Reduce utils.Cfg references (#7650)

2017-10-18 15:36:43 -07:00

notification_test.go

use markdown parsing to identify mentions (#8139)

2018-01-23 14:48:20 -05:00

notification.go

add App.License, remove utils.IsLicensed / utils.License calls (#8203)

2018-02-06 17:25:49 -06:00

oauth_test.go

Finally remove utils.Cfg (#8113)

2018-01-17 13:38:37 -05:00

oauth.go

add App.License, remove utils.IsLicensed / utils.License calls (#8203)

2018-02-06 17:25:49 -06:00

options.go

Remove global config watcher (#8080)

2018-01-11 13:23:41 -08:00

plugin_api.go

Add plugin slash command support (#7941)

2017-12-08 13:55:41 -06:00

plugin_test.go

Add plugin slash command support (#7941)

2017-12-08 13:55:41 -06:00

plugin.go

ABC-22: Plugin sandboxing for linux/amd64 (#8068)

2018-01-15 09:21:06 -08:00

post_test.go

fix image url replacement for blank urls (#8184)

2018-02-01 18:31:49 -08:00

post.go

add App.License, remove utils.IsLicensed / utils.License calls (#8203)

2018-02-06 17:25:49 -06:00

preference.go

Goroutine wranglin (#7556)

2017-10-03 10:53:53 -05:00

ratelimit_test.go

handle RateLimiter initialization errors (#8199)

2018-02-05 23:27:34 -06:00

ratelimit.go

handle RateLimiter initialization errors (#8199)

2018-02-05 23:27:34 -06:00

reaction.go

PLT-3383: image proxy support (#7991)

2018-01-22 15:32:50 -06:00

role.go

Role refactor (#7867)

2017-11-21 11:08:32 -08:00

saml.go

several one-line panic, race, and logic fixes (#7766)

2017-11-03 08:25:38 -07:00

security_update_check.go

Remove utils.ClientCfg and utils.ClientCfgHash (#8041)

2018-01-05 16:17:57 -06:00

server_test.go

Abort on critical error during server startup (#8204)

2018-02-07 02:11:15 -06:00

server.go

Abort on critical error during server startup (#8204)

2018-02-07 02:11:15 -06:00

session_test.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

session.go

add App.License, remove utils.IsLicensed / utils.License calls (#8203)

2018-02-06 17:25:49 -06:00

slack_test.go

PLT-7824 Added support for mentions with <@userid> and <!here> (#7615) (#7737)

2017-11-17 11:17:59 -05:00

slack.go

PLT-7824 Added support for mentions with <@userid> and <!here> (#7615) (#7737)

2017-11-17 11:17:59 -05:00

slackimport_test.go

Renaming repo

2017-09-06 23:11:59 -07:00

slackimport.go

simplify things (#7735)

2017-10-30 11:57:24 -05:00

status.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

team_test.go

[PLT-6936] Translate AppError.Message automatically by default (#8063)

2018-01-08 13:13:24 -05:00

team.go

[PLT-8494] Add delete_team websocket event (#8167)

2018-02-01 09:46:24 -05:00

user_test.go

Finally remove utils.Cfg (#8113)

2018-01-17 13:38:37 -05:00

user.go

add App.License, remove utils.IsLicensed / utils.License calls (#8203)

2018-02-06 17:25:49 -06:00

web_conn.go

add App.License, remove utils.IsLicensed / utils.License calls (#8203)

2018-02-06 17:25:49 -06:00

web_hub_test.go

Improve test coverage reporting / accuracy (#7819)

2017-11-13 11:59:51 -08:00

web_hub.go

Improve test coverage reporting / accuracy (#7819)

2017-11-13 11:59:51 -08:00

webhook_test.go

Finally remove utils.Cfg (#8113)

2018-01-17 13:38:37 -05:00

webhook.go

add App.License, remove utils.IsLicensed / utils.License calls (#8203)

2018-02-06 17:25:49 -06:00

webrtc.go

HTTP client refactor (#7884)

2017-11-22 10:15:03 -05:00

websocket_router.go

Miscellaneous app cleanup (#7594)

2017-10-09 14:59:48 -07:00