mirror of
https://github.com/mattermost/mattermost.git
synced 2025-02-25 18:55:24 -06:00
* Add feature flag managment system using split.io and remove viper. * Fixing tests. * Attempt to fix postgres tests. * Fix watch filepath for advanced logging. * Review fixes. * Some error wrapping. * Remove unessisary store interface. * Desanitize SplitKey * Simplify. * Review feedback. * Rename split mlog adatper to split logger. * fsInner * Style. * Restore oldcfg test. * Downgrading non-actionable feature flag errors to warnings. Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
103 lines
2.8 KiB
Go
103 lines
2.8 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"time"
|
|
|
|
"github.com/mattermost/mattermost-server/v5/config"
|
|
"github.com/mattermost/mattermost-server/v5/mlog"
|
|
)
|
|
|
|
// setupFeatureFlags called on startup and when the cluster leader changes.
|
|
// Starts or stops the synchronization of feature flags from upstream management.
|
|
func (s *Server) setupFeatureFlags() {
|
|
s.featureFlagSynchronizerMutex.Lock()
|
|
defer s.featureFlagSynchronizerMutex.Unlock()
|
|
license := s.License()
|
|
inCloud := license != nil && *license.Features.Cloud
|
|
splitKey := *s.Config().ServiceSettings.SplitKey
|
|
syncFeatureFlags := inCloud && splitKey != "" && s.IsLeader()
|
|
|
|
s.configStore.PersistFeatures(inCloud)
|
|
|
|
if syncFeatureFlags {
|
|
if err := s.startFeatureFlagUpdateJob(); err != nil {
|
|
s.Log.Warn("Unable to setup synchronization with feature flag management. Will fallback to cloud cache.", mlog.Err(err))
|
|
}
|
|
} else {
|
|
s.stopFeatureFlagUpdateJob()
|
|
}
|
|
|
|
if err := s.configStore.Load(); err != nil {
|
|
s.Log.Warn("Unable to load config store after feature flag setup.", mlog.Err(err))
|
|
}
|
|
}
|
|
|
|
func (s *Server) updateFeatureFlagValuesFromManagment() {
|
|
newCfg := s.configStore.GetNoEnv().Clone()
|
|
oldFlags := *newCfg.FeatureFlags
|
|
newFlags := s.featureFlagSynchronizer.UpdateFeatureFlagValues(oldFlags)
|
|
if oldFlags != newFlags {
|
|
*newCfg.FeatureFlags = newFlags
|
|
s.SaveConfig(newCfg, true)
|
|
}
|
|
}
|
|
|
|
func (s *Server) startFeatureFlagUpdateJob() error {
|
|
// Can be run multiple times
|
|
if s.featureFlagSynchronizer != nil {
|
|
return nil
|
|
}
|
|
|
|
var log *mlog.Logger
|
|
if *s.Config().ServiceSettings.DebugSplit {
|
|
log = s.Log
|
|
}
|
|
|
|
synchronizer, err := config.NewFeatureFlagSynchronizer(config.FeatureFlagSyncParams{
|
|
ServerID: s.TelemetryId(),
|
|
SplitKey: *s.Config().ServiceSettings.SplitKey,
|
|
Log: log,
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
s.featureFlagStop = make(chan struct{})
|
|
s.featureFlagStopped = make(chan struct{})
|
|
s.featureFlagSynchronizer = synchronizer
|
|
syncInterval := *s.Config().ServiceSettings.FeatureFlagSyncIntervalSeconds
|
|
|
|
go func() {
|
|
ticker := time.NewTicker(time.Duration(syncInterval) * time.Second)
|
|
defer ticker.Stop()
|
|
defer close(s.featureFlagStopped)
|
|
if err := synchronizer.EnsureReady(); err != nil {
|
|
s.Log.Warn("Problem connecting to feature flag management. Will fallback to cloud cache.", mlog.Err(err))
|
|
return
|
|
}
|
|
s.updateFeatureFlagValuesFromManagment()
|
|
for {
|
|
select {
|
|
case <-s.featureFlagStop:
|
|
return
|
|
case <-ticker.C:
|
|
s.updateFeatureFlagValuesFromManagment()
|
|
}
|
|
}
|
|
}()
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s *Server) stopFeatureFlagUpdateJob() {
|
|
if s.featureFlagSynchronizer != nil {
|
|
close(s.featureFlagStop)
|
|
<-s.featureFlagStopped
|
|
s.featureFlagSynchronizer.Close()
|
|
s.featureFlagSynchronizer = nil
|
|
}
|
|
}
|