mirror of
https://github.com/mattermost/mattermost.git
synced 2025-02-25 18:55:24 -06:00
* Added support for PostActions in ephemeral posts The general approach is that we take all the metadata that DoPostAction needs to process client DoPostActionRequests, and store it in a serialized, encrypted Cookie field, in the PostAction struct. The client then must send it back, and it is then used to process PostActions as a fallback top the metadata in the database. This PR adds a new config setting, `ServiceSettings.ActionCookieSecret`. In a cluster environment it must be the same for all instances. - Added type PostActionCookie, and a Cookie string to PostAction. - Added App.AddActionCookiesToPost. - Use App.AddActionCookiesToPost in api4.createEphemeralPost, App.SendEphemeralPost, App.UpdateEphemeralPost. - Added App.DoPostActionWithCookie to process incoming requests with cookies. For backward compatibility, it prefers the metadata in the database; falls back to cookie. - Added plugin.API.UpdateEphemeralPost and plugin.API.DeleteEphemeralPost. - Added App.encryptActionCookie/App.decryptActionCookie. * Style * Fixed an unfortunate typo, tested with matterpoll * minor PR feedback * Fixed uninitialized Context * Fixed another test failure * Fixed permission check * Added api test for DoPostActionWithCookie * Replaced config.ActionCookieSecret with Server.PostActionCookieSecret Modeled after AsymetricSigningKey * style * Set DeleteAt in DeleteEphemeralPost * PR feedback * Removed deadwood comment * Added EXPERIMENTAL comment to the 2 APIs in question
171 lines
5.8 KiB
Go
171 lines
5.8 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See License.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"net/url"
|
|
"path"
|
|
|
|
"github.com/mattermost/mattermost-server/mlog"
|
|
"github.com/mattermost/mattermost-server/model"
|
|
"github.com/mattermost/mattermost-server/services/mailservice"
|
|
"github.com/mattermost/mattermost-server/store"
|
|
"github.com/mattermost/mattermost-server/store/sqlstore"
|
|
"github.com/mattermost/mattermost-server/utils"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
// This is a bridge between the old and new initalization for the context refactor.
|
|
// It calls app layer initalization code that then turns around and acts on the server.
|
|
// Don't add anything new here, new initilization should be done in the server and
|
|
// performed in the NewServer function.
|
|
func (s *Server) RunOldAppInitalization() error {
|
|
s.FakeApp().CreatePushNotificationsHub()
|
|
s.FakeApp().StartPushNotificationsHubWorkers()
|
|
|
|
if err := utils.InitTranslations(s.FakeApp().Config().LocalizationSettings); err != nil {
|
|
return errors.Wrapf(err, "unable to load Mattermost translation files")
|
|
}
|
|
|
|
s.FakeApp().Srv.configListenerId = s.FakeApp().AddConfigListener(func(_, _ *model.Config) {
|
|
s.FakeApp().configOrLicenseListener()
|
|
|
|
message := model.NewWebSocketEvent(model.WEBSOCKET_EVENT_CONFIG_CHANGED, "", "", "", nil)
|
|
|
|
message.Add("config", s.FakeApp().ClientConfigWithComputed())
|
|
s.Go(func() {
|
|
s.FakeApp().Publish(message)
|
|
})
|
|
})
|
|
s.FakeApp().Srv.licenseListenerId = s.FakeApp().AddLicenseListener(func() {
|
|
s.FakeApp().configOrLicenseListener()
|
|
|
|
message := model.NewWebSocketEvent(model.WEBSOCKET_EVENT_LICENSE_CHANGED, "", "", "", nil)
|
|
message.Add("license", s.FakeApp().GetSanitizedClientLicense())
|
|
s.Go(func() {
|
|
s.FakeApp().Publish(message)
|
|
})
|
|
|
|
})
|
|
|
|
if err := s.FakeApp().SetupInviteEmailRateLimiting(); err != nil {
|
|
return err
|
|
}
|
|
|
|
mlog.Info("Server is initializing...")
|
|
|
|
s.initEnterprise()
|
|
|
|
if s.FakeApp().Srv.newStore == nil {
|
|
s.FakeApp().Srv.newStore = func() store.Store {
|
|
return store.NewLayeredStore(sqlstore.NewSqlSupplier(s.FakeApp().Config().SqlSettings, s.Metrics), s.Metrics, s.Cluster)
|
|
}
|
|
}
|
|
|
|
if htmlTemplateWatcher, err := utils.NewHTMLTemplateWatcher("templates"); err != nil {
|
|
mlog.Error(fmt.Sprintf("Failed to parse server templates %v", err))
|
|
} else {
|
|
s.FakeApp().Srv.htmlTemplateWatcher = htmlTemplateWatcher
|
|
}
|
|
|
|
s.FakeApp().Srv.Store = s.FakeApp().Srv.newStore()
|
|
|
|
if err := s.FakeApp().ensureAsymmetricSigningKey(); err != nil {
|
|
return errors.Wrapf(err, "unable to ensure asymmetric signing key")
|
|
}
|
|
|
|
if err := s.FakeApp().ensurePostActionCookieSecret(); err != nil {
|
|
return errors.Wrapf(err, "unable to ensure PostAction cookie secret")
|
|
}
|
|
|
|
if err := s.FakeApp().ensureInstallationDate(); err != nil {
|
|
return errors.Wrapf(err, "unable to ensure installation date")
|
|
}
|
|
|
|
s.FakeApp().EnsureDiagnosticId()
|
|
s.FakeApp().regenerateClientConfig()
|
|
|
|
s.FakeApp().Srv.clusterLeaderListenerId = s.FakeApp().Srv.AddClusterLeaderChangedListener(func() {
|
|
mlog.Info("Cluster leader changed. Determining if job schedulers should be running:", mlog.Bool("isLeader", s.FakeApp().IsLeader()))
|
|
if s.FakeApp().Srv.Jobs != nil {
|
|
s.FakeApp().Srv.Jobs.Schedulers.HandleClusterLeaderChange(s.FakeApp().IsLeader())
|
|
}
|
|
})
|
|
|
|
subpath, err := utils.GetSubpathFromConfig(s.FakeApp().Config())
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to parse SiteURL subpath")
|
|
}
|
|
s.FakeApp().Srv.Router = s.FakeApp().Srv.RootRouter.PathPrefix(subpath).Subrouter()
|
|
s.FakeApp().Srv.Router.HandleFunc("/plugins/{plugin_id:[A-Za-z0-9\\_\\-\\.]+}", s.FakeApp().ServePluginRequest)
|
|
s.FakeApp().Srv.Router.HandleFunc("/plugins/{plugin_id:[A-Za-z0-9\\_\\-\\.]+}/{anything:.*}", s.FakeApp().ServePluginRequest)
|
|
|
|
// If configured with a subpath, redirect 404s at the root back into the subpath.
|
|
if subpath != "/" {
|
|
s.FakeApp().Srv.RootRouter.NotFoundHandler = http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
r.URL.Path = path.Join(subpath, r.URL.Path)
|
|
http.Redirect(w, r, r.URL.String(), http.StatusFound)
|
|
})
|
|
}
|
|
s.FakeApp().Srv.Router.NotFoundHandler = http.HandlerFunc(s.FakeApp().Handle404)
|
|
|
|
s.FakeApp().Srv.WebSocketRouter = &WebSocketRouter{
|
|
app: s.FakeApp(),
|
|
handlers: make(map[string]webSocketHandler),
|
|
}
|
|
|
|
mailservice.TestConnection(s.FakeApp().Config())
|
|
|
|
if _, err := url.ParseRequestURI(*s.FakeApp().Config().ServiceSettings.SiteURL); err != nil {
|
|
mlog.Error("SiteURL must be set. Some features will operate incorrectly if the SiteURL is not set. See documentation for details: http://about.mattermost.com/default-site-url")
|
|
}
|
|
|
|
backend, appErr := s.FakeApp().FileBackend()
|
|
if appErr == nil {
|
|
appErr = backend.TestConnection()
|
|
}
|
|
if appErr != nil {
|
|
mlog.Error("Problem with file storage settings: " + appErr.Error())
|
|
}
|
|
|
|
if model.BuildEnterpriseReady == "true" {
|
|
s.FakeApp().LoadLicense()
|
|
}
|
|
|
|
s.FakeApp().DoAdvancedPermissionsMigration()
|
|
s.FakeApp().DoEmojisPermissionsMigration()
|
|
|
|
s.FakeApp().InitPostMetadata()
|
|
|
|
s.FakeApp().InitPlugins(*s.Config().PluginSettings.Directory, *s.Config().PluginSettings.ClientDirectory)
|
|
s.FakeApp().AddConfigListener(func(prevCfg, cfg *model.Config) {
|
|
if *cfg.PluginSettings.Enable {
|
|
s.FakeApp().InitPlugins(*cfg.PluginSettings.Directory, *s.Config().PluginSettings.ClientDirectory)
|
|
} else {
|
|
s.FakeApp().ShutDownPlugins()
|
|
}
|
|
})
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s *Server) RunOldAppShutdown() {
|
|
s.FakeApp().HubStop()
|
|
s.FakeApp().StopPushNotificationsHubWorkers()
|
|
s.FakeApp().ShutDownPlugins()
|
|
s.FakeApp().RemoveLicenseListener(s.licenseListenerId)
|
|
s.RemoveClusterLeaderChangedListener(s.clusterLeaderListenerId)
|
|
}
|
|
|
|
// A temporary bridge to deal with cases where the code is so tighly coupled that
|
|
// this is easier as a temporary solution
|
|
func (s *Server) FakeApp() *App {
|
|
a := New(
|
|
ServerConnector(s),
|
|
)
|
|
return a
|
|
}
|