IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity
Files
4f022aff6ddc1fcfcdac7e33f9c0a3eb3e88f74e
mattermost/model
History
Agniva De Sarker 4f022aff6d MM-24547: Fix writer leak when connection closes (#14406) 
* MM-24547: Fix writer leak when connection closes

When the connection is closed, the exit path does not
shut down the writer goroutine. In which case, it will keep spinning forever.

Since we already have the CAS mechanism now, we can move the closing
functionality into the main Close method and just call that in the defer block.

This makes closing the websocket client idempotent from both perspective -
- Explicitly closing.
- Closing due to connection tear down.

There are still 2 races left:
- Using the exported Conn to directly write messages. We cannot do anything about
that as long as clients directly using that.
- Setting the wsc.pingTimeoutTimer field in a separate goroutine when calling
.Connect(). This will need to be seen later.

* Fix ineffectual assignment

* Duplicate the closing of writer

The problem with refactoring the writer closing to a common
function was that we needed to wait for the reader to exit
before closing the EventChannel and ResponseChannel.

But then there is another problem that the API can be used in such
a way that the client is liable to call Close without even calling
Listen. In that case, we cannot wait for Listen to quit.

So from Close, we can only close the connection. And therefore
we need to duplicate the writer closing in the read loop's
defer block.

* Cleanup some comments
2020-04-30 23:50:13 +05:30
..
gitlab
[MM-22037] Enable uppercase letters in the email (#13794)
2020-02-12 08:51:45 -05:00
testdata
PLT-3383: image proxy support (#7991)
2018-01-22 15:32:50 -06:00
access_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
access.go
Fix inconsistencies in variable names for struct methods (#13561)
2020-01-07 10:47:03 +01:00
analytics_row_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
analytics_row.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
at_mentions_test.go
MM-21987 Resolve mentions in slash commands (#13762)
2020-03-11 11:50:12 +01:00
at_mentions.go
MM-21987 Resolve mentions in slash commands (#13762)
2020-03-11 11:50:12 +01:00
audit_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
audit.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
auditconv_test.go
MM-22785 audit server CLI (#14144)
2020-04-08 00:52:30 -04:00
auditconv.go
MM-22785 audit server CLI (#14144)
2020-04-08 00:52:30 -04:00
audits_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
audits.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
authorize_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
authorize.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
bot_default_image.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
bot_test.go
[MM-17422] Added code to update, delete last bot_icon time in model.bot. (#12229)
2019-12-29 15:30:18 +01:00
bot.go
[MM-17422] Added code to update, delete last bot_icon time in model.bot. (#12229)
2019-12-29 15:30:18 +01:00
builtin.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
bundle_info_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
bundle_info.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
channel_count.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
channel_data.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
channel_list.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
channel_member_history_result.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
channel_member_history.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
channel_member_test.go
Remove remaining t.Fatal from the codebase (#13876)
2020-02-13 17:53:23 +01:00
channel_member.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
channel_mentions.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
channel_search_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
channel_search.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
channel_stats.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
channel_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
channel_view_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
channel_view.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
channel.go
[MM-23727] Make channel validation consistent on the server (#14230)
2020-04-26 12:38:33 -04:00
client4_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
client4.go
MM-24037 Adding getKnowUsers API endpoint (#14332)
2020-04-28 12:52:43 +02:00
cluster_discovery_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
cluster_discovery.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
cluster_info_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
cluster_info.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
cluster_message_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
cluster_message.go
MM-22212 & MM-22208: Read from the higher-scoped scheme if the permission is non-moderated. (#13813)
2020-03-23 13:44:20 -04:00
cluster_stats_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
cluster_stats.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
command_args_test.go
MM-21987 Resolve mentions in slash commands (#13762)
2020-03-11 11:50:12 +01:00
command_args.go
MM-21987 Resolve mentions in slash commands (#13762)
2020-03-11 11:50:12 +01:00
command_request.go
MM-21727 add an endpoint to move a command to another team (#13624)
2020-01-29 11:56:21 -05:00
command_response_test.go
GH-12702 v2: Add new command response parameter: "skip_slack_p… (#13420)
2020-01-17 08:34:11 +01:00
command_response.go
GH-12702 v2: Add new command response parameter: "skip_slack_p… (#13420)
2020-01-17 08:34:11 +01:00
command_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
command_webhook_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
command_webhook.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
command.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
compliance_post_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
compliance_post.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
compliance_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
compliance.go
Fix inconsistencies in variable names for struct methods (#13561)
2020-01-07 10:47:03 +01:00
config_test.go
Minor model/config.go coverage improvements (#14094)
2020-03-20 16:34:12 -03:00
config.go
Minor model/config.go coverage improvements (#14094)
2020-03-20 16:34:12 -03:00
data_retention_policy.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
emoji_data.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
emoji_search_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
emoji_search.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
emoji_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
emoji.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
file_info_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
file_info.go
MM-17912: Allow searching for files through plugin API (#13647)
2020-02-14 16:21:54 -04:00
file.go
MM-20934: Fixing int overflow in 32 bits on MaxImageSize check (#14280)
2020-04-16 15:23:27 +02:00
gitlab.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
group_member.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
group_syncable.go
MM-20644: Add users to teams as a SchemeAdmin based on a new configuration field on GroupTeams and GroupChannels records. (#13361)
2020-01-10 09:19:39 -08:00
group.go
MM-23015: Enable or disable group mentions (#14010)
2020-04-13 11:37:29 -07:00
guest_invite.go
Fix inconsistencies in variable names for struct methods (#13561)
2020-01-07 10:47:03 +01:00
incoming_webhook_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
incoming_webhook.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
initial_load_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
initial_load.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
integration_action_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
integration_action.go
[GH-13968] Add "skip_slack_parsing" to PostActionIntegration… (#13976)
2020-03-26 14:27:55 +01:00
job.go
Fix inconsistencies in variable names for struct methods (#13561)
2020-01-07 10:47:03 +01:00
ldap.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
license_test.go
license: dropping PhoneNumber field from the license (#14307)
2020-04-20 14:20:35 +02:00
license.go
license: dropping PhoneNumber field from the license (#14307)
2020-04-20 14:20:35 +02:00
link_metadata_test.go
Use require/assert.Empty instead of require/assert.Len(t, X, 0) (#13413)
2019-12-22 12:35:31 +01:00
link_metadata.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
manifest_test.go
Allow placeholder for types number and longtext (#13809)
2020-02-05 10:46:58 +01:00
manifest.go
Allow placeholder for types number and longtext (#13809)
2020-02-05 10:46:58 +01:00
marketplace_plugin.go
MM-19606- Rework Prepackaged Plugins (#13449)
2020-01-15 13:38:55 -05:00
mention_map_test.go
MM-21987 Resolve mentions in slash commands (#13762)
2020-03-11 11:50:12 +01:00
mention_map.go
MM-21987 Resolve mentions in slash commands (#13762)
2020-03-11 11:50:12 +01:00
message_export.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
mfa_secret_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
mfa_secret.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
migration.go
[MM-23019] Create use_group_mentions permission and migrate existing roles (#13987)
2020-03-30 23:08:48 -04:00
modeltestlib_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
oauth_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
oauth.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
outgoing_webhook_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
outgoing_webhook.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
permission_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
permission.go
[MM-23019] Create use_group_mentions permission and migrate existing roles (#13987)
2020-03-30 23:08:48 -04:00
plugin_event_data.go
MM-16261: Synchronize plugins in HA (#11657)
2019-07-18 15:05:53 -03:00
plugin_key_value_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
plugin_key_value.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
plugin_kvset_options.go
MM-21672: KVCompareAndSet improvements (#13858)
2020-02-18 16:32:46 -04:00
plugin_status.go
[MM-15831] Improve system for storing status of available plug… (#11185)
2019-06-25 17:44:08 -04:00
plugin_valid_test.go
Add IsValid method to *Manifest struct (#13609)
2020-01-17 21:08:55 +01:00
plugin_valid.go
Add IsValid method to *Manifest struct (#13609)
2020-01-17 21:08:55 +01:00
plugins_response_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
plugins_response.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
post_embed.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
post_list_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
post_list.go
[MM-21378] Add mutex to model.Post to guard against race conditions on Post.Props (#13884)
2020-03-13 21:12:20 +01:00
post_metadata.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
post_search_results.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
post_test.go
[MM-21378] Add mutex to model.Post to guard against race conditions on Post.Props (#13884)
2020-03-13 21:12:20 +01:00
post.go
[MM-21378] Add mutex to model.Post to guard against race conditions on Post.Props (#13884)
2020-03-13 21:12:20 +01:00
preference_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
preference.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
preferences.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
push_notification_test.go
Avoid panic when push messages are empty or nil (#13751)
2020-01-29 10:08:27 +01:00
push_notification.go
MM-23547: remove redundant JSON parsing in push notifications (#14181)
2020-04-08 08:38:57 -07:00
push_response_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
push_response.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
reaction_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
reaction.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
role_test.go
MM-22212 & MM-22208: Read from the higher-scoped scheme if the permission is non-moderated. (#13813)
2020-03-23 13:44:20 -04:00
role.go
MM-23876: Fix for patching channel moderations with a null team schem… (#14239)
2020-04-07 17:35:03 +05:30
saml_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
saml.go
MM-20698: Add server support for getting SAML metadata and updating S… (#13311)
2020-01-09 21:25:20 -08:00
scheduled_task_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
scheduled_task.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
scheme.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
search_params_test.go
Use require.Len instead of require.Equal for length checks in model/search_params_test.go (#13410)
2019-12-17 12:12:38 +01:00
search_params.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
security_bulletin_test.go
Use require/assert.Empty instead of require/assert.Len(t, X, 0) (#13413)
2019-12-22 12:35:31 +01:00
security_bulletin.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
session_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
session.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
slack_attachment_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
slack_attachment.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
slack_compatibility_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
slack_compatibility.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
status_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
status.go
Fixing race condition on status serialization (#14147)
2020-03-27 11:40:52 +01:00
suggest_command_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
suggest_command.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
switch_request_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
switch_request.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
system_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
system.go
MM-23093 Implement Server Setup telemetry - server configuration (#14374)
2020-04-30 18:18:12 +03:00
team_member_test.go
Remove remaining t.Fatal from the codebase (#13876)
2020-02-13 17:53:23 +01:00
team_member.go
[MM-21517] Team Member Manage User Modal not display correct roles (#14043)
2020-03-30 10:48:03 -04:00
team_search_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
team_search.go
Fix inconsistencies in variable names for struct methods (#13561)
2020-01-07 10:47:03 +01:00
team_stats.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
team_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
team.go
MM-23489 Fix poor Unicode handling in display names (#14214)
2020-04-07 16:56:07 -04:00
terms_of_service_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
terms_of_service.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
token.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
user_access_token_search_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
user_access_token_search.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
user_access_token_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
user_access_token.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
user_autocomplete.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
user_count.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
user_get.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
user_search_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
user_search.go
Adding the new search engine abstraction (#13304)
2020-03-13 15:33:18 +01:00
user_terms_of_Service_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
user_terms_of_service.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
user_test.go
MM-7881 non-case sensitive username notifications off by default (#13851)
2020-03-25 09:43:25 -07:00
user.go
MM-23489 Fix poor Unicode handling in display names (#14214)
2020-04-07 16:56:07 -04:00
users_stats.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
utils_test.go
Increase entropy for MFA secret (#14290)
2020-04-22 18:46:16 +02:00
utils.go
Update restricted team names. (#14386)
2020-04-28 07:37:19 -07:00
version_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
version.go
Bump app version to 5.24 (#14220)
2020-04-07 15:22:54 +02:00
websocket_client_test.go
MM-24547: Fix writer leak when connection closes (#14406)
2020-04-30 23:50:13 +05:30
websocket_client.go
MM-24547: Fix writer leak when connection closes (#14406)
2020-04-30 23:50:13 +05:30
websocket_message_test.go
MM-21481: Fixed several issues from user marshalling (#13627)
2020-01-16 09:18:08 +01:00
websocket_message.go
MM-23605 Create new team scheme updated socket event (#14305)
2020-04-27 13:26:52 -04:00
websocket_request_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
websocket_request.go
Added some godocs to a few websocket related structs (#13451)
2019-12-24 08:51:03 -05:00