Files
mattermost/server
f747d6242a Fix Attribute Management listing permissions, Classification license gate, and sync-source cascade (#38830)
* Honor Attribute Management page disabled state on the listing

Wire the schema isDisabled prop through GlobalAttributes so non-sysadmins
see a disabled New attribute button, View instead of Edit, and a disabled
Delete action. Also align the Classification row license gate with the
Classification Markings route (Enterprise Advanced).

Co-authored-by: Julien Tant <JulienTant@users.noreply.github.com>

* Point Attribute-Based Access help links at Attribute Management

The old system_attributes/user_attributes URLs only redirect now. Update
the ABAC enable help text and related empty-state CTAs to manage_attributes
and rename the link label to Attribute Management.

Co-authored-by: Julien Tant <JulienTant@users.noreply.github.com>

* Cascade template LDAP/SAML sync source edits to linked Users fields

LDAP sync reads attrs.ldap/attrs.saml on the Users field, which were only
copied from the template at create time. When Save updates the template
sync source, also PATCH the already-linked Users field so existing sync
mappings stay in sync.

Co-authored-by: Julien Tant <JulienTant@users.noreply.github.com>

* Add Playwright coverage for Attribute Management admin fixes

Cover the non-sysadmin read-only listing, ABAC help link to
Attribute Management, and cascading LDAP sync-source edits onto
already-linked Users fields.

Co-authored-by: Julien Tant <JulienTant@users.noreply.github.com>

* Fix Prettier formatting in attribute_management_link e2e spec

Co-authored-by: Julien Tant <JulienTant@users.noreply.github.com>

* Add JSDoc @objective to attribute_management_link e2e spec

lint:test-docs requires a preceding JSDoc with @objective for tagged
test() declarations; the file-level comment was not attached to the test.

Co-authored-by: Julien Tant <JulienTant@users.noreply.github.com>

* Remove low-value ABAC help-link Playwright e2e

The href change is a static admin_definition/i18n string; listing
permissions and sync-source cascade remain covered by e2e.

Co-authored-by: Julien Tant <JulienTant@users.noreply.github.com>

* Hide Classification row when Classification Markings is unreachable

Below Enterprise Advanced (or with the flag off), do not show the
Classification template as an ordinary Edit/Delete row — hide it.

Co-authored-by: Julien Tant <JulienTant@users.noreply.github.com>

* Fix ABAC help link navigation to Attribute Management

Use React Router Link with an absolute admin_console path so the
help-text control navigates inside the SPA instead of a relative
plain anchor that did not reliably change the route.

Co-authored-by: Julien Tant <JulienTant@users.noreply.github.com>

* Fill missing i18n description for emoji too-large-to-process error

Enterprise Check i18n fails when extract adds an empty description for
api.emoji.upload.large_image.too_large_to_process.app_error (introduced
without one in #38716). Add a translator-facing description so extract
stays clean.

Co-authored-by: Julien Tant <JulienTant@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Julien Tant <JulienTant@users.noreply.github.com>
2026-09-30 17:19:25 +00:00
..
2023-03-22 17:22:27 -04:00
2023-03-22 17:22:27 -04:00
2023-03-22 17:22:27 -04:00
2023-03-22 17:22:27 -04:00
2026-09-22 13:12:48 +03:00
2026-09-22 13:12:48 +03:00
2024-05-15 12:05:13 -03:00