mirror of
https://github.com/mattermost/mattermost.git
synced 2025-02-25 18:55:24 -06:00
* Adds default team to the remote cluster entity A new DefaultTeamId field is added to the RemoteCluster entity and its endpoints, and used when receiving channel invites to choose in which team to create a new channel. This will be later extended with the ability for the system admin to manually accept invites, choosing which team to create the channel on each. This use case will be triggered when the DefaultTeamId field is empty, which now simply chooses the first team it finds in the database as a fallback. * Fix migrations list * Fixes channelinvite test case * Fix i18n * Fix migration list
249 lines
8.7 KiB
Go
249 lines
8.7 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package sharedchannel
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/plugin/plugintest/mock"
|
|
"github.com/mattermost/mattermost/server/public/shared/mlog"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store/storetest/mocks"
|
|
)
|
|
|
|
var (
|
|
mockTypeChannel = mock.AnythingOfType("*model.Channel")
|
|
mockTypeString = mock.AnythingOfType("string")
|
|
mockTypeReqContext = mock.AnythingOfType("*request.Context")
|
|
mockTypeContext = mock.MatchedBy(func(ctx context.Context) bool { return true })
|
|
)
|
|
|
|
func TestOnReceiveChannelInvite(t *testing.T) {
|
|
t.Run("when msg payload is empty, it does nothing", func(t *testing.T) {
|
|
mockServer := &MockServerIface{}
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
mockServer.On("Log").Return(logger)
|
|
mockApp := &MockAppIface{}
|
|
scs := &Service{
|
|
server: mockServer,
|
|
app: mockApp,
|
|
}
|
|
|
|
mockStore := &mocks.Store{}
|
|
mockServer = scs.server.(*MockServerIface)
|
|
mockServer.On("GetStore").Return(mockStore)
|
|
|
|
remoteCluster := &model.RemoteCluster{}
|
|
msg := model.RemoteClusterMsg{}
|
|
|
|
err := scs.onReceiveChannelInvite(msg, remoteCluster, nil)
|
|
require.NoError(t, err)
|
|
mockStore.AssertNotCalled(t, "Channel")
|
|
})
|
|
|
|
t.Run("when invitation prescribes a readonly channel, it does create a readonly channel", func(t *testing.T) {
|
|
mockServer := &MockServerIface{}
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
mockServer.On("Log").Return(logger)
|
|
mockApp := &MockAppIface{}
|
|
scs := &Service{
|
|
server: mockServer,
|
|
app: mockApp,
|
|
}
|
|
|
|
mockStore := &mocks.Store{}
|
|
remoteCluster := &model.RemoteCluster{Name: "test", DefaultTeamId: model.NewId()}
|
|
invitation := channelInviteMsg{
|
|
ChannelId: model.NewId(),
|
|
TeamId: model.NewId(),
|
|
ReadOnly: true,
|
|
Type: model.ChannelTypeOpen,
|
|
}
|
|
payload, err := json.Marshal(invitation)
|
|
require.NoError(t, err)
|
|
|
|
msg := model.RemoteClusterMsg{
|
|
Payload: payload,
|
|
}
|
|
mockChannelStore := mocks.ChannelStore{}
|
|
mockSharedChannelStore := mocks.SharedChannelStore{}
|
|
channel := &model.Channel{
|
|
Id: invitation.ChannelId,
|
|
TeamId: invitation.TeamId,
|
|
Type: invitation.Type,
|
|
}
|
|
|
|
mockChannelStore.On("Get", invitation.ChannelId, true).Return(nil, &store.ErrNotFound{})
|
|
mockSharedChannelStore.On("Save", mock.Anything).Return(nil, nil)
|
|
mockSharedChannelStore.On("SaveRemote", mock.Anything).Return(nil, nil)
|
|
mockStore.On("Channel").Return(&mockChannelStore)
|
|
mockStore.On("SharedChannel").Return(&mockSharedChannelStore)
|
|
|
|
mockServer.On("GetStore").Return(mockStore)
|
|
createPostPermission := model.ChannelModeratedPermissionsMap[model.PermissionCreatePost.Id]
|
|
createReactionPermission := model.ChannelModeratedPermissionsMap[model.PermissionAddReaction.Id]
|
|
updateMap := model.ChannelModeratedRolesPatch{
|
|
Guests: model.NewPointer(false),
|
|
Members: model.NewPointer(false),
|
|
}
|
|
|
|
mockApp.On("CreateChannelWithUser", mockTypeReqContext, mockTypeChannel, mockTypeString).Return(channel, nil)
|
|
|
|
readonlyChannelModerations := []*model.ChannelModerationPatch{
|
|
{
|
|
Name: &createPostPermission,
|
|
Roles: &updateMap,
|
|
},
|
|
{
|
|
Name: &createReactionPermission,
|
|
Roles: &updateMap,
|
|
},
|
|
}
|
|
mockApp.On("PatchChannelModerationsForChannel", mock.Anything, channel, readonlyChannelModerations).Return(nil, nil).Maybe()
|
|
defer mockApp.AssertExpectations(t)
|
|
|
|
err = scs.onReceiveChannelInvite(msg, remoteCluster, nil)
|
|
require.NoError(t, err)
|
|
})
|
|
|
|
t.Run("when invitation prescribes a readonly channel and readonly update fails, it returns an error", func(t *testing.T) {
|
|
mockServer := &MockServerIface{}
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
mockServer.On("Log").Return(logger)
|
|
mockApp := &MockAppIface{}
|
|
scs := &Service{
|
|
server: mockServer,
|
|
app: mockApp,
|
|
}
|
|
|
|
mockStore := &mocks.Store{}
|
|
remoteCluster := &model.RemoteCluster{Name: "test2"}
|
|
invitation := channelInviteMsg{
|
|
ChannelId: model.NewId(),
|
|
TeamId: model.NewId(),
|
|
ReadOnly: true,
|
|
Type: "0",
|
|
}
|
|
payload, err := json.Marshal(invitation)
|
|
require.NoError(t, err)
|
|
|
|
msg := model.RemoteClusterMsg{
|
|
Payload: payload,
|
|
}
|
|
mockChannelStore := mocks.ChannelStore{}
|
|
channel := &model.Channel{
|
|
Id: invitation.ChannelId,
|
|
}
|
|
mockTeamStore := mocks.TeamStore{}
|
|
team := &model.Team{
|
|
Id: model.NewId(),
|
|
}
|
|
|
|
mockChannelStore.On("Get", invitation.ChannelId, true).Return(nil, &store.ErrNotFound{})
|
|
mockTeamStore.On("GetAllPage", 0, 1, mock.Anything).Return([]*model.Team{team}, nil)
|
|
mockStore.On("Channel").Return(&mockChannelStore)
|
|
mockStore.On("Team").Return(&mockTeamStore)
|
|
|
|
mockServer = scs.server.(*MockServerIface)
|
|
mockServer.On("GetStore").Return(mockStore)
|
|
appErr := model.NewAppError("foo", "bar", nil, "boom", http.StatusBadRequest)
|
|
|
|
mockApp.On("CreateChannelWithUser", mockTypeReqContext, mockTypeChannel, mockTypeString).Return(channel, nil)
|
|
mockApp.On("PatchChannelModerationsForChannel", mock.Anything, channel, mock.Anything).Return(nil, appErr)
|
|
defer mockApp.AssertExpectations(t)
|
|
|
|
err = scs.onReceiveChannelInvite(msg, remoteCluster, nil)
|
|
require.Error(t, err)
|
|
assert.Equal(t, fmt.Sprintf("cannot make channel readonly `%s`: foo: bar, boom", invitation.ChannelId), err.Error())
|
|
})
|
|
|
|
t.Run("DM channels", func(t *testing.T) {
|
|
var testRemoteID = model.NewId()
|
|
testCases := []struct {
|
|
desc string
|
|
user1 *model.User
|
|
user2 *model.User
|
|
canSee bool
|
|
expectSuccess bool
|
|
}{
|
|
{"valid users", &model.User{Id: model.NewId(), RemoteId: &testRemoteID}, &model.User{Id: model.NewId()}, true, true},
|
|
{"swapped users", &model.User{Id: model.NewId()}, &model.User{Id: model.NewId(), RemoteId: &testRemoteID}, true, true},
|
|
{"two remotes", &model.User{Id: model.NewId(), RemoteId: &testRemoteID}, &model.User{Id: model.NewId(), RemoteId: &testRemoteID}, true, false},
|
|
{"two locals", &model.User{Id: model.NewId()}, &model.User{Id: model.NewId()}, true, false},
|
|
{"can't see", &model.User{Id: model.NewId(), RemoteId: &testRemoteID}, &model.User{Id: model.NewId()}, false, false},
|
|
{"invalid remoteid", &model.User{Id: model.NewId(), RemoteId: model.NewPointer("bogus")}, &model.User{Id: model.NewId()}, true, false},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.desc, func(t *testing.T) {
|
|
mockServer := &MockServerIface{}
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
mockServer.On("Log").Return(logger)
|
|
mockApp := &MockAppIface{}
|
|
scs := &Service{
|
|
server: mockServer,
|
|
app: mockApp,
|
|
}
|
|
|
|
mockStore := &mocks.Store{}
|
|
remoteCluster := &model.RemoteCluster{Name: "test3", CreatorId: model.NewId(), RemoteId: testRemoteID}
|
|
invitation := channelInviteMsg{
|
|
ChannelId: model.NewId(),
|
|
TeamId: model.NewId(),
|
|
ReadOnly: false,
|
|
Type: model.ChannelTypeDirect,
|
|
DirectParticipantIDs: []string{tc.user1.Id, tc.user2.Id},
|
|
}
|
|
payload, err := json.Marshal(invitation)
|
|
require.NoError(t, err)
|
|
|
|
msg := model.RemoteClusterMsg{
|
|
Payload: payload,
|
|
}
|
|
mockChannelStore := mocks.ChannelStore{}
|
|
mockSharedChannelStore := mocks.SharedChannelStore{}
|
|
channel := &model.Channel{
|
|
Id: invitation.ChannelId,
|
|
}
|
|
|
|
mockUserStore := mocks.UserStore{}
|
|
mockUserStore.On("Get", mockTypeContext, tc.user1.Id).
|
|
Return(tc.user1, nil)
|
|
mockUserStore.On("Get", mockTypeContext, tc.user2.Id).
|
|
Return(tc.user2, nil)
|
|
|
|
mockChannelStore.On("Get", invitation.ChannelId, true).Return(nil, errors.New("boom"))
|
|
mockChannelStore.On("GetByName", "", mockTypeString, true).Return(nil, &store.ErrNotFound{})
|
|
|
|
mockSharedChannelStore.On("Save", mock.Anything).Return(nil, nil)
|
|
mockSharedChannelStore.On("SaveRemote", mock.Anything).Return(nil, nil)
|
|
mockStore.On("Channel").Return(&mockChannelStore)
|
|
mockStore.On("SharedChannel").Return(&mockSharedChannelStore)
|
|
mockStore.On("User").Return(&mockUserStore)
|
|
|
|
mockServer = scs.server.(*MockServerIface)
|
|
mockServer.On("GetStore").Return(mockStore)
|
|
|
|
mockApp.On("GetOrCreateDirectChannel", mockTypeReqContext, mockTypeString, mockTypeString, mock.AnythingOfType("model.ChannelOption")).
|
|
Return(channel, nil).Maybe()
|
|
mockApp.On("UserCanSeeOtherUser", mockTypeReqContext, mockTypeString, mockTypeString).Return(tc.canSee, nil).Maybe()
|
|
|
|
defer mockApp.AssertExpectations(t)
|
|
|
|
err = scs.onReceiveChannelInvite(msg, remoteCluster, nil)
|
|
require.Equal(t, tc.expectSuccess, err == nil)
|
|
})
|
|
}
|
|
})
|
|
}
|